Bug 260527 - sysutils/mmc-utils: Various improvements to port
Summary: sysutils/mmc-utils: Various improvements to port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Marius Strobl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-18 23:45 UTC by Daniel Engberg
Modified: 2021-12-19 19:47 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (marius)


Attachments
Patch for mmc-utils (2.64 KB, patch)
2021-12-18 23:45 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-12-18 23:45:41 UTC
Created attachment 230228 [details]
Patch for mmc-utils

Use DISTVERSION as stated in Porter's Handbook [1]
Download tarball (snapshot) directly instead of hosting our own (reduces a lot of code)
Update pkg-descr with correct URL and remove reference to maintainer as it seems to be maintained by several other individuals

References:
[1] Table 2. Package Naming Examples (Tip section)
Comment 1 Marius Strobl freebsd_committer freebsd_triage 2021-12-19 15:39:22 UTC
Well, your suggestions are fine except:
- They don't solve the problem of the name of the distfile only containing a
  git hash and no date string, which for me was the whole reason for creating
  the maintainer-fetch target in the first place (with 9 lines not exactly
  being "a lot of code"). It looks like someone figured out a nifty approach
  allowing the distfile to be named as intended but still directly fetching
  from the master git repository for mail/alpine, which I chose to inherit.
- I don't want to bump PORTEPOCH w/o a real good reason and the tip referenced
  is just a suggestion and also only for new ports, no binding rule.
- pkg-descr is literally taken from WWW so I don't want to deviate w/o a good
  reason; chasing an outdated URL is, though.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-12-19 15:40:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e9dba04db7fe00a325c36a54e2470935decb8947

commit e9dba04db7fe00a325c36a54e2470935decb8947
Author:     Marius Strobl <marius@FreeBSD.org>
AuthorDate: 2021-12-19 15:16:38 +0000
Commit:     Marius Strobl <marius@FreeBSD.org>
CommitDate: 2021-12-19 15:39:40 +0000

    sysutils/mmc-utils: Minor changes to port

    - Fetch the distfile directly from the master git repository based on
      the nifty approach taken by mail/alpine instead of using a local copy.
      Note that this bumps the PORTVERSION to the last commit date (rather
      than last change date) of the repository w/o a change in source. [1]
    - Chase outdated repository URL in pkg-descr (still wrong in WWW). [2]

    PR:             260527
    Obtained from:  mail/alpine [1]
    Submitted by:   diizzy [2]

 sysutils/mmc-utils/Makefile  | 25 +++++++------------------
 sysutils/mmc-utils/distinfo  |  6 +++---
 sysutils/mmc-utils/pkg-descr |  2 +-
 3 files changed, 11 insertions(+), 22 deletions(-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2021-12-19 19:47:38 UTC
DISTFILE -> That's what we do for _all_ ports that use USE_GITLAB for example so I don't think it's much of an issue but it's not a hard requirement.

pkg-descr -> I couldn't find any reference to that text (claim) which is why I modified it and the fact that it's no longer a personal repo.

Best regards,
Daniel