Bug 260537 - www/grafana8: Fails to patch: Azure-go-autorest-b3a0b30a7423_GH0.tar.gz fetch: 167123: No such file or directory
Summary: www/grafana8: Fails to patch: Azure-go-autorest-b3a0b30a7423_GH0.tar.gz fetch...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Matthew Seaman
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-12-19 10:44 UTC by John Y.
Modified: 2021-12-20 00:02 UTC (History)
2 users (show)

See Also:
drtr0jan: maintainer-feedback+


Attachments
Poudriere build log (10.34 KB, text/plain)
2021-12-19 10:44 UTC, John Y.
no flags Details
grafana8.diff (1.44 KB, patch)
2021-12-19 20:03 UTC, Boris Korzun
drtr0jan: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Y. 2021-12-19 10:44:01 UTC
Created attachment 230240 [details]
Poudriere build log

My poudriere(8) instance can not build last (and previous) version of port. Now it can not fetch some source, and fail at fetch stage.

Build log in attach.
Comment 1 Boris Korzun 2021-12-19 20:03:25 UTC
Created attachment 230248 [details]
grafana8.diff

(In reply to John D. from comment #0)

It looks like a bug in "make makesum". Try to build with the attached patch.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2021-12-19 20:51:16 UTC
Is quarterly affected? If so, please set merge-quarterly flag to ?
Comment 3 Boris Korzun 2021-12-19 21:04:38 UTC
(In reply to Kubilay Kocak from comment #2)

Nope. Quarterly (8.2.7) doesn't use Azure/go-autorest.

I've checked "make fetch" on quarterly also. It had been passed successfully.
Comment 4 Matthew Seaman freebsd_committer freebsd_triage 2021-12-19 22:58:55 UTC
The distinfo all worked perfectly during my test builds yesterday and on Friday:

```
lucid-nonsense:~:% sha256 /usr/ports/distfiles/Azure-go-autorest-b3a0b30a7423_GH0.tar.gz
SHA256 (/usr/ports/distfiles/Azure-go-autorest-b3a0b30a7423_GH0.tar.gz) = 51b31571a26a5287eb67251aa69407bb6145f58253bdbb2e610b7eab7b0d762f
```

Let me investigate
Comment 5 John Y. 2021-12-19 23:06:36 UTC
Building has finished successfully with this patch. Thank you
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-12-19 23:48:13 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dcd67527ab526dcb8683565796f1ac2e8b6bc6a7

commit dcd67527ab526dcb8683565796f1ac2e8b6bc6a7
Author:     Matthew Seaman <matthew@FreeBSD.org>
AuthorDate: 2021-12-19 23:41:49 +0000
Commit:     Matthew Seaman <matthew@FreeBSD.org>
CommitDate: 2021-12-19 23:41:49 +0000

    www/grafana8: remove duplicates from distinfo

    The Azure go-autorest project (https://github.com/Azure/go-autorest)
    provides several go modules within the same tarball, but the Grafana
    code requires different commits for several of those modules, hence
    the same source appearing multiple times at different commmit hashes
    in distinfo.

    Unfortunately, with grafana 8.3.3, three of the go-autorest modules
    required the same commit hash, leading to duplication in the distinfo.
    This causes a problem when trying to download the distfiles the first
    time -- a number of the downloads will fail.  Repeatedly attempting to
    download will succeed for one more of the various different versions
    of the go-autorest distfile, until eventually everything has been
    successfully downloaded.

    Remove the duplicate items in distinfo so that first-time download
    into a virgin distfiles directory does succeed.  This means that the
    result of `make makesum` cannot be used un-edited.

    PR:             260537
    Reported by:    John D.

 www/grafana8/distinfo | 4 ----
 1 file changed, 4 deletions(-)
Comment 7 Matthew Seaman freebsd_committer freebsd_triage 2021-12-19 23:53:58 UTC
Committed, thanks!

This, and the previous update to 8.3.3 really should be MFH'd to 2021Q4
for the last 12 days of the quarter...
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-12-20 00:00:17 UTC
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1e810df64354af61e3f48f45229f93c2d24e236a

commit 1e810df64354af61e3f48f45229f93c2d24e236a
Author:     Matthew Seaman <matthew@FreeBSD.org>
AuthorDate: 2021-12-19 23:41:49 +0000
Commit:     Matthew Seaman <matthew@FreeBSD.org>
CommitDate: 2021-12-19 23:59:02 +0000

    www/grafana8: remove duplicates from distinfo

    The Azure go-autorest project (https://github.com/Azure/go-autorest)
    provides several go modules within the same tarball, but the Grafana
    code requires different commits for several of those modules, hence
    the same source appearing multiple times at different commmit hashes
    in distinfo.

    Unfortunately, with grafana 8.3.3, three of the go-autorest modules
    required the same commit hash, leading to duplication in the distinfo.
    This causes a problem when trying to download the distfiles the first
    time -- a number of the downloads will fail.  Repeatedly attempting to
    download will succeed for one more of the various different versions
    of the go-autorest distfile, until eventually everything has been
    successfully downloaded.

    Remove the duplicate items in distinfo so that first-time download
    into a virgin distfiles directory does succeed.  This means that the
    result of `make makesum` cannot be used un-edited.

    PR:             260537
    Reported by:    John D.

    (cherry picked from commit dcd67527ab526dcb8683565796f1ac2e8b6bc6a7)

 www/grafana8/distinfo | 4 ----
 1 file changed, 4 deletions(-)