Bug 260720 - x11-wm/nscde: add xsession integration
Summary: x11-wm/nscde: add xsession integration
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://cgit.freebsd.org/ports/tree/x...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-27 05:48 UTC by Graham Perrin
Modified: 2022-01-04 08:06 UTC (History)
2 users (show)

See Also:
freebsd: maintainer-feedback+

Attachments
[PATCH] x11-wm/nscde: update to 1.4_1 (2.90 KB, patch)
2022-01-01 07:12 UTC, Chris Moerz 		freebsd: maintainer-approval+
Details | Diff
Poudriere Log (115.53 KB, text/plain)
2022-01-01 07:13 UTC, Chris Moerz 		no flags Details
[PATCH] x11-wm/nscde: update to 1.4_1 (2.86 KB, patch)
2022-01-01 08:16 UTC, Chris Moerz 		freebsd: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2021-12-27 05:48:47 UTC 
<https://forums.freebsd.org/posts/548270> drew my attention to <https://github.com/NsCDE/NsCDE/wiki/NsCDE---Frequently-Asked-Questions-(FAQ)#user-content-installation>. I see: 

> … Installer.ksh … 
> 
> …
> • Puts "nscde.desktop" txt/ini file definition into /usr/share/xsessions 
>   (on some systems like BSD, this is /usr/local/share/xsessions) 
>   for your display manager to be aware of it. 
> …


The file does not exist: 

% pkg info --list nscde | grep /usr/local/share/xsessions
% pkg info --list nscde | grep xsessions
% pkg info --list nscde | grep -i installer
% ls -hl /usr/local/share/xsessions
total 1
-rw-r--r--  1 root  wheel   118B  2 May  2021 dwm.desktop
-rw-r--r--  1 root  wheel   1.6K 14 Oct 04:16 enlightenment.desktop
-rw-r--r--  1 root  wheel   7.7K 30 Sep 19:28 gnome-classic.desktop
-rw-r--r--  1 root  wheel   7.7K 12 Oct 09:28 gnome-xorg.desktop
-rw-r--r--  1 root  wheel   7.7K 12 Oct 09:28 gnome.desktop
-rw-r--r--  1 root  wheel   1.2K 31 Jan  2020 Lumina-DE.desktop
-rw-r--r--  1 root  wheel   2.1K 25 Nov 09:01 lxqt.desktop
-rw-r--r--  1 root  wheel   8.5K  9 Dec 06:13 mate.desktop
-rw-r--r--  1 root  wheel   208B  9 Dec 05:57 openbox-gnome.desktop
-rw-r--r--  1 root  wheel   195B  9 Dec 05:57 openbox-kde.desktop
-rw-r--r--  1 root  wheel   210B  9 Dec 05:57 openbox.desktop
-rw-r--r--  1 root  wheel   2.9K 21 Dec 04:41 plasma.desktop
-rw-r--r--  1 root  wheel   6.7K 13 Oct 00:31 xfce.desktop
-rw-r--r--  1 root  wheel   164B 25 Nov 12:16 xinitrc.desktop
% pkg info -x nscde
nscde-1.4
% uname -aKU
FreeBSD mowa219-gjp4-8570p-freebsd 14.0-CURRENT FreeBSD 14.0-CURRENT #118 main-n251923-4bae154fe8c: Sat Dec 25 08:03:37 GMT 2021     root@mowa219-gjp4-8570p-freebsd:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG  amd64 1400045 1400045
%
Comment 1 Chris Moerz 2021-12-27 18:13:41 UTC 
Yup, I suppose, we can add a generic file. I'll look into it.
Comment 2 Chris Moerz 2022-01-01 07:12:40 UTC 
Created attachment 230598 [details]
[PATCH] x11-wm/nscde: update to 1.4_1

This patch fixes missing xsessions integration for nscde 1.4.
Poudriere log will follow in a moment.
Comment 3 Chris Moerz 2022-01-01 07:13:30 UTC 
Created attachment 230599 [details]
Poudriere Log

Poudriere log for nscde-1.4_1
Comment 4 Chris Moerz 2022-01-01 08:16:09 UTC 
Created attachment 230600 [details]
[PATCH] x11-wm/nscde: update to 1.4_1

Thanks to Graham Perrin for notifying me of a missed merge section; I've fixed that in pkg-message now as well.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-03 08:33:42 UTC 
^Triage: simplifying title.
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-03 08:36:33 UTC 
Q/A:  Makefile: [157]: whitespace before end of line.

No need to update a new patch.
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-01-04 07:55:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7b5b1d6ca19fdde4439921f343ef6932a9ed189a

commit 7b5b1d6ca19fdde4439921f343ef6932a9ed189a
Author:     Chris Moerz <freebsd@ny-central.org>
AuthorDate: 2022-01-03 08:34:17 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-01-04 07:53:08 +0000

    x11-wm/nscde: add xsession integration

    Add missing files for xsessions integration.

    PR:     260720
    Reported by:    grahamperrin@gmail.com

 x11-wm/nscde/Makefile    | 7 +++++--
 x11-wm/nscde/pkg-message | 5 +++++
 x11-wm/nscde/pkg-plist   | 1 +
 3 files changed, 11 insertions(+), 2 deletions(-)
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-04 08:06:35 UTC 
Committed,

Thanks!