Created attachment 231144 [details] patch (made with git format-patch) Hello, mkdocs-simple-hooks is an MkDocs plugin to create hooks to call in the process of generating a website with MkDocs. poudriere testport: OK portlint: OK (just a warning about directory for dependency mkdocs, but it seems the case for other Python ports). Thanks
Review items: - LICENSE file is included in distribution file, add LICENSE_FILE accordingly - Package provides, entry_point, port should be made USE_PYTHON=concurrent safe - Consider using github sources so that tests can be run (add TEST_DEPENDS and a (do-)test target to port
(In reply to Kubilay Kocak from comment #1) I've made the modifications according to your review, in the new patch in attachment. Now Github is used instead of CHEESESHOP.
Created attachment 231167 [details] updated patch (made with git format-patch)
About portlint, the warning is: WARN: Makefile: you may want directory for dependency mkdocs>=1.2.0 to be textproc/py-mkdocs@${PY_FLAVOR}
Created attachment 231534 [details] Updated patch This is an updated patch with missing test_depends
Committed!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ed32a6daccaaddc8a597d3edc752399fb7101d4a commit ed32a6daccaaddc8a597d3edc752399fb7101d4a Author: Samir Noir <samir@noir.im> AuthorDate: 2022-01-19 20:58:12 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2022-03-12 05:43:38 +0000 textproc/py-mkdocs-simple-hooks: New port PR: 261322 textproc/Makefile | 1 + textproc/py-mkdocs-simple-hooks/Makefile (new) | 28 +++++++++++++++++++++++++ textproc/py-mkdocs-simple-hooks/distinfo (new) | 3 +++ textproc/py-mkdocs-simple-hooks/pkg-descr (new) | 4 ++++ 4 files changed, 36 insertions(+)