Bug 261367 - databases/sqlite3: Build with TCL is not deterministic
Summary: databases/sqlite3: Build with TCL is not deterministic
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mikhail Teterin
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-01-20 19:44 UTC by Mikhail Teterin
Modified: 2022-02-14 03:32 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (pavelivolkov)
koobs: merge-quarterly?

Attachments
Explicitly set TCL-related paths for configure (494 bytes, patch)
2022-01-20 19:44 UTC, Mikhail Teterin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer freebsd_triage 2022-01-20 19:44:26 UTC 
Created attachment 231192 [details]
Explicitly set TCL-related paths for configure

When the TCL option is enabled, and both TCL-8.6 and 8.7 are installed, configure script will prefer 8.7, which may be contrary to the DEFAULT_VERSIONS settings.

As a result, the build will use 8.7, but the packaging will fail because TCL_VER will be 8.6.

The attached patch solves this problem.

However, because it involves explicitly setting an autoconf "cache" variable, the issue may need to be brought up upstream -- the configure script ought to either accept the desired TCL-interpreter on command-line OR correctly deduce it from the specified TCL configuration directory.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-01-21 06:49:09 UTC 
^Triage: Reporter is committer, assign accordingly.

^Triage: simplify title
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2022-01-21 23:38:06 UTC 
^Triage: Reporter is committer assign accordingly
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-02-14 03:31:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2447a8078112d28ea245404f8ca5dfebb4742cbe

commit 2447a8078112d28ea245404f8ca5dfebb4742cbe
Author:     Mikhail Teterin <mi@FreeBSD.org>
AuthorDate: 2022-02-14 03:30:54 +0000
Commit:     Mikhail Teterin <mi@FreeBSD.org>
CommitDate: 2022-02-14 03:30:54 +0000

    databases/sqlite3: use the right TCL even if a newer version is installed

    PR:     261367

 databases/sqlite3/Makefile | 2 ++
 1 file changed, 2 insertions(+)