Bug 261585 - multimedia/gstreamer1: Update to 1.20.3
Summary: multimedia/gstreamer1: Update to 1.20.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thomas Zander
URL: https://reviews.freebsd.org/D36850
Keywords: needs-patch, needs-qa
Depends on: 267100 267132 267517
Blocks:
  Show dependency treegraph
 
Reported: 2022-01-30 23:57 UTC by László Károlyi
Modified: 2022-11-02 10:17 UTC (History)
10 users (show)

See Also:
riggs: maintainer-feedback+
riggs: merge-quarterly-
antoine: exp-run+


Attachments
proposal of bumping gstreamer1 plugins to 1.20.3 (451.36 KB, patch)
2022-09-20 18:00 UTC, zielonka michal
no flags Details | Diff
rebased patch (451.45 KB, patch)
2022-09-24 21:31 UTC, zielonka michal
no flags Details | Diff
Updated patch (425.80 KB, patch)
2022-09-26 05:28 UTC, Thomas Zander
no flags Details | Diff
Updated patch (426.37 KB, text/plain)
2022-09-27 05:27 UTC, Thomas Zander
no flags Details
Updated patch (426.37 KB, patch)
2022-09-28 05:26 UTC, Thomas Zander
no flags Details | Diff
Updated patch (426.37 KB, patch)
2022-10-01 13:13 UTC, Thomas Zander
no flags Details | Diff
Updated patch (432.84 KB, patch)
2022-10-02 11:56 UTC, Thomas Zander
no flags Details | Diff
Updated patch (457.65 KB, patch)
2022-10-02 12:25 UTC, Thomas Zander
no flags Details | Diff
Updated patch (271.65 KB, patch)
2022-10-03 07:52 UTC, Thomas Zander
no flags Details | Diff
Updated patch (274.67 KB, patch)
2022-10-08 14:19 UTC, Thomas Zander
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description László Károlyi 2022-01-30 23:57:45 UTC
Hey,

gstreamer 1.19.90 is out which fixes a critical bug in the shout2send plugin that happens with libshout>=2.4.2:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1363

Unfortunately, the current version of the shout2cast plugin doesn't work because of that.

Can we get an update to 1.19.90 of gstreamer please?
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-01-31 00:16:39 UTC
^Triage: Upstream notes that 1.19.90 is a pre-release [1][2] ...

 * Latest stable release: 1.18.5
 * Latest development release: [1.19.90 (1.20rc1)]

1.20.x is targeted (no firm date), for ... "1.20.0 is scheduled to be released around early February 2022.". I cannot identify release timing information for 1.18.6

It appears a backport was requested to 1.18 branch [3], which landed in 1343b9bff8 [4], which appears to be targeting 1.18.6 [5] (not yet released), which contained many bugfixes.

I would opt to backport this individual bugfix and merge to quarterly, downside being other 1.18.6 bugfixes remain unresolved. This is somewhat mitigated by a subsequent and likely imminent 1.18.6 release (it has a milestone, so appears to be targeted for release, and one bugix left, in progress), at which time the port can be updated and merged again (solely bugfixes), leaving latest branch to acquire the new 1.20.*

[1] https://lists.freedesktop.org/archives/gstreamer-announce/2022-January/000517.html
[2] https://gstreamer.freedesktop.org/releases/
[3] https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/1108
[4] https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/commit/1343b9bff8fbd3d4b5da1833830239ce9782afc3
[5] https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/1108#note_fc8576e97f2d8e883618199511ffe7d589faf431
[6] Upstream upstream (libshout) issue https://gitlab.xiph.org/xiph/icecast-libshout/-/issues/2316
Comment 2 László Károlyi 2022-01-31 00:40:23 UTC
Thanks.

I'm fine with having a backported 1.18 release as it's the same I'm developing with on my Linux box.

Everything seems to be working okay for my goals in it, aside from the shout2send bug.
Comment 3 László Károlyi 2022-02-03 09:27:25 UTC
FYI, 1.18.6 (with the shout2send bugfix) is out now:

https://gstreamer.freedesktop.org/news/#2022-02-02T15:30:00Z
Comment 4 László Károlyi 2022-02-04 10:48:57 UTC
GStreamer 1.20 (stable) is out as well:

https://9to5linux.com/gstreamer-1-20-open-source-multimedia-framework-is-out-this-is-whats-new
Comment 5 Charlie Li freebsd_committer freebsd_triage 2022-03-14 17:18:19 UTC
Looks like 1.20.1 dropped today. Also looks like the tarball naming conventions for components have consistently changed to gst-[component].
Comment 6 zielonka michal 2022-09-20 18:00:47 UTC
Created attachment 236714 [details]
proposal of bumping gstreamer1 plugins to 1.20.3

This is my try to bump of gstreamer1 plugins to 1.20.3 version. Generally I switched building to meson and added some options to meson.build/meson_options.txt.
Comment 7 Thomas Zander freebsd_committer freebsd_triage 2022-09-24 11:21:00 UTC
(In reply to zielonka michal from comment #6)

This is cool, thank you!
I had started with a 1.20.3 port and got about two thirds done, but yours looks great. Will take a look!
Comment 8 Thomas Zander freebsd_committer freebsd_triage 2022-09-24 11:47:19 UTC
(In reply to Thomas Zander from comment #7)

Could you maybe update your patch file such that it applies cleanly?
Comment 9 zielonka michal 2022-09-24 20:06:01 UTC
Ok. I will make rebase to origin/main.
Comment 10 zielonka michal 2022-09-24 21:31:16 UTC
Created attachment 236796 [details]
rebased patch

I've made rebased patch which should be cleanly applied.
Comment 11 Thomas Zander freebsd_committer freebsd_triage 2022-09-25 07:46:06 UTC
(In reply to zielonka michal from comment #10)

Thanks, patch applies cleanly, will base the remaining work on this one!
Comment 12 Thomas Zander freebsd_committer freebsd_triage 2022-09-26 05:28:34 UTC
Created attachment 236831 [details]
Updated patch

Updated the patch:
* Removed shebangfix where possible, used BINARY_ALIAS
* Fixed PORTREVISIONS
* Fixed formatting
Comment 13 Thomas Zander freebsd_committer freebsd_triage 2022-09-26 05:29:42 UTC
(In reply to Thomas Zander from comment #12)

Testbuilding the stuff for a while using a couple of configs. If everything looks good, we can put it up for an exp-run.
Comment 14 Thomas Zander freebsd_committer freebsd_triage 2022-09-27 05:27:25 UTC
Created attachment 236861 [details]
Updated patch

Some build and formatting fixes. Not 100% completed yet, at least one more patch to come later this week.
Comment 15 Thomas Zander freebsd_committer freebsd_triage 2022-09-28 05:26:38 UTC
Created attachment 236893 [details]
Updated patch

Tiny updates and rebase to yesterday night's head.
Comment 16 zielonka michal 2022-09-30 06:23:53 UTC
Can I help with this upgrade?
Comment 17 Thomas Zander freebsd_committer freebsd_triage 2022-10-01 13:13:21 UTC
Created attachment 236981 [details]
Updated patch

Rebased to HEAD
Comment 18 Thomas Zander freebsd_committer freebsd_triage 2022-10-01 13:15:13 UTC
(In reply to zielonka michal from comment #16)

Thank you, you have helped a lot already by working on this patchset.
In its current state, multimedia/gstreamer1-qt is not happy, but the rest seems fine. I'm going to put this up for review while we can debug the qt issue.
Comment 19 Thomas Zander freebsd_committer freebsd_triage 2022-10-01 13:28:16 UTC
It's for review on https://reviews.freebsd.org/D36850 , so folks can chime in.
Comment 20 Thomas Zander freebsd_committer freebsd_triage 2022-10-01 13:30:00 UTC
(In reply to zielonka michal from comment #16)

You applied quite some changes to the meson build files for gstreamer. Can you get in touch with the upstream project to get them included?
Comment 21 Thomas Zander freebsd_committer freebsd_triage 2022-10-02 11:56:41 UTC
Created attachment 237002 [details]
Updated patch

Sync patch with https://reviews.freebsd.org/D36850

Open TODOs:
* multimedia/pitivi is hopelessly outdated (0.999 is from 2018), needs to be updated to 2022.06 (https://download.gnome.org/sources/pitivi/2022/)
* graphics/gstreamer1-plugins-qt/ is broken (C++ / type / macro issues)
Comment 22 Thomas Zander freebsd_committer freebsd_triage 2022-10-02 12:25:28 UTC
Created attachment 237003 [details]
Updated patch

Updated pitivi to 2022.06 (builds and installs; no idea whether everything actually works)

Open TODOs:
* graphics/gstreamer1-plugins-qt/ is broken (C++ / type / macro issues)
Comment 23 Thomas Zander freebsd_committer freebsd_triage 2022-10-03 07:52:55 UTC
Created attachment 237034 [details]
Updated patch

Updated diff after removal of gstreamer1-plugins-gtk4 on head.
Comment 24 zielonka michal 2022-10-06 11:03:06 UTC
(In reply to Thomas Zander from comment #20)
O.K. I've made account on their gitlab, and I will prepare MR with changes from this meson files.
Comment 25 Thomas Zander freebsd_committer freebsd_triage 2022-10-08 14:19:28 UTC
Created attachment 237157 [details]
Updated patch

Updates:

* Fix remaining build failures with multimedia/gstreamer1-qt
* Rebased onto latest head
Comment 26 Thomas Zander freebsd_committer freebsd_triage 2022-10-08 14:20:41 UTC
@Antoine, can we get an exp-run on this attachment https://bugs.freebsd.org/bugzilla/attachment.cgi?id=237157 ?
Comment 27 Antoine Brodin freebsd_committer freebsd_triage 2022-10-12 18:15:42 UTC
Exp-run looks fine
Comment 28 commit-hook freebsd_committer freebsd_triage 2022-10-15 10:46:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e3b732b4791c01bdeeb671ffb557c1914763249f

commit e3b732b4791c01bdeeb671ffb557c1914763249f
Author:     Michal Zielonka <michal.zielonka.8001@gmail.com>
AuthorDate: 2022-09-20 17:47:40 +0000
Commit:     Thomas Zander <riggs@FreeBSD.org>
CommitDate: 2022-10-15 10:46:46 +0000

    Update gstreamer1 to upstream release 1.20.3

    PR:             261585
    Reviewed by:    riggs,jbeich,tcberner

    Differential Revision:  https://reviews.freebsd.org/D36850

 MOVED                                              |   1 +
 audio/gstreamer1-plugins-a52dec/Makefile           |   8 +-
 audio/gstreamer1-plugins-a52dec/pkg-plist (new)    |   1 +
 audio/gstreamer1-plugins-amrnb/Makefile            |  10 +-
 audio/gstreamer1-plugins-amrnb/pkg-plist (new)     |   2 +
 audio/gstreamer1-plugins-amrwbdec/Makefile         |  12 +-
 audio/gstreamer1-plugins-amrwbdec/pkg-plist (new)  |   1 +
 audio/gstreamer1-plugins-bs2b/Makefile             |  10 +-
 audio/gstreamer1-plugins-bs2b/pkg-plist (new)      |   1 +
 audio/gstreamer1-plugins-cdparanoia/Makefile       |   6 +-
 .../gstreamer1-plugins-cdparanoia/pkg-plist (new)  |   1 +
 audio/gstreamer1-plugins-chromaprint/Makefile      |   6 +-
 .../gstreamer1-plugins-chromaprint/pkg-plist (new) |   1 +
 audio/gstreamer1-plugins-faac/Makefile             |   6 +-
 audio/gstreamer1-plugins-faac/pkg-plist (new)      |   1 +
 audio/gstreamer1-plugins-faad/Makefile             |   8 +-
 audio/gstreamer1-plugins-faad/pkg-plist (new)      |   1 +
 audio/gstreamer1-plugins-flac/Makefile             |   6 +-
 audio/gstreamer1-plugins-flac/pkg-plist (new)      |   1 +
 audio/gstreamer1-plugins-flite/Makefile            |   6 +-
 audio/gstreamer1-plugins-flite/pkg-plist (new)     |   1 +
 audio/gstreamer1-plugins-gme/Makefile              |   6 +-
 audio/gstreamer1-plugins-gme/pkg-plist (new)       |   1 +
 audio/gstreamer1-plugins-gsm/Makefile              |   6 +-
 audio/gstreamer1-plugins-gsm/pkg-plist (new)       |   1 +
 audio/gstreamer1-plugins-jack/Makefile             |   6 +-
 audio/gstreamer1-plugins-jack/pkg-plist (new)      |   1 +
 audio/gstreamer1-plugins-ladspa/Makefile           |   8 +-
 audio/gstreamer1-plugins-ladspa/pkg-plist (new)    |   1 +
 audio/gstreamer1-plugins-lame/Makefile             |   6 +-
 audio/gstreamer1-plugins-lame/pkg-plist (new)      |   1 +
 audio/gstreamer1-plugins-lv2/Makefile              |  12 +-
 audio/gstreamer1-plugins-lv2/pkg-plist (new)       |   1 +
 audio/gstreamer1-plugins-modplug/Makefile          |   6 +-
 audio/gstreamer1-plugins-modplug/pkg-plist (new)   |   1 +
 audio/gstreamer1-plugins-mpg123/Makefile           |   6 +-
 audio/gstreamer1-plugins-mpg123/pkg-plist (new)    |   1 +
 audio/gstreamer1-plugins-musepack/Makefile         |   6 +-
 audio/gstreamer1-plugins-musepack/pkg-plist (new)  |   1 +
 audio/gstreamer1-plugins-ogg/Makefile              |   6 +-
 audio/gstreamer1-plugins-ogg/pkg-plist (new)       |   1 +
 audio/gstreamer1-plugins-openmpt/Makefile          |  11 +-
 audio/gstreamer1-plugins-openmpt/pkg-plist (new)   |   1 +
 audio/gstreamer1-plugins-opus/Makefile             |   6 +-
 audio/gstreamer1-plugins-opus/pkg-plist (new)      |   1 +
 audio/gstreamer1-plugins-pulse/Makefile            |   6 +-
 audio/gstreamer1-plugins-pulse/pkg-plist (new)     |   1 +
 audio/gstreamer1-plugins-shout2/Makefile           |   6 +-
 audio/gstreamer1-plugins-shout2/pkg-plist (new)    |   1 +
 audio/gstreamer1-plugins-sidplay/Makefile          |   8 +-
 audio/gstreamer1-plugins-sidplay/pkg-plist (new)   |   1 +
 audio/gstreamer1-plugins-sndfile/Makefile          |   6 +-
 audio/gstreamer1-plugins-sndfile/pkg-plist (new)   |   1 +
 audio/gstreamer1-plugins-soundtouch/Makefile       |   5 +-
 .../gstreamer1-plugins-soundtouch/pkg-plist (new)  |   1 +
 audio/gstreamer1-plugins-speex/Makefile            |   6 +-
 audio/gstreamer1-plugins-speex/pkg-plist (new)     |   1 +
 audio/gstreamer1-plugins-taglib/Makefile           |   6 +-
 audio/gstreamer1-plugins-taglib/pkg-plist (new)    |   1 +
 audio/gstreamer1-plugins-twolame/Makefile          |   6 +-
 audio/gstreamer1-plugins-twolame/pkg-plist (new)   |   1 +
 audio/gstreamer1-plugins-vorbis/Makefile           |   7 +-
 audio/gstreamer1-plugins-vorbis/pkg-plist (new)    |   1 +
 audio/gstreamer1-plugins-wavpack/Makefile          |   6 +-
 audio/gstreamer1-plugins-wavpack/pkg-plist (new)   |   1 +
 audio/gstreamer1-plugins-webrtcdsp/Makefile        |   6 +-
 audio/gstreamer1-plugins-webrtcdsp/pkg-plist (new) |   1 +
 comms/gstreamer1-plugins-spandsp/Makefile          |   6 +-
 comms/gstreamer1-plugins-spandsp/pkg-plist (new)   |   1 +
 devel/gstreamer1-plugins-soup/Makefile             |   6 +-
 devel/gstreamer1-plugins-soup/pkg-plist (new)      |   1 +
 ftp/gstreamer1-plugins-curl/Makefile               |   7 +-
 ftp/gstreamer1-plugins-curl/pkg-plist (new)        |   1 +
 graphics/gstreamer1-plugins-aalib/Makefile         |   7 +-
 graphics/gstreamer1-plugins-aalib/pkg-plist (new)  |   1 +
 graphics/gstreamer1-plugins-cairo/Makefile         |   6 +-
 graphics/gstreamer1-plugins-cairo/pkg-plist (new)  |   1 +
 graphics/gstreamer1-plugins-gdkpixbuf/Makefile     |   8 +-
 .../gstreamer1-plugins-gdkpixbuf/pkg-plist (new)   |   1 +
 graphics/gstreamer1-plugins-gl/Makefile            |  31 +-
 graphics/gstreamer1-plugins-gl/pkg-plist           |  21 +-
 graphics/gstreamer1-plugins-jpeg/Makefile          |   6 +-
 graphics/gstreamer1-plugins-jpeg/pkg-plist (new)   |   1 +
 graphics/gstreamer1-plugins-kms/Makefile           |   6 +-
 graphics/gstreamer1-plugins-kms/pkg-plist (new)    |   1 +
 graphics/gstreamer1-plugins-libcaca/Makefile       |   6 +-
 .../gstreamer1-plugins-libcaca/pkg-plist (new)     |   1 +
 graphics/gstreamer1-plugins-libvisual/Makefile     |   6 +-
 .../gstreamer1-plugins-libvisual/pkg-plist (new)   |   1 +
 graphics/gstreamer1-plugins-opencv/Makefile        |   4 +-
 graphics/gstreamer1-plugins-opencv/pkg-plist       |   2 -
 graphics/gstreamer1-plugins-openexr/Makefile       |  10 +-
 .../gstreamer1-plugins-openexr/pkg-plist (new)     |   1 +
 graphics/gstreamer1-plugins-openjpeg/Makefile      |   6 +-
 .../files/patch-inc (gone)                         |  30 -
 .../gstreamer1-plugins-openjpeg/pkg-plist (new)    |   1 +
 graphics/gstreamer1-plugins-png/Makefile           |   8 +-
 graphics/gstreamer1-plugins-png/pkg-plist (new)    |   1 +
 graphics/gstreamer1-plugins-qt/Makefile            |  11 +-
 graphics/gstreamer1-plugins-qt/pkg-plist (new)     |   1 +
 graphics/gstreamer1-plugins-rsvg/Makefile          |   6 +-
 graphics/gstreamer1-plugins-rsvg/pkg-plist (new)   |   1 +
 graphics/gstreamer1-plugins-vulkan/Makefile        |  15 +-
 graphics/gstreamer1-plugins-vulkan/pkg-plist (new) |  53 ++
 graphics/gstreamer1-plugins-webp/Makefile          |   6 +-
 graphics/gstreamer1-plugins-webp/pkg-plist (new)   |   1 +
 graphics/gstreamer1-plugins-zbar/Makefile          |   6 +-
 graphics/gstreamer1-plugins-zbar/pkg-plist (new)   |   1 +
 multimedia/Makefile                                |   1 -
 multimedia/gstreamer1-editing-services/Makefile    |  24 +-
 multimedia/gstreamer1-editing-services/distinfo    |   6 +-
 multimedia/gstreamer1-editing-services/pkg-plist   |   4 +
 multimedia/gstreamer1-libav/Makefile               |  21 +-
 multimedia/gstreamer1-libav/distinfo               |   8 +-
 multimedia/gstreamer1-libav/pkg-plist              |  22 -
 multimedia/gstreamer1-plugins-all/Makefile         |   3 +-
 multimedia/gstreamer1-plugins-aom/Makefile         |   6 +-
 multimedia/gstreamer1-plugins-aom/pkg-plist (new)  |   1 +
 multimedia/gstreamer1-plugins-assrender/Makefile   |   8 +-
 .../gstreamer1-plugins-assrender/pkg-plist (new)   |   1 +
 multimedia/gstreamer1-plugins-bad/Makefile         | 118 +++-
 .../files/patch-data_meson.build (new)             |  12 +
 .../files/patch-ext_dash_meson.build (new)         |  21 +
 .../files/patch-ext_hls_meson.build (new)          |  12 +
 .../patch-ext_opencv_gstcvdilateerode.cpp (gone)   |  11 -
 .../files/patch-ext_openjpeg_meson.build (new)     |  11 +
 .../files/patch-ext_openmpt_meson.build (new)      |  11 +
 .../patch-ext_smoothstreaming_meson.build (new)    |  17 +
 .../files/patch-ext_spandsp_gstspanplc.h (new)     |  10 +
 .../files/patch-ext_webrtcdsp_meson.build (new)    |  11 +
 .../files/patch-git_a0cd455d (gone)                | 142 ----
 .../files/patch-git_dc57fb70 (gone)                |  26 -
 ...ch-gst-libs_gst_adaptivedemux_meson.build (new) |  20 +
 .../patch-gst-libs_gst_audio_meson.build (new)     |  12 +
 ...gst-libs_gst_basecamerabinsrc_meson.build (new) |  12 +
 ...tch-gst-libs_gst_codecparsers_meson.build (new) |  12 +
 .../patch-gst-libs_gst_codecs_meson.build (new)    |  15 +
 .../patch-gst-libs_gst_insertbin_meson.build (new) |  12 +
 ...patch-gst-libs_gst_interfaces_meson.build (new) |  12 +
 .../patch-gst-libs_gst_isoff_meson.build (new)     |  21 +
 .../patch-gst-libs_gst_mpegts_meson.build (new)    |  12 +
 .../patch-gst-libs_gst_play_meson.build (new)      |  12 +
 .../patch-gst-libs_gst_player_meson.build (new)    |  12 +
 .../patch-gst-libs_gst_sctp_meson.build (new)      |  12 +
 ...patch-gst-libs_gst_transcoder_meson.build (new) |  12 +
 ...ch-gst-libs_gst_uridownloader_meson.build (new) |  15 +
 .../patch-gst-libs_gst_webrtc_meson.build (new)    |  12 +
 .../files/patch-meson.build (new)                  |  18 +
 .../files/patch-meson__options.txt (new)           |  42 ++
 .../files/patch-sys_kms_meson.build (new)          |  13 +
 .../files/patch-sys_msdk_meson.build (new)         |  16 +
 .../files/patch-tests_examples_meson.build (new)   |  74 +++
 .../files/patch-tools_meson.build (new)            |  11 +
 multimedia/gstreamer1-plugins-bad/pkg-plist        |  81 ++-
 multimedia/gstreamer1-plugins-core/Makefile        |   2 +-
 multimedia/gstreamer1-plugins-dash/Makefile        |  11 +-
 multimedia/gstreamer1-plugins-dash/pkg-plist (new) |   1 +
 multimedia/gstreamer1-plugins-dts/Makefile         |   8 +-
 multimedia/gstreamer1-plugins-dts/pkg-plist (new)  |   1 +
 multimedia/gstreamer1-plugins-dv/Makefile          |   8 +-
 multimedia/gstreamer1-plugins-dv/pkg-plist (new)   |   1 +
 multimedia/gstreamer1-plugins-dvdread/Makefile     |   8 +-
 .../gstreamer1-plugins-dvdread/pkg-plist (new)     |   1 +
 multimedia/gstreamer1-plugins-gnonlin/Makefile     |   4 +-
 multimedia/gstreamer1-plugins-good/Makefile        |  60 +-
 .../files/patch-ext_qt_gstqsgtexture.cc (gone)     |  11 -
 .../files/patch-ext_qt_gstqtglutility.cc (gone)    |  15 -
 .../files/patch-ext_qt_qtitem.cc (gone)            |  11 -
 .../files/patch-ext_qt_qtwindow.cc (gone)          |  20 -
 .../files/patch-sys_oss_gstosshelper.c (gone)      |  82 ---
 .../files/patch-sys_oss_gstosssink.c (gone)        |  73 --
 .../files/patch-sys_oss_gstosssrc.c (gone)         |  73 --
 .../files/patch-sys_v4l2_gstv4l2object.c (gone)    |  13 -
 .../files/patch-sys_v4l2_v4l2__calls.c (new)       |  15 +
 multimedia/gstreamer1-plugins-good/pkg-plist       |   1 +
 multimedia/gstreamer1-plugins-hls/Makefile         |   6 +-
 multimedia/gstreamer1-plugins-hls/pkg-plist (new)  |   1 +
 multimedia/gstreamer1-plugins-kate/Makefile        |   6 +-
 multimedia/gstreamer1-plugins-kate/pkg-plist (new) |   1 +
 multimedia/gstreamer1-plugins-libde265/Makefile    |   6 +-
 .../gstreamer1-plugins-libde265/pkg-plist (new)    |   1 +
 multimedia/gstreamer1-plugins-mpeg2dec/Makefile    |   8 +-
 .../gstreamer1-plugins-mpeg2dec/pkg-plist (new)    |   1 +
 multimedia/gstreamer1-plugins-mpeg2enc/Makefile    |   8 +-
 .../gstreamer1-plugins-mpeg2enc/pkg-plist (new)    |   1 +
 multimedia/gstreamer1-plugins-mplex/Makefile       |   8 +-
 .../gstreamer1-plugins-mplex/pkg-plist (new)       |   1 +
 multimedia/gstreamer1-plugins-msdk/Makefile        |   9 +-
 multimedia/gstreamer1-plugins-msdk/pkg-plist (new) |   1 +
 multimedia/gstreamer1-plugins-openh264/Makefile    |   6 +-
 .../gstreamer1-plugins-openh264/pkg-plist (new)    |   1 +
 multimedia/gstreamer1-plugins-resindvd/Makefile    |  10 +-
 .../gstreamer1-plugins-resindvd/pkg-plist (new)    |   1 +
 multimedia/gstreamer1-plugins-rtmp/Makefile        |   6 +-
 multimedia/gstreamer1-plugins-rtmp/pkg-plist (new) |   1 +
 .../gstreamer1-plugins-smoothstreaming/Makefile    |   9 +-
 .../pkg-plist (new)                                |   1 +
 multimedia/gstreamer1-plugins-theora/Makefile      |   7 +-
 .../gstreamer1-plugins-theora/pkg-plist (new)      |   1 +
 multimedia/gstreamer1-plugins-ttml/Makefile        |   6 +-
 multimedia/gstreamer1-plugins-ttml/pkg-plist (new) |   1 +
 multimedia/gstreamer1-plugins-ugly/Makefile        |  21 +-
 .../files/patch-meson.build (new)                  |  14 +
 .../files/patch-meson_options.txt (new)            |  15 +
 multimedia/gstreamer1-plugins-ugly/pkg-plist       |   1 +
 multimedia/gstreamer1-plugins-v4l2/Makefile        |  10 +-
 multimedia/gstreamer1-plugins-v4l2/pkg-plist (new) |   1 +
 multimedia/gstreamer1-plugins-vpx/Makefile         |   6 +-
 multimedia/gstreamer1-plugins-vpx/pkg-plist (new)  |   2 +
 multimedia/gstreamer1-plugins-x264/Makefile        |   8 +-
 multimedia/gstreamer1-plugins-x264/pkg-plist (new) |   2 +
 multimedia/gstreamer1-plugins-x265/Makefile        |   8 +-
 multimedia/gstreamer1-plugins-x265/pkg-plist (new) |   1 +
 multimedia/gstreamer1-plugins/Makefile             | 144 ++--
 multimedia/gstreamer1-plugins/Makefile.common      | 731 +++++++--------------
 multimedia/gstreamer1-plugins/distinfo             |  18 +-
 .../files/patch-Makefile.in (gone)                 |  11 -
 .../files/patch-configure (gone)                   | 109 ---
 .../files/patch-ext_cdparanoia_meson.build (new)   |  11 +
 .../files/patch-ext_gl_meson.build (new)           |  11 +
 .../files/patch-ext_libvisual_meson.build (new)    |  12 +
 .../files/patch-ext_ogg_meson.build (new)          |  13 +
 .../files/patch-ext_opus_meson.build (new)         |  19 +
 .../files/patch-ext_pango_meson.build (new)        |  13 +
 .../files/patch-ext_theora_meson.build (new)       |  12 +
 .../files/patch-ext_vorbis_meson.build (new)       |  12 +
 ...patch-gst-libs_gst_allocators_meson.build (new) |  12 +
 .../files/patch-gst-libs_gst_app_meson.build (new) |  12 +
 .../patch-gst-libs_gst_audio_meson.build (new)     |  12 +
 .../files/patch-gst-libs_gst_fft_meson.build (new) |  12 +
 .../files/patch-gst-libs_gst_gl_meson.build (new)  |  69 ++
 .../patch-gst-libs_gst_pbutils_meson.build (new)   |  15 +
 .../patch-gst-libs_gst_riff_meson.build (new)      |  12 +
 .../files/patch-gst-libs_gst_rtp_meson.build (new) |  12 +
 .../patch-gst-libs_gst_rtsp_meson.build (new)      |  12 +
 .../files/patch-gst-libs_gst_sdp_meson.build (new) |  12 +
 .../files/patch-gst-libs_gst_tag_meson.build (new) |  12 +
 .../patch-gst-libs_gst_video_meson.build (new)     |  12 +
 .../files/patch-meson.build (new)                  |  39 ++
 .../files/patch-meson__options.txt (new)           |  30 +
 .../files/patch-sys_ximage_meson.build (new)       |  19 +
 .../files/patch-sys_xvimage_meson.build (new)      |  13 +
 multimedia/gstreamer1-plugins/pkg-plist            |  38 +-
 multimedia/gstreamer1-qt/Makefile                  |   2 +-
 ...-elements_gstqtvideosink_gstqtvideosinkplugin.h |   8 +-
 .../files/patch-src_QGst_event.cpp (new)           |  11 +
 .../files/patch-src_QGst_message.cpp (new)         |  11 +
 multimedia/gstreamer1-rtsp-server/Makefile         |  12 +-
 multimedia/gstreamer1-rtsp-server/distinfo         |   6 +-
 multimedia/gstreamer1-transcoder/Makefile (gone)   |  38 --
 multimedia/gstreamer1-transcoder/distinfo (gone)   |   3 -
 multimedia/gstreamer1-transcoder/pkg-descr (gone)  |   3 -
 multimedia/gstreamer1-transcoder/pkg-plist (gone)  |  34 -
 multimedia/gstreamer1-vaapi/Makefile               |  23 +-
 multimedia/gstreamer1-vaapi/distinfo               |   6 +-
 multimedia/gstreamer1-vaapi/pkg-plist              |  35 -
 multimedia/gstreamer1-validate/Makefile            |  15 +-
 multimedia/gstreamer1-validate/distinfo            |   6 +-
 multimedia/gstreamer1/Makefile                     |  36 +-
 multimedia/gstreamer1/distinfo                     |   6 +-
 .../gstreamer1/files/patch-Makefile.in (gone)      |  11 -
 .../patch-libs_gst_controller_Makefile.in (gone)   |  11 -
 multimedia/gstreamer1/pkg-plist                    | 112 ++--
 multimedia/pitivi/Makefile                         |  16 +-
 multimedia/pitivi/distinfo                         |   6 +-
 multimedia/pitivi/pkg-plist                        | 264 +++++---
 net/gstreamer1-plugins-srtp/Makefile               |   6 +-
 net/gstreamer1-plugins-srtp/pkg-plist (new)        |   1 +
 security/gstreamer1-plugins-dtls/Makefile          |   6 +-
 security/gstreamer1-plugins-dtls/pkg-plist (new)   |   1 +
 sysutils/gstreamer1-plugins-cdio/Makefile          |   8 +-
 sysutils/gstreamer1-plugins-cdio/pkg-plist (new)   |   1 +
 www/gstreamer1-plugins-neon/Makefile               |   6 +-
 www/gstreamer1-plugins-neon/pkg-plist (new)        |   1 +
 x11-toolkits/gstreamer1-plugins-gtk/Makefile       |   8 +-
 .../gstreamer1-plugins-gtk/pkg-plist (new)         |   1 +
 x11-toolkits/gstreamer1-plugins-pango/Makefile     |   8 +-
 .../gstreamer1-plugins-pango/pkg-plist (new)       |   1 +
 x11/gstreamer1-plugins-x/Makefile                  |  11 +-
 x11/gstreamer1-plugins-x/pkg-plist (new)           |   3 +
 x11/gstreamer1-plugins-ximagesrc/Makefile          |  14 +-
 x11/gstreamer1-plugins-ximagesrc/pkg-plist (new)   |   1 +
 282 files changed, 2533 insertions(+), 1815 deletions(-)
Comment 29 Thomas Zander freebsd_committer freebsd_triage 2022-10-15 10:54:33 UTC
This is probably too invasive for MFH to quarterly. Let's iron out the rough edges we don't know about yet on main, so we have it nice and stable for the Q1 branch.
Comment 30 Thomas Zander freebsd_committer freebsd_triage 2022-10-15 10:55:03 UTC
Just in time for the 1.20.4 update that just came a few days ago :-)
Comment 31 Vladimir Druzenko freebsd_committer freebsd_triage 2022-10-15 13:38:08 UTC
> gst-libs/gst/gl/meson.build:558:6: ERROR: Unknown variable "allocators_dep".
in graphics/gstreamer1-plugins-gl:

===>  Configuring for gstreamer1-plugins-gl-1.20.3
The Meson build system
Version: 0.63.2
Source dir: /tmp/work/usr/ports/graphics/gstreamer1-plugins-gl/work/gst-plugins-base-1.20.3
Build dir: /tmp/work/usr/ports/graphics/gstreamer1-plugins-gl/work/gst-plugins-base-1.20.3/_build
Build type: native build
DEPRECATION: Option app already exists.
Project name: gst-plugins-base
Project version: 1.20.3
C compiler for the host machine: cc (clang 13.0.0 "FreeBSD clang version 13.0.0 (git@github.com:llvm/llvm-project.git llvmorg-13.0.0-0-gd7b669b3a303)")
C linker for the host machine: cc ld.lld 13.0.0
Host machine cpu family: x86_64
Host machine cpu: x86_64
C++ compiler for the host machine: c++ (clang 13.0.0 "FreeBSD clang version 13.0.0 (git@github.com:llvm/llvm-project.git llvmorg-13.0.0-0-gd7b669b3a303)")
C++ linker for the host machine: c++ ld.lld 13.0.0
Compiler for C supports link arguments -Wl,-Bsymbolic-functions: YES 
Compiler for C supports arguments -fvisibility=hidden: YES 
Compiler for C supports arguments -fno-strict-aliasing: YES 
Message: Disabling GLib cast checks
Has header "dlfcn.h" : YES 
Has header "emmintrin.h" : YES 
Has header "inttypes.h" : YES 
Has header "memory.h" : YES 
Has header "netinet/in.h" : YES 
Has header "netinet/tcp.h" : YES 
Has header "process.h" : NO 
Has header "smmintrin.h" : YES 
Has header "stdint.h" : YES 
Has header "strings.h" : YES 
Has header "string.h" : YES 
Has header "sys/socket.h" : YES 
Has header "sys/stat.h" : YES 
Has header "sys/types.h" : YES 
Has header "sys/wait.h" : YES 
Has header "unistd.h" : YES 
Has header "winsock2.h" : NO 
Has header "xmmintrin.h" : YES 
Has header "linux/dma-buf.h" : NO 
Library m found: YES
Checking for function "dcgettext" with dependency -lm: NO 
Checking for function "gmtime_r" with dependency -lm: YES 
Checking for function "localtime_r" with dependency -lm: YES 
Checking for function "lrintf" with dependency -lm: YES 
Checking for function "mmap" with dependency -lm: YES 
Checking for function "log2" with dependency -lm: YES 
Checking for size of "char" : 1
Checking for size of "int" : 4
Checking for size of "long" : 8
Checking for size of "short" : 2
Checking for size of "void*" : 8
Compiler for C++ supports arguments -Waggregate-return: YES 
Compiler for C supports arguments -Wmissing-declarations: YES 
Compiler for C++ supports arguments -Wmissing-declarations: YES 
Compiler for C supports arguments -Wredundant-decls: YES 
Compiler for C++ supports arguments -Wredundant-decls: YES 
Compiler for C supports arguments -Wundef: YES 
Compiler for C++ supports arguments -Wundef: YES 
Compiler for C supports arguments -Wwrite-strings: YES 
Compiler for C++ supports arguments -Wwrite-strings: YES 
Compiler for C supports arguments -Wformat: YES 
Compiler for C++ supports arguments -Wformat: YES 
Compiler for C supports arguments -Wformat-nonliteral: YES 
Compiler for C++ supports arguments -Wformat-nonliteral: YES 
Compiler for C supports arguments -Wformat-security: YES 
Compiler for C++ supports arguments -Wformat-security: YES 
Compiler for C supports arguments -Winit-self: YES 
Compiler for C++ supports arguments -Winit-self: YES 
Compiler for C supports arguments -Wmissing-include-dirs: YES 
Compiler for C++ supports arguments -Wmissing-include-dirs: YES 
Compiler for C supports arguments -Waddress: YES 
Compiler for C++ supports arguments -Waddress: YES 
Compiler for C supports arguments -Wno-multichar: YES 
Compiler for C++ supports arguments -Wno-multichar: YES 
Compiler for C supports arguments -Wvla: YES 
Compiler for C++ supports arguments -Wvla: YES 
Compiler for C supports arguments -Wpointer-arith: YES 
Compiler for C++ supports arguments -Wpointer-arith: YES 
Compiler for C supports arguments -Wmissing-prototypes: YES 
Compiler for C supports arguments -Wdeclaration-after-statement: YES 
Found pkg-config: /usr/local/bin/pkgconf (1.8.0)
Run-time dependency x11 found: YES 1.7.2
Run-time dependency glib-2.0 found: YES 2.74.0
Run-time dependency gobject-2.0 found: YES 2.74.0
Run-time dependency gio-2.0 found: YES 2.74.0
Run-time dependency gio-unix-2.0 found: YES 2.74.0
Run-time dependency gmodule-no-export-2.0 found: YES 2.74.0
Dependency gdk-pixbuf-2.0 skipped: feature examples disabled
Dependency gtk+-3.0 skipped: feature examples disabled
Dependency gtk+-x11-3.0 skipped: feature examples disabled
Run-time dependency gstreamer-1.0 found: YES 1.20.3
Run-time dependency gstreamer-base-1.0 found: YES 1.20.3
Run-time dependency gstreamer-net-1.0 found: YES 1.20.3
Dependency gstreamer-check-1.0 skipped: feature tests disabled
Run-time dependency gstreamer-controller-1.0 found: YES 1.20.3
Run-time dependency orc-0.4 found: YES 0.4.32
Program orcc found: YES (/usr/local/bin/orcc)
Compiler for C supports arguments -msse: YES 
Compiler for C supports arguments -msse2: YES 
Compiler for C supports arguments -msse4.1: YES 
Message: GStreamer debug system is enabled
Checking whether type "struct tcp_info" has member "__tcpi_reordering" : YES 
Checking whether type "struct tcp_info" has member "tcpi_reordering" : NO 
Program g-ir-scanner found: YES (/usr/local/bin/g-ir-scanner)
Program scripts/meson-pkg-config-file-fixup.py found: YES (/tmp/work/usr/ports/graphics/gstreamer1-plugins-gl/work/gst-plugins-base-1.20.3/scripts/meson-pkg-config-file-fixup.py)
Program python3 found: YES (/usr/local/bin/python3.10)
Looking for a fallback subproject for the dependency (anonymous)
Cloning into 'gl-headers'...
remote: Enumerating objects: 38, done.
remote: Total 38 (delta 0), reused 0 (delta 0), pack-reused 38
Receiving objects: 100% (38/38), 121.93 KiB | 348.00 KiB/s, done.
Resolving deltas: 100% (11/11), done.
Already on 'master'
Your branch is up to date with 'origin/master'.

Executing subproject gl-headers 

gl-headers| Project name: gl-headers
gl-headers| Project version: 2019.1.0
gl-headers| C compiler for the host machine: cc (clang 13.0.0 "FreeBSD clang version 13.0.0 (git@github.com:llvm/llvm-project.git llvmorg-13.0.0-0-gd7b669b3a303)")
gl-headers| C linker for the host machine: cc ld.lld 13.0.0
gl-headers| Program python3 found: YES (/usr/local/bin/python3.10)
gl-headers| Has header "KHR/khrplatform.h" : YES
gl-headers| Has header "GL/wglext.h" : NO
gl-headers| Has header "GL/glext.h" : YES
gl-headers| Build targets in project: 0
gl-headers| Subproject gl-headers finished.

Dependency (anonymous) from subproject subprojects/gl-headers found: YES 2019.1.0
Run-time dependency opengl found: YES 4.5
Run-time dependency glx found: YES 1.4
Run-time dependency glesv2 found: YES 3.2
Has header "GLES3/gl3.h" with dependency glesv2: YES 
Has header "GLES3/gl3ext.h" with dependency glesv2: YES 
Run-time dependency egl found: YES 1.5
Has header "EGL/egl.h" with dependency egl: YES 
Has header "EGL/eglext.h" with dependency egl: YES 
Has header "libdrm/drm_fourcc.h" : YES 

gst-libs/gst/gl/meson.build:558:6: ERROR: Unknown variable "allocators_dep".

A full log can be found at /tmp/work/usr/ports/graphics/gstreamer1-plugins-gl/work/gst-plugins-base-1.20.3/_build/meson-logs/meson-log.txt
===>  Script "configure" failed unexpectedly.
Please report the problem to multimedia@FreeBSD.org [maintainer] and attach
the
"/tmp/work/usr/ports/graphics/gstreamer1-plugins-gl/work/gst-plugins-base-1.20.3/_build/meson-logs/meson-log.txt"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1
Comment 32 Vladimir Druzenko freebsd_committer freebsd_triage 2022-10-15 13:44:45 UTC
multimedia/gstreamer1-plugins-dts:
sys/v4l2codecs/meson.build:38:2: ERROR: Unknown variable "gstcodecs_dep".

multimedia/gstreamer1-plugins-resindvd:
sys/v4l2codecs/meson.build:38:2: ERROR: Unknown variable "gstcodecs_dep".
Comment 33 Dima Panov freebsd_committer freebsd_triage 2022-10-15 14:59:44 UTC
Same error for:

gstreamer1-libav
gstreamer1-plugins-chromaprint
gstreamer1-plugins-mpeg2enc
gstreamer1-plugins-mplex
gstreamer1-plugins-opencv
gstreamer1-plugins-x265
gstreamer1-plugins-zbar
Comment 34 Vladimir Druzenko freebsd_committer freebsd_triage 2022-10-15 15:26:39 UTC
(In reply to Dima Panov from comment #33)
gstreamer1-libav build fine for me.
Comment 35 Tomoaki AOKI 2022-10-15 16:00:09 UTC
For me, all gstreamer1* fail if previous versions are installed.
After deinstalling the previous versions, installing by portupgrade,

Failed:
 audio/gstreamer1-plugins-chromaprint
 multimedia/gstreamer1-plugins-resindvd
 multimedia/gstreamer1-plugins-core

Skipped due to build faulure above:
 gstreamer1-plugins-faac
 gstreamer1-plugins-faad
 gstreamer1-plugins-gl
 gstreamer1-plugins-dts
 gstreamer1-plugins-rtmp

Succeeded:
 multimedia/gstreamer1
 multimedia/gstreamer1-libav
 multimedia/gstreamer1-plugins
 audio/gstreamer1-plugins-a52dec
 multimedia/gstreamer1-plugins-bad
 audio/gstreamer1-plugins-cdparanoia
 multimedia/gstreamer1-plugins-dvdread
 audio/gstreamer1-plugins-flac
 multimedia/gstreamer1-plugins-good
 audio/gstreamer1-plugins-lame
 audio/gstreamer1-plugins-mpg123
 audio/gstreamer1-plugins-ogg
 x11-toolkits/gstreamer1-plugins-pango
 graphics/gstreamer1-plugins-png
 devel/gstreamer1-plugins-soup
 multimedia/gstreamer1-plugins-theora
 multimedia/gstreamer1-plugins-ugly
 audio/gstreamer1-plugins-vorbis
 audio/gstreamer1-plugins-wavpack
 x11/gstreamer1-plugins-x
 multimedia/gstreamer1-qt
Comment 36 Thomas Zander freebsd_committer freebsd_triage 2022-10-15 16:27:54 UTC
Pretty sure it will be next to impossible to upgrade something like this via ports when older versions of the packages are installed.

That's why we have tools that give us clean, proper build environments (i.e. poudriere). portmaster, portupgrade etc. simply do not work. Please make use of them.

We can add an entry to UPDATING if it helps, but implementing the build logic to make this work is unrealistic.
Comment 37 Dima Panov freebsd_committer freebsd_triage 2022-10-15 16:35:04 UTC
(In reply to Thomas Zander from comment #36)

Thomas, my list of failed components from poudriere, sure. 
https://build.dimapanov.com/build.html?mastername=131amd64-dimaports&build=2022-10-15_19h09m02s
Comment 38 Thomas Zander freebsd_committer freebsd_triage 2022-10-15 21:38:41 UTC
(In reply to Dima Panov from comment #37)

There are quite a few customisations in your build. Could you try a more default make.conf and help isolate the reason for the failure?
Comment 39 Tomoaki AOKI 2022-10-16 00:45:43 UTC
(In reply to Thomas Zander from comment #36)

At least,
  1. record which gstreamer1* ports are installed,
  2. deinstall *ALL* gstreamer1* ports,
  3. install all recorded gstreamer1* ports again

should always work, if no new CONFLICTS is introduced.
It *IS* mostly a clean build.
And if step2 is required, UPDATING entry is needed.

BTW, can I use existing /usr/ports as ports tree for poudriere?
I'm very, very, very confused whether it's possible or not reading poudriere-ports man page [1] and "How to... ...use the system ports tree in poudriere" poudriere web site [2].


[1] https://github.com/freebsd/poudriere/wiki/poudriere-ports.8

[2] https://github.com/freebsd/poudriere/wiki/use_system_ports_tree
Comment 40 Vladimir Druzenko freebsd_committer freebsd_triage 2022-10-16 04:56:07 UTC
After remove multimedia/v4l_compat both multimedia/gstreamer1-plugins-dts and multimedia/gstreamer1-plugins-resindvd:
during configure line
> Has header "linux/videodev2.h" : YES
changed to
> Has header "linux/videodev2.h" : NO

But got other error below:
> Run-time dependency svthevcenc found: YES 1.5.1
> 
> ext/svthevcenc/meson.build:8:2: ERROR: Unknown variable "gstcodecparsers_dep".

After remove multimedia/svt-hevc both build without errors.
Comment 41 Barbara Guida freebsd_committer freebsd_triage 2022-10-16 09:16:05 UTC
(In reply to VVD from comment #40)
Similarly, the failure for graphics/gstreamer1-plugins-gl is caused by the presence of graphics/libdrm.
Comment 42 Barbara Guida freebsd_committer freebsd_triage 2022-10-16 09:19:27 UTC
(In reply to Barbara Guida from comment #41)
Sorry, I didn't noticed that it was the summary for bug 267100...
Comment 43 Dima Panov freebsd_committer freebsd_triage 2022-10-16 14:56:55 UTC
Thomas, JFYI: for multimedia/gstreamer1-libav FFMpeg is now non-optional

Most other failed package was from founded but not requested svt-hevc comes from dependencies. need to be forced to disable in all non-hevc ext.
Comment 44 Dima Panov freebsd_committer freebsd_triage 2022-10-16 15:17:48 UTC
(In reply to Dima Panov from comment #43)
One more note -- svt-hevc comes via option from x265
Comment 45 Thomas Zander freebsd_committer freebsd_triage 2022-10-17 08:00:28 UTC
(In reply to Tomoaki AOKI from comment #39)

You can use whichever ports tree you like.
For example, create an empty ports tree that is known to poudriere (so it will use it) but isn't populated by it:

poudriere ports -c -F

will create an empty /poudriere/ports/default which you will see in the output of `poudriere ports -l`.

Personally, I find it easiest to not have anything /usr/ports at all, instead I just `ln -s /poudriere/ports/default /usr/ports`