Bug 261636 - security/wpa_supplicant: EAPOL_TEST option broken
Summary: security/wpa_supplicant: EAPOL_TEST option broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-31 20:19 UTC by David Siebörger
Modified: 2022-02-02 23:41 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (cy)


Attachments
poudriere build log (40.34 KB, text/plain)
2022-01-31 20:19 UTC, David Siebörger
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Siebörger 2022-01-31 20:19:30 UTC
Created attachment 231475 [details]
poudriere build log

Enabling the EAPOL_TEST option with the 2.10 port breaks the build, as shown in the attached poudriere build log.

Simply removing files/patch-src_utils_os.h does allow the build to complete, though I haven't tested the resulting binaries.


cc -c -o /wrkdirs/usr/ports/security/wpa_supplicant/work/wpa_supplicant-2.10/build/wpa_supplicant/config_file.o -O2 -pipe  -I/usr/local/include -I/usr/include -fstack-protector-strong -fno-strict-aliasing   -I/wrkdirs/usr/ports/security/wpa_supplicant/work/wpa_supplicant-2.10/src -I/wrkdirs/usr/ports/security/wpa_supplicant/work/wpa_supplicant-2.10/src/utils -Werror -DEAPOL_TEST -DCONFIG_BACKEND_FILE -DCONFIG_IEEE80211R -DCONFIG_MATCH_IFACE -DCONFIG_HS20 -DCONFIG_INTERWORKING -DCONFIG_DRIVER_WIRED -DCONFIG_DRIVER_BSD -DEAP_TLS -DEAP_PEAP -DEAP_TTLS -DEAP_MD5 -DEAP_MSCHAPv2 -DEAP_GTC -DEAP_OTP -DEAP_LEAP -DEAP_PSK -DEAP_FAST -DEAP_PAX -DEAP_SAKE -DEAP_GPSK -DEAP_GPSK_SHA256 -DEAP_PWD -DEAP_EKE -DCONFIG_WPS -DEAP_WSC -DCONFIG_WPS_NFC -DCONFIG_WPS_OOB -DCONFIG_WPS_ER -DCONFIG_WPS_UPNP -DEAP_IKEV2 -DEAP_TNC -DIEEE8021X_EAPOL -DPKCS12_FUNCS -DCONFIG_SMARTCARD -DEAP_TLS_OPENSSL -DTLS_DEFAULT_CIPHERS=\""DEFAULT:!EXP:!LOW"\" -DCONFIG_DES -DCONFIG_SHA256 -DALL_DH_GROUPS -DCONFIG_ECC -DCONFIG_CTRL_IFACE -DCONFIG_CTRL_IFACE_UNIX -DCONFIG_CTRL_IFACE_DBUS_NEW -DCONFIG_CTRL_IFACE_DBUS_INTRO -I/usr/local/include/dbus-1.0 -I/usr/local/lib/dbus-1.0/include  -DCONFIG_DEBUG_SYSLOG -DCONFIG_GAS -DCONFIG_OFFCHANNEL config_file.c
config_file.c:1633:2: error: implicit declaration of function 'os_fdatasync' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        os_fdatasync(f);
        ^
config_file.c:1633:2: note: did you mean 'fdatasync'?
/usr/include/unistd.h:389:6: note: 'fdatasync' declared here
int      fdatasync(int);
         ^
1 error generated.
gmake[1]: *** [../src/build.rules:89: /wrkdirs/usr/ports/security/wpa_supplicant/work/wpa_supplicant-2.10/build/wpa_supplicant/config_file.o] Error 1
gmake[1]: Leaving directory '/wrkdirs/usr/ports/security/wpa_supplicant/work/wpa_supplicant-2.10/wpa_supplicant'
*** Error code 1

Stop.
make: stopped in /usr/ports/security/wpa_supplicant
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-01-31 21:45:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=74e181d200eeb192160951934cd3b16014682d8c

commit 74e181d200eeb192160951934cd3b16014682d8c
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-01-31 21:40:40 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-01-31 21:44:16 +0000

    */*: Fix wpa_supplicant* and hostapd* EAPOL_TEST build

    Fix EAPOL_TEST build. Local funcion os_fdatasync() is valid under
    FreeBSD as fdatasync(2) is supported.

    PR:             261636
    Reported by:    David Siebörger <drs-freebsd@sieborger.nom.za>
    MFH:            2022Q1

 net/hostapd-devel/files/patch-src_utils_os.h (gone)     | 17 -----------------
 net/hostapd/files/patch-src_utils_os.h (gone)           | 17 -----------------
 .../files/patch-src_utils_os.h (gone)                   | 17 -----------------
 .../wpa_supplicant/files/patch-src_utils_os.h (gone)    | 17 -----------------
 4 files changed, 68 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-01-31 21:52:42 UTC
A commit in branch 2022Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f7c8e7325361cd963746fa89352061e17d51ba6f

commit f7c8e7325361cd963746fa89352061e17d51ba6f
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-01-31 21:40:40 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-01-31 21:51:39 +0000

    */*: Fix wpa_supplicant* and hostapd* EAPOL_TEST build

    Fix EAPOL_TEST build. Local funcion os_fdatasync() is valid under
    FreeBSD as fdatasync(2) is supported.

    PR:             261636
    Reported by:    David Siebörger <drs-freebsd@sieborger.nom.za>

    (cherry picked from commit 74e181d200eeb192160951934cd3b16014682d8c)

 net/hostapd-devel/files/patch-src_utils_os.h (gone)     | 17 -----------------
 net/hostapd/files/patch-src_utils_os.h (gone)           | 17 -----------------
 .../files/patch-src_utils_os.h (gone)                   | 17 -----------------
 3 files changed, 51 deletions(-)