Created attachment 231570 [details] Patch for tcprelay Switch to release archive as per recommendation in Porters Handbook (USE_GITHUB section) Fix "make test" , it now runs but there are still tests that generates errors Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make test, make check-plist)
Friendly ping
LGTM. Please commit. Could you also bump the PORTREVISION per recommendation in Porters Handbook (5.2.3.1. PORTREVISION section).
Thanks, no need to bump PORTREVISION as package doesn't change?
You're fetching a different distfile with a pre-generated configure script and pass different configure options. After compiling the port the resulting binary is going to be ever so slightly different than the current one. This warrants a PORTREVISION bump.
4.4.1 was just released: https://github.com/appneta/tcpreplay/compare/v4.4.0...v4.4.1 I'll handle the update.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=30d37dceedd9b3a75e25a45a8ae584925dcc222a commit 30d37dceedd9b3a75e25a45a8ae584925dcc222a Author: Emanuel Haupt <ehaupt@FreeBSD.org> AuthorDate: 2022-02-12 21:01:59 +0000 Commit: Emanuel Haupt <ehaupt@FreeBSD.org> CommitDate: 2022-02-12 21:02:13 +0000 net-mgmt/tcpreplay: Update to 4.4.1 - Update to 4.4.1 - Use upstream release archive - Partially fix "make test" PR: 261738 net-mgmt/tcpreplay/Makefile | 17 +++++++---------- net-mgmt/tcpreplay/distinfo | 6 +++--- net-mgmt/tcpreplay/files/patch-Makefile.in (new) | 11 +++++++++++ 3 files changed, 21 insertions(+), 13 deletions(-)
I just investigated the test failures. They do fail in a jail: NOTICE: Tests must be run as root Sending traffic on 'em0' and 'em0' [tcpprep] Auto/Router mode test: OK [tcpprep] Auto/Bridge mode test: OK [tcpprep] Auto/Client mode test: OK [tcpprep] Auto/Server mode test: OK [tcpprep] Auto/First mode test: OK [tcpprep] CIDR mode test: OK [tcpprep] Regex mode test: OK [tcpprep] Port mode test: OK [tcpprep] MAC mode test: OK [tcpprep] Comment mode test: OK [tcpprep] Print info mode test: OK [tcpprep] Print comment mode test: OK [tcpprep] Config mode test: OK [tcpprep] MAC reverse mode test: OK [tcpprep] CIDR reverse mode test: OK [tcpprep] Regex reverse mode test: OK [tcpprep] exclude packets test: OK [tcpprep] include packets test: OK [tcpprep] include source test: OK [tcpprep] include destination test: OK [tcpreplay] Basic test: gmake[2]: *** [Makefile:818: replay_basic] Error 255 [tcpreplay] Cache test: gmake[2]: *** [Makefile:824: replay_cache] Error 255 [tcpreplay] Packets/sec test: gmake[2]: *** [Makefile:1099: replay_pps] Error 255 [tcpreplay] Mbps test: gmake[2]: *** [Makefile:1105: replay_rate] Error 255 [tcpreplay] Topspeed test: gmake[2]: *** [Makefile:1123: replay_top] Error 255 [tcpreplay] Config file/VLAN add test: gmake[2]: *** [Makefile:1141: replay_config] Error 255 [tcpreplay] Multiplier test: gmake[2]: *** [Makefile:1111: replay_multi] Error 255 [tcpreplay] Packets/sec Multiplier test: gmake[2]: *** [Makefile:1117: replay_pps_multi] Error 255 [tcpreplay] Precache test: gmake[2]: *** [Makefile:1129: replay_precache] Error 255 [tcpreplay] Statistics test: gmake[2]: *** [Makefile:836: replay_stats] Error 255 [tcpreplay] Dual file test: gmake[2]: *** [Makefile:1147: replay_dualfile] Error 255 [tcpreplay] Maximum sleep test: gmake[2]: *** [Makefile:1153: replay_maxsleep] Error 255 [tcprewrite] Portmap test: OK [tcprewrite] Portmap range test: OK [tcprewrite] Endpoint test: OK [tcprewrite] Pseudo NAT test: OK [tcprewrite] Truncate test: OK [tcprewrite] Pad test: OK [tcprewrite] Seed IP test: OK [tcprewrite] Src/Dst MAC test: OK [tcprewrite] Layer2 test: OK [tcprewrite] Config/VLAN Add test: OK [tcprewrite] Skip bcast test: OK [tcprewrite] DLT User test: OK [tcprewrite] DLT Cisco HDLC test: OK [tcprewrite] VLAN 802.1ad test: OK [tcprewrite] VLAN Delete test: OK [tcprewrite] Remove EFCS: OK [tcprewrite] Force TTL: OK [tcprewrite] Increase TTL: OK [tcprewrite] Reduce TTL: OK [tcprewrite] TOS test: OK [tcprewrite] MTU Truncate test: OK [tcprewrite] Substitute Src/Dst MAC test: OK [tcprewrite] Seeded MAC test: OK [tcprewrite] Seeded Keep MAC test: OK [tcprewrite] L7 fuzzing test: OK [tcprewrite] TCP sequence test: OK [tcprewrite] Fix checksum test: OK [tcprewrite] Fix length and pad test: OK [tcprewrite] Fix length and truncate test: OK [tcprewrite] Fix length and delete test: OK But they will succeed outside of a jail: NOTICE: Tests must be run as root Sending traffic on 'em0' and 'em0' [tcpprep] Auto/Router mode test: OK [tcpprep] Auto/Bridge mode test: OK [tcpprep] Auto/Client mode test: OK [tcpprep] Auto/Server mode test: OK [tcpprep] Auto/First mode test: OK [tcpprep] CIDR mode test: OK [tcpprep] Regex mode test: OK [tcpprep] Port mode test: OK [tcpprep] MAC mode test: OK [tcpprep] Comment mode test: OK [tcpprep] Print info mode test: OK [tcpprep] Print comment mode test: OK [tcpprep] Config mode test: OK [tcpprep] MAC reverse mode test: OK [tcpprep] CIDR reverse mode test: OK [tcpprep] Regex reverse mode test: OK [tcpprep] exclude packets test: OK [tcpprep] include packets test: OK [tcpprep] include source test: OK [tcpprep] include destination test: OK [tcpreplay] Basic test: OK [tcpreplay] Cache test: OK [tcpreplay] Packets/sec test: OK [tcpreplay] Mbps test: OK [tcpreplay] Topspeed test: OK [tcpreplay] Config file/VLAN add test: OK [tcpreplay] Multiplier test: OK [tcpreplay] Packets/sec Multiplier test: OK [tcpreplay] Precache test: OK [tcpreplay] Statistics test: OK [tcpreplay] Dual file test: OK [tcpreplay] Maximum sleep test: OK [tcprewrite] Portmap test: OK [tcprewrite] Portmap range test: OK [tcprewrite] Endpoint test: OK [tcprewrite] Pseudo NAT test: OK [tcprewrite] Truncate test: OK [tcprewrite] Pad test: OK [tcprewrite] Seed IP test: OK [tcprewrite] Src/Dst MAC test: OK [tcprewrite] Layer2 test: OK [tcprewrite] Config/VLAN Add test: OK [tcprewrite] Skip bcast test: OK [tcprewrite] DLT User test: OK [tcprewrite] DLT Cisco HDLC test: OK [tcprewrite] VLAN 802.1ad test: OK [tcprewrite] VLAN Delete test: OK [tcprewrite] Remove EFCS: OK [tcprewrite] Force TTL: OK [tcprewrite] Increase TTL: OK [tcprewrite] Reduce TTL: OK [tcprewrite] TOS test: OK [tcprewrite] MTU Truncate test: OK [tcprewrite] Substitute Src/Dst MAC test: OK [tcprewrite] Seeded MAC test: OK [tcprewrite] Seeded Keep MAC test: OK [tcprewrite] L7 fuzzing test: OK [tcprewrite] TCP sequence test: OK [tcprewrite] Fix checksum test: OK [tcprewrite] Fix length and pad test: OK [tcprewrite] Fix length and truncate test: OK [tcprewrite] Fix length and delete test: OK Nice :-)
Committed, incorporated with the update, thanks!
Thanks! =)