Bug 261741 - biology/pooler: update to 1.82
Summary: biology/pooler: update to 1.82
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: http://ssb22.user.srcf.net/pooler/#ch...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-06 08:36 UTC by Silas S. Brown
Modified: 2022-02-10 14:26 UTC (History)
2 users (show)

See Also:


Attachments
Patch for v1.79 PLEASE DO NOT USE (1.20 KB, text/plain)
2022-02-06 08:36 UTC, Silas S. Brown
no flags Details
Patch for v1.8 (1.20 KB, patch)
2022-02-07 22:57 UTC, Silas S. Brown
no flags Details | Diff
Patch for v1.81 (1.19 KB, patch)
2022-02-08 12:34 UTC, Silas S. Brown
no flags Details | Diff
Patch for v1.82 (645 bytes, patch)
2022-02-09 08:10 UTC, Silas S. Brown
no flags Details | Diff
Patch for v1.82 - with distinfo (1.22 KB, patch)
2022-02-09 08:15 UTC, Silas S. Brown
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Silas S. Brown 2022-02-06 08:36:06 UTC
Created attachment 231576 [details]
Patch for v1.79 PLEASE DO NOT USE

This update fixes the man page, which previously had the wrong unit (at one point it incorrectly said concentrations should be specified in nanomoles instead of millimoles).  Thanks to Zhifu Wang in Beijing for catching this.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2022-02-06 08:36:06 UTC
Maintainer informed via mail
Comment 2 Silas S. Brown 2022-02-07 12:48:38 UTC
Please "hold fire" with this one: it turns out there is ANOTHER units-related correction in the man page that needs doing.  I'll put out a "version 1.8" soon with that
Comment 3 Silas S. Brown 2022-02-07 22:57:36 UTC
Created attachment 231622 [details]
Patch for v1.8
Comment 4 Silas S. Brown 2022-02-07 23:00:10 UTC
Comment on attachment 231622 [details]
Patch for v1.8

OK, please use this patch for 1.8 now, thanks
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-02-08 07:10:27 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

Q/A: Patch did not apply cleanly.

The context fails because the version in the repo has PORTREVISION but in the patch there is no such line and it is not removed either. Also the patch contains CR/LF characters at the end.

Would you have a look at it?

Thanks!
Comment 6 Silas S. Brown 2022-02-08 12:27:08 UTC
Sorry my diff was against the 2021Q4 branch (which is what I had in my /usr/ports), I didn't realise the main branch had changed since then.  (I thought "auto-update-system" was keeping my /usr/ports current, but seems not.)  I'll do another patch.

Currently there is no dedicated Changelog file, I've just been mentioning the changes in a section of the documentation.  But I could split them off into a Changelog if that makes more sense.
Comment 7 Silas S. Brown 2022-02-08 12:34:52 UTC
Created attachment 231641 [details]
Patch for v1.81

Please use this patch instead, thanks
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2022-02-08 12:47:14 UTC
Are you the maintainer ssb22@cam.ac.uk?
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2022-02-08 12:53:36 UTC
===>  Building for pooler-1.81_1
make[1]: "/wrkdirs/usr/ports/biology/pooler/work/PrimerPooler-1.81/pooler/Makefile" line 35: Need an operator
make[1]: "/wrkdirs/usr/ports/biology/pooler/work/PrimerPooler-1.81/pooler/Makefile" line 43: Need an operator
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in /wrkdirs/usr/ports/biology/pooler/work/PrimerPooler-1.81/pooler
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Also PORTREVISION should be removed since we are bumping DISTVERSION.

^Triage: Please confirm this change passes QA (portlint, poudriere at least)

For details and instructions, see:

https://docs.freebsd.org/en/books/porters-handbook/#testing
Comment 10 Jason W. Bacon freebsd_committer freebsd_triage 2022-02-08 13:24:13 UTC
(In reply to Silas S. Brown from comment #6)

auto-update-system won't switch your ports from quarterly to current.  It will install updates to quarterly and switch to a new quarter based on the time stamp of, e.g., http://pkg.freebsd.org/FreeBSD:13:amd64/quarterly/meta.txt.

If you want to switch to current, run auto-pkg-latest.
Comment 11 Silas S. Brown 2022-02-09 08:10:21 UTC
Created attachment 231665 [details]
Patch for v1.82

ok, THIS patch should work, sorry about that!
Comment 12 Silas S. Brown 2022-02-09 08:15:52 UTC
Created attachment 231666 [details]
Patch for v1.82 - with distinfo
Comment 13 commit-hook freebsd_committer freebsd_triage 2022-02-10 14:25:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8d34513c3f7ac851134d8452109c28497f0442cb

commit 8d34513c3f7ac851134d8452109c28497f0442cb
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-02-10 12:53:06 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-02-10 14:23:48 +0000

    biology/pooler: update to 1.82

    ChangeLog: http://ssb22.user.srcf.net/pooler/#changes

    PR:     261741
    Reported by:    silas-freebsd@flatline.org.uk

 biology/pooler/Makefile | 7 +++----
 biology/pooler/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 7 deletions(-)
Comment 14 Fernando Apesteguía freebsd_committer freebsd_triage 2022-02-10 14:25:57 UTC
Committed,

Thanks!