Created attachment 231849 [details] net-mgmt/netdata: Update to v1.33.1 As with other updates, source code for the dashboard patch can be found on https://github.com/forkbomb9/dashboard/tree/freebsd A change I wanted feedback on (haven't done it yet) is whether netdata-claim.sh should be only installed with CLOUD=on, as it's only related to the cloud functionality and might be broken with CLOUD=off.
Committed!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f15b83bfe6170aed4eab052f30573e7a6b49d545 commit f15b83bfe6170aed4eab052f30573e7a6b49d545 Author: Namkhai B <namkhai.n3@protonmail.com> AuthorDate: 2022-02-16 01:19:20 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2022-02-16 02:27:11 +0000 net-mgmt/netdata: Update to v1.33.1 PR: 261979 net-mgmt/netdata/Makefile | 6 +-- net-mgmt/netdata/distinfo | 10 ++--- net-mgmt/netdata/pkg-plist | 104 ++++++++++++++++++++++----------------------- 3 files changed, 60 insertions(+), 60 deletions(-)
Woha, that was fast! What do you think about removing netdata-claim.sh with CLOUD=off?
It's a good idea IMO.
What would be the best way to do it? Remove it when CLOUD=off or list it in pkg-plist as %%CLOUD%%? Or both?
Do both.
Created attachment 231879 [details] net-mgmt/netdata: Remove claim script when CLOUD=off How's this looking?
Created attachment 231936 [details] net-mgmt/netdata: Depend on protobuf when CLOUD=on Netdata started rolling out their new ACLK and cloud nodes not supporting protobuf will stop reporting after March 1st. Building with Protobuf is enough to enable support for it. Depends on it only when cloud is enabled, as it's useless without cloud support.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=322d74cac2358470a0ba1aa5e93f2e54971397c9 commit 322d74cac2358470a0ba1aa5e93f2e54971397c9 Author: Namkhai B <namkhai.n3@protonmail.com> AuthorDate: 2022-02-16 23:40:25 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2022-02-19 00:06:35 +0000 net-mgmt/netdata: Remove claim script when CLOUD=off PR: 261979 net-mgmt/netdata/Makefile | 4 ++++ net-mgmt/netdata/pkg-plist | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5a36d25faa5863fc893353a36034c897d9b23b97 commit 5a36d25faa5863fc893353a36034c897d9b23b97 Author: Namkhai B <namkhai.n3@protonmail.com> AuthorDate: 2022-02-18 23:10:20 +0000 Commit: Neel Chauhan <nc@FreeBSD.org> CommitDate: 2022-02-19 00:07:05 +0000 net-mgmt/netdata: Depend on protobuf when CLOUD=on PR: 261979 net-mgmt/netdata/Makefile | 1 + 1 file changed, 1 insertion(+)