Bug 262019 - math/igraph: Use upstream release archive, remove libtool, add LICENSE_FILE
Summary: math/igraph: Use upstream release archive, remove libtool, add LICENSE_FILE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Wen Heping
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-02-17 17:44 UTC by Daniel Engberg
Modified: 2022-03-19 06:31 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (wen)
koobs: merge-quarterly?

Attachments
Patch for igraph (1.64 KB, patch)
2022-02-17 17:44 UTC, Daniel Engberg 		no flags Details | Diff
Patch for igraph v2 (1.64 KB, patch)
2022-02-17 22:46 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-02-17 17:44:04 UTC 
Created attachment 231901 [details]
Patch for igraph

Use upstream release archive as recommended by Porters Handbook (USE_GITHUB section)
Remove libtool dependency
Use DISTVERSION as recommended by Porters Handbook (3.1. Writing the Makefile and "Table 2. Package Naming Examples")

Compiled tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist)
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-02-17 21:32:20 UTC 
@Daniel Could you explain the why for libtool removal? Is it not used? No longer necessary with distfiles change?

Also, LICENSE_FILES should be LICENSE_FILE?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-02-17 22:46:27 UTC 
Created attachment 231907 [details]
Patch for igraph v2

Use correct variable name, LICENSE_FILES --> LICENSE_FILE
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-02-17 22:49:31 UTC 
(In reply to Kubilay Kocak from comment #1)
libtool isn't used at all, this requirement most likely changed when upstream switched to use CMake

Thanks for pointing out my mistake about LICENSE_FILE
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-03-15 10:51:15 UTC 
Friendly ping
Comment 5 wen 2022-03-15 11:37:11 UTC 
(In reply to Daniel Engberg from comment #4)
Sorry for the delay.
I approve the patch, please go ahead !
Thank you !

wen
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-03-19 06:30:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1df2fd6a40dd5f605eb2a6492c42ea1e641ca280

commit 1df2fd6a40dd5f605eb2a6492c42ea1e641ca280
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-03-19 06:19:25 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-03-19 06:19:29 +0000

    math/igraph: Use upstream release archive

    - Define LICENSE_FILE
    - Remove libtool dependency
    - Use DISTVERSION to follow Porters Handbook more closely

    PR:             262019
    Reviewed by:    wen (maintainer)

 math/igraph/Makefile | 9 +++++----
 math/igraph/distinfo | 6 +++---
 2 files changed, 8 insertions(+), 7 deletions(-)