Bug 262059 - net-mgmt/netdata: Style fix
Summary: net-mgmt/netdata: Style fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Neel Chauhan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-20 02:17 UTC by Daniel Engberg
Modified: 2022-02-21 07:26 UTC (History)
1 user (show)

See Also:
nc: maintainer-feedback+

Attachments
Patch for netdata (666 bytes, patch)
2022-02-20 02:17 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-02-20 02:17:44 UTC 
Created attachment 231951 [details]
Patch for netdata

For consistency define LIB_DEPENDS before CONFIGURE_ARGS
Comment 1 Neel Chauhan freebsd_committer freebsd_triage 2022-02-20 03:53:36 UTC 
LGTM. Feel free to commit.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-02-20 20:34:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a0f80c44ecde93e04a984c9053d965fa73594407

commit a0f80c44ecde93e04a984c9053d965fa73594407
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-02-20 20:34:03 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-02-20 20:34:03 +0000

    net-mgmt/netdata: Style fix

    PR:     262059

 net-mgmt/netdata/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Namkhai B. 2022-02-21 01:57:44 UTC 
`+CLOUD_LIB_DEPENDS=		libcups.so:print/cups`

Daniel, you moved the print/cups dependency to CLOUD=on?
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-02-21 07:26:53 UTC 
Fixed in https://cgit.freebsd.org/ports/commit/?id=140cad7652116fc608f3764570442ce07e8be97d
Thanks for reporting!