Bug 262063 - www/nginx: error in extra-patch-spnego-http-auth-nginx-module-config
Summary: www/nginx: error in extra-patch-spnego-http-auth-nginx-module-config
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-20 15:25 UTC by Igor Malyshev
Modified: 2022-03-04 16:12 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (joneum)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Malyshev 2022-02-20 15:25:55 UTC 
Created new bug report because of some misunderstanding in bug #261810.
Line +ngx_module_incs="%%GSSAPINCDIR%%" in file extra-patch-spnego-http-auth-nginx-module-config incorrectly patched in bug #261810.
Must be +ngx_module_incs="%%GSSAPIINCDIR%%"

This is piece of build log with incorrect file:
cc -c -fPIC -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -I /usr/local/include -I src/core  -I src/event  -I src/event/modules  -I src/os/unix  -I /usr/obj/usr/ports/www/nginx/work/ngx_devel_kit-0.3.1/objs  -I objs/addon/ndk  -I /usr/obj/usr/ports/www/nginx/work/ngx_devel_kit-0.3.1/src  -I /usr/obj/usr/ports/www/nginx/work/ngx_devel_kit-0.3.1/objs  -I objs/addon/ndk  -I %%GSSAPINCDIR%%  -I objs  -I src/http  -I src/http/modules  -I src/http/v2  -I /usr/obj/usr/ports/www/nginx/work/ngx_devel_kit-0.3.1/src  -I src/stream  -o objs/src/stream/ngx_stream_set_module.o  src/stream/ngx_stream_set_module.c

As you can see %%GSSAPINCDIR%% not replaced, and honestly I don’t understand why it builds without error.
Comment 1 Jochen Neumeister freebsd_committer freebsd_triage 2022-02-23 12:23:28 UTC 
I will look again later at home. 
you say it's "just" a typo, correct?
Comment 2 Igor Malyshev 2022-02-23 21:23:12 UTC 
(In reply to Jochen Neumeister from comment #1)

yes
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-03-04 16:11:46 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=efc9fa64c1050afeef3666b073bbcafba5b7bad4

commit efc9fa64c1050afeef3666b073bbcafba5b7bad4
Author:     Jochen Neumeister <joneum@FreeBSD.org>
AuthorDate: 2022-03-04 16:09:45 +0000
Commit:     Jochen Neumeister <joneum@FreeBSD.org>
CommitDate: 2022-03-04 16:10:47 +0000

    www/nginx: Fix Typo

    PR:     262063
    Sponsored by:   Netzkommune GmbH

 www/nginx/files/extra-patch-spnego-http-auth-nginx-module-config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)