Bug 262234 - [NEW PORT] www/darkhttpd
Summary: [NEW PORT] www/darkhttpd
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-27 19:11 UTC by Henrich Hartzer
Modified: 2022-03-03 07:07 UTC (History)
3 users (show)

See Also:

Attachments
www/darkhttpd (1.20 KB, patch)
2022-02-27 19:11 UTC, Henrich Hartzer 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henrich Hartzer 2022-02-27 19:11:13 UTC 
Created attachment 232144 [details]
www/darkhttpd

Let me know if this needs any adjustment or if you have any questions.

Thank you!
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2022-03-01 02:59:45 UTC 
Thanks for the patch, if possible, please set your name at https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=account so we can use that in `git commit --author`
Comment 2 Henrich Hartzer 2022-03-01 04:29:23 UTC 
(In reply to Li-Wen Hsu from comment #1)

Done. Thank you!
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-03-01 15:17:49 UTC 
LGTM.

Build tests fine in 12.3{amd64,i386}, 13.0amd64 and -current amd64.

Also, it seems to run just fine.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-03-02 07:14:12 UTC 
PORTVERSION --> DISTVERSION (https://docs.freebsd.org/en/books/porters-handbook/book/#porting-makefile and "Table 2. Package Naming Examples")
post-stage should be do-install

Best regards,
Daniel
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-03-02 07:16:32 UTC 
..also, "Example 17. Use of USE_GITHUB with DISTVERSIONPREFIX" in Porters Handbook doesn't work ?

Best regards,
Daniel
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-03-02 09:24:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=76aee1b05b961872993f4a1967e3fbc748ff9a63

commit 76aee1b05b961872993f4a1967e3fbc748ff9a63
Author:     Henrich Hartzer <henrichhartzer@tuta.io>
AuthorDate: 2022-03-01 13:15:29 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-03-02 09:20:31 +0000

    www/darkhttpd: Add new port

    Simple static http web server.
    When you need a web server in a hurry.

    PR:     262234
    Reported by:    henrichhartzer@tuta.io
    Reviewed by:    diizzy@

 www/Makefile                  |  1 +
 www/darkhttpd/Makefile (new)  | 21 +++++++++++++++++++++
 www/darkhttpd/distinfo (new)  |  3 +++
 www/darkhttpd/pkg-descr (new) |  3 +++
 4 files changed, 28 insertions(+)
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2022-03-02 09:24:35 UTC 
Committed with the suggested changes.

Thanks!
Comment 8 Henrich Hartzer 2022-03-02 17:19:09 UTC 
Thank you so much for merging!

I just saw this commit: https://cgit.freebsd.org/ports/commit/?id=088f0b29ee71a22a73d378a96f44d52f99befb28

I thought that NO_INSTALL was to be used when there was no `make install` target, and didn't signal that the port didn't install anything? darkhttpd's makefile has no install target, so I did it manually in do-stage.

Please let me know if I'm mistaken here, or if I should make any follow up patches for this port.
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2022-03-03 07:07:38 UTC 
(In reply to Henrich Hartzer from comment #8)

NO_INSTALL made sense in the first version of the patch that did not have a do-install target (it used post-patch). However when Daniel rightly pointed out that post-patch should be in fact do-install, the NO_INSTALL variable should have been removed (my bad). NO_INSTALL literally says that this port does not have a install target.

By default all ports have a install target, either by defining do-install or by using a default do-install target provided by the framework.

Cheers.