Bug 262245 - www/phalcon: update to 5.0.0beta3
Summary: www/phalcon: update to 5.0.0beta3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://blog.phalcon.io/post/phalcon-...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-28 13:50 UTC by Vidar Karlsen
Modified: 2022-03-10 07:19 UTC (History)
2 users (show)

See Also:
franco: maintainer-feedback+


Attachments
git format-patch (1.18 KB, patch)
2022-02-28 13:50 UTC, Vidar Karlsen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vidar Karlsen 2022-02-28 13:50:17 UTC
Created attachment 232158 [details]
git format-patch

The attached patch updates Phalcon 5 to the third beta version, released Feb 08, 2022.

QA: Build-tested (poudriere testport) on 13.0.

Changelog snipped from https://blog.phalcon.io/post/phalcon-5-0-0beta3-released:

Phalcon v5.0.0beta3 has been released, featuring mostly bug fixes! 

Changed:
- Renamed Phalcon\Db\Result\Pdo to Phalcon\Db\Result\PdoResult to avoid collisions with \PDO #15874

Fixed
- Fixed Phalcon\Logger\AbstractAdapter::getFormattedItem() to not add PHP_EOL at the end of the message and added it to the Phalcon\Logger\Adapter\Stream #14547
- Fixed Phalcon\Html\Helper\Title:__invoke() to not use the $separator as parameter - no need to redefine it in a view #15866
- Fixed the delimiters for Phalcon\Support\Helper\SnakeCase and Phalcon\Support\Helper\KamelCase #15850
- Fixed Phalcon\Mvc\Router\Route::getName() and Phalcon\Mvc\Router\Route::getHostname() to also return null #15880
- Fixed Phalcon\Mvc\Router\RouteInterface::getName() and Phalcon\Mvc\Router\RouteInterface::getHostname() to also return null #15880
- Fixed Phalcon\Mvc\Model::findFirst() to return mixed or null #15883

Added
- Added Phalcon\Html\Helper\Title:setSeparator to allow setting the separator independently #15866
Comment 1 Franco Fichtner 2022-02-28 14:03:50 UTC
looks good. thanks!
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-03-09 15:02:08 UTC
It does not build in poudriere.

Would you check it?

=====
Message from php80-pdo-8.0.16:

--
This file has been added to automatically load the installed extension:
/usr/local/etc/php/ext-20-pdo.ini
===>   php80-phalcon-5.0.0.b3 depends on file: /usr/local/lib/php/20200930-debug/pdo.so - not found
*** Error code 1

Stop.
Comment 3 Vidar Karlsen 2022-03-09 21:21:32 UTC
(In reply to Fernando Apesteguía from comment #2)

It builds for me, doing poudriere testport on 13.0-RELEASE-p7:

> Message from php80-pdo-8.0.16:
> 
> --
> This file has been added to automatically load the installed extension:
> /usr/local/etc/php/ext-20-pdo.ini
> ===>   php80-phalcon-5.0.0.b3 depends on file: /usr/local/lib/php/20200930/pdo.so - found
> ===>   Returning to build of php80-phalcon-5.0.0.b3

I rebased my ports tree to 70c9959b17e23dd8cd6bfcb1667e8809fcc5e82a before testing to make sure there weren't any recent changes causing problems I hadn't detected before submitting the patch.

Please note the lack of the "-debug" postfix in my output. Might there be a non-standard setting causing issues with your test build?
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2022-03-10 07:19:18 UTC
Committed,

Yes, a WITH_DEBUG was accidentally slipped...

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-03-10 07:19:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5c079b62759de7f8438ee7442da81df2451ae2ea

commit 5c079b62759de7f8438ee7442da81df2451ae2ea
Author:     Vidar Karlsen <vidar@karlsen.tech>
AuthorDate: 2022-03-09 07:31:43 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-03-10 07:16:17 +0000

    www/phalcon: update to 5.0.0beta3

    ChangeLog: https://blog.phalcon.io/post/phalcon-5-0-0beta3-released

    PR:     262245
    Reported by:    vidar@karlsen.tech
    Approved by:    franco@opnsense.org (maintainer)

 www/phalcon/Makefile | 2 +-
 www/phalcon/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)