Bug 262257 - [exp-run] devel/libunwind: Update to 20211201 (1.6.2)
Summary: [exp-run] devel/libunwind: Update to 20211201 (1.6.2)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://people.freebsd.org/~sunpoet/p...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-28 19:20 UTC by Po-Chuan Hsieh
Modified: 2022-03-25 15:17 UTC (History)
2 users (show)

See Also:
antoine: exp-run+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-02-28 19:20:43 UTC
devel/libunwind: Update to 20211201 (1.6.2)

Changes:        https://github.com/libunwind/libunwind/releases
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2022-03-05 08:52:52 UTC
Exp-run looks fine
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-03-07 18:28:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=987c1ed1c3c2ea445e5173226ed393e3003a03f9

commit 987c1ed1c3c2ea445e5173226ed393e3003a03f9
Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2022-03-07 17:50:14 +0000
Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2022-03-07 18:10:55 +0000

    devel/libunwind: Update to 20211201 (1.6.2)

    Changes:        https://github.com/libunwind/libunwind/releases
    PR:             262257
    Exp-run by:     antoine

 devel/libunwind/Makefile                     |   4 +-
 devel/libunwind/distinfo                     |   6 +-
 devel/libunwind/files/patch-powerpc64 (gone) | 465 ---------------------------
 3 files changed, 5 insertions(+), 470 deletions(-)
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-03-07 18:38:45 UTC
Committed. Thanks!
Comment 4 Brad Davis freebsd_committer freebsd_triage 2022-03-09 16:12:45 UTC
Looks like this is broken on aarch64 both on main (http://ampere2.nyi.freebsd.org/data/main-arm64-default/p422f190aeba4_s23210c9f42/logs/errors/libunwind-20211201.log) and 13:

--- aarch64/Gis_signal_frame.lo ---                                                                   
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../include -I../include -I../include/tdep-aarch64 -I. -D_GNU_SOURCE -DNDEBUG -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fexceptions -Wall -Wsign-c
ompare -D__EXTENSIONS__ -MT aarch64/Gis_signal_frame.lo -MD -MP -MF aarch64/.deps/Gis_signal_frame.Tpo -c aarch64/Gis_signal_frame.c -o aarch64/Gis_signal_frame.o >/dev/null 2>&1
--- aarch64/Ginit.lo ---                                                                                                                                                                                    
    return &uc->uc_mcontext.regs[reg];                                                                
            ~~~~~~~~~~~~~~~ ^                                                                         
aarch64/Ginit.c:52:13: error: expected expression                                                                                                                                                           
    return &GET_FPCTX(uc)->vregs[reg - UNW_AARCH64_V0];                                                                                                                                                     
            ^                                                                                                                                                                                               
aarch64/unwind_i.h:62:47: note: expanded from macro 'GET_FPCTX'                                                                                                                                             
#define GET_FPCTX(uc) ((unw_fpsimd_context_t *)(&uc->uc_mcontext.__reserved))                                                                                                                               
                                              ^                                                       
aarch64/Ginit.c:52:13: error: use of undeclared identifier 'unw_fpsimd_context_t'
aarch64/unwind_i.h:62:25: note: expanded from macro 'GET_FPCTX'            
#define GET_FPCTX(uc) ((unw_fpsimd_context_t *)(&uc->uc_mcontext.__reserved))
                        ^                                                                             
aarch64/Ginit.c:52:13: error: no member named '__reserved' in 'struct __mcontext'
    return &GET_FPCTX(uc)->vregs[reg - UNW_AARCH64_V0];
            ^~~~~~~~~~~~~
aarch64/unwind_i.h:62:66: note: expanded from macro 'GET_FPCTX'
#define GET_FPCTX(uc) ((unw_fpsimd_context_t *)(&uc->uc_mcontext.__reserved))
                                                 ~~~~~~~~~~~~~~~ ^
aarch64/Ginit.c:180:27: warning: passing 'unsigned char *' to parameter of type 'char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpoi
nter-sign]
  if (mincore (addr, len, (unsigned char *)mvec) != 0)
                          ^~~~~~~~~~~~~~~~~~~~~
--- aarch64/Gresume.lo ---
aarch64/Gresume.c:145:3: warning: implicitly declaring library function 'printf' with type 'int (const char *, ...)' [-Wimplicit-function-declaration]
  printf ("%s: implement me\n", __FUNCTION__);
  ^
aarch64/Gresume.c:145:3: note: include the header <stdio.h> or explicitly provide a declaration for 'printf'
--- aarch64/Ginit.lo ---
/usr/include/sys/mman.h:327:41: note: passing argument to parameter here
--- aarch64/Gglobal.lo ---
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../include -I../include -I../include/tdep-aarch64 -I. -D_GNU_SOURCE -DNDEBUG -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fexceptions -Wall -Wsign-c
ompare -D__EXTENSIONS__ -MT aarch64/Gglobal.lo -MD -MP -MF aarch64/.deps/Gglobal.Tpo -c aarch64/Gglobal.c -o aarch64/Gglobal.o >/dev/null 2>&1
--- aarch64/Ginit.lo ---
int     mincore(const void *, size_t, char *);
                                            ^
aarch64/Ginit.c:203:50: warning: passing 'unsigned char *' to parameter of type 'char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpoi
nter-sign]
  while ((ret = mincore ((void*)addr, PAGE_SIZE, (unsigned char *)mvec)) == -1 &&
                                                 ^~~~~~~~~~~~~~~~~~~~~
/usr/include/sys/mman.h:327:41: note: passing argument to parameter here
int     mincore(const void *, size_t, char *);
                                            ^
2 warnings and 4 errors generated.
*** [aarch64/Ginit.lo] Error code 1
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2022-03-12 21:42:30 UTC
Re-open as this fails on arm64
Comment 6 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-03-25 15:17:53 UTC
aarch64 build has been fixed in b53231cc31b2d4e933ba2893c8079cc7d1f07413.