Bug 262320 - lumina-core: Fix password check in LScreensaver, remove xscreensaver dep
Summary: lumina-core: Fix password check in LScreensaver, remove xscreensaver dep
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-03 16:46 UTC by Jason W. Bacon
Modified: 2022-03-04 01:04 UTC (History)
1 user (show)

See Also:
lbartoletti: maintainer-feedback+


Attachments
Patch to fix LScreensaver (8.60 KB, patch)
2022-03-03 16:46 UTC, Jason W. Bacon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason W. Bacon freebsd_committer freebsd_triage 2022-03-03 16:46:05 UTC
Created attachment 232226 [details]
Patch to fix LScreensaver

Currently, Lumina installs its own screensaver, LScreensaver, which overrides xscreensaver.  However, the screen lock function doesn't actually check passwords because lumina-checkpass is disabled and does not build properly.  The screen will unlock regardless of what is entered for the password.

This patch fixes and enables lumina-checkpass and removes xscreensaver as s dependency.
Comment 1 Jason W. Bacon freebsd_committer freebsd_triage 2022-03-03 16:52:48 UTC
Upstream issue: https://github.com/lumina-desktop/lumina/issues/808
Comment 2 Loïc Bartoletti freebsd_committer freebsd_triage 2022-03-03 18:49:18 UTC
Ship it!
BTW, do you to take maintainer'ship of lumina?
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-03-04 01:04:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f096655c794b3e062bf5c2eda8c71cdb798c7134

commit f096655c794b3e062bf5c2eda8c71cdb798c7134
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2022-03-04 00:58:34 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2022-03-04 00:58:34 +0000

    x11/lumina-core: Fix LScreensaver password check

    lumina-checkpass was disabled in the previous build, causing the
    screensaver to unlock on any input rather than just the correct pw.

    Also removed xscreensaver dep, replaced by LScreensaver.

    LPanel patch is a hack to redraw the panel after screen resize.  Makes
    Lumina usable, though still not pretty, in a VirtualBox guest with
    guest additions.  Still needs wallpaper redraw.

    PR:             262320
    Approved by:    lbartoletti

 x11/lumina-core/Makefile                           |   3 +-
 x11/lumina-core/files/patch-core.pro (new)         |  13 +++
 ...tch-lumina-checkpass_lumina-checkpass.pro (new) |  11 ++
 .../files/patch-lumina-checkpass_main.c (new)      | 122 +++++++++++++++++++++
 .../files/patch-lumina-desktop_LPanel.cpp (new)    |  14 +++
 ...a-desktop_src-screensaver_LLockScreen.cpp (new) |  22 ++++
 x11/lumina-core/pkg-plist                          |   1 +
 7 files changed, 184 insertions(+), 2 deletions(-)