Created attachment 232327 [details] patch from 1.2.3 to 1.3.2 - updated executables to upstream v1.3.2 - removed log rotation with newsyslog (implemented natively in the executable) - fixed notifier plugin support for freebsd - added optional dependency on firewall bouncer
Maintainer informed via mail
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. Q/A: Makefile: [133]: whitespace before end of line. (No need to update a new patch). Also, if you are the maintainer (as it looks like), please set maintainer-approval flag in the attachment. Thanks!
====> Running Q/A tests (stage-qa) Warning: Possible REINPLACE_CMD issues: - - REINPLACE_CMD ran, but did not modify file contents: config/profiles.yaml ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%ETCDIR%%/crowdsec.service Error: Orphaned: %%ETCDIR%%/dev.yaml Error: Orphaned: %%ETCDIR%%/user.yaml Error: Orphaned: @dir %%ETCDIR%%/notifications/email Error: Orphaned: @dir %%ETCDIR%%/notifications/http Error: Orphaned: @dir %%ETCDIR%%/notifications/slack Error: Orphaned: @dir %%ETCDIR%%/notifications/splunk ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 Please, ensure the ports pass a poudriere run. https://docs.freebsd.org/en/books/porters-handbook/testing/ Cheers.
(In reply to Fernando Apesteguía from comment #3) Thanks! I have set up poudriere, running now, will update the patch asap.
Created attachment 232374 [details] clean up stagedir tested with poudriere
WARN: Makefile: [140]: whitespace before end of line. WARN: Makefile: [134]: possible direct use of command "rmdir" found. use ${RMDIR} instead. WARN: Makefile: [135]: possible direct use of command "rmdir" found. use ${RMDIR} instead. WARN: Makefile: [136]: possible direct use of command "rmdir" found. use ${RMDIR} instead. WARN: Makefile: [137]: possible direct use of command "rmdir" found. use ${RMDIR} instead. WARN: Makefile: [130]: possible direct use of command "rm" found. use ${RM} instead. WARN: Makefile: [132]: possible direct use of command "rm" found. use ${RM} instead. WARN: Makefile: [133]: possible direct use of command "rm" found. use ${RM} instead. FATAL: Makefile: DISTVERSIONPREFIX appears out-of-order. FATAL: Makefile: order must be PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTREVISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKGNAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES(_\w+)?/DIST_SUBDIR/EXTRACT_ONLY. Could you attach a final patch that updates the port to the desired version? It is much easier than applying patchs one on top of the others :-) Thanks!
Created attachment 232382 [details] patch for crowdsec 1.3.2 I don't know why it complained about DISTVERSIONPREFIX, the order is correct. I tested this one with portlint too, I get a warning on /var/db but it's ok. Thanks again
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d6ce96e20b6a2ce4b4d4cd9bf386b967a1b76ddd commit d6ce96e20b6a2ce4b4d4cd9bf386b967a1b76ddd Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2022-03-11 13:27:29 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-03-12 18:21:43 +0000 security/crowdsec: update to 1.3.2 PR: 262426 Reported by: marco+freebsd@crowdsec.net (maintainer) security/crowdsec/Makefile | 55 ++++++++++++---------- security/crowdsec/distinfo | 6 +-- .../crowdsec/files/crowdsec.conf-newsyslog (gone) | 3 -- security/crowdsec/files/crowdsec.in | 1 + security/crowdsec/files/patch-Makefile | 32 ++++--------- security/crowdsec/pkg-plist | 11 ++--- 6 files changed, 48 insertions(+), 60 deletions(-)