Bug 262902 - www/py-bleach: Add www/py-html5lib to run depends
Summary: www/py-bleach: Add www/py-html5lib to run depends
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-03-29 10:51 UTC by Dan Kotowski
Modified: 2022-04-02 10:29 UTC (History)
6 users (show)

See Also:


Attachments
www/py-bleach: Fix run depends (808 bytes, patch)
2022-04-01 20:44 UTC, Sascha Biberhofer
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Kotowski 2022-03-29 10:51:43 UTC
Please add www/py-html5lib to the run depends for bleach. Per documentation it is needed to run. Also:



Python 3.8.13 (default, Mar 26 2022, 12:55:24)
[Clang 13.0.0 (git@github.com:llvm/llvm-project.git llvmorg-13.0.0-0-gd7b669b3a on freebsd13
Type "help", "copyright", "credits" or "license" for more information.
>>> import bleach
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/site-packages/bleach/__init__.py", line 5, in <module>
    from bleach.linkifier import (
  File "/usr/local/lib/python3.8/site-packages/bleach/linkifier.py", line 4, in <module>
    from bleach import html5lib_shim
  File "/usr/local/lib/python3.8/site-packages/bleach/html5lib_shim.py", line 20, in <module>
    from bleach._vendor.html5lib import (  # noqa: E402 module level import not at top of file
  File "/usr/local/lib/python3.8/site-packages/bleach/_vendor/html5lib/__init__.py", line 25, in <module>
    from .html5parser import HTMLParser, parse, parseFragment
  File "/usr/local/lib/python3.8/site-packages/bleach/_vendor/html5lib/html5parser.py", line 6, in <module>
    from . import _inputstream
  File "/usr/local/lib/python3.8/site-packages/bleach/_vendor/html5lib/_inputstream.py", line 10, in <module>
    import webencodings
ModuleNotFoundError: No module named 'webencodings'



This may be fixable with just converters/py-webencodings, but the docs explicitly say www/py-html5lib
Comment 1 Sascha Biberhofer 2022-04-01 20:44:53 UTC
Created attachment 232877 [details]
www/py-bleach: Fix run depends

Seems like the recent update to 4.1.0 in commit aaf59e6e78c21a5c0fb917455c8a4b84a46e4572 introduced a typo which renamed RUN_DEPENDS to xRUN_DEPENDS, which causes to the package to end up w/o run dependencies.

This patch fixes that type and bumps the revision.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2022-04-02 03:28:01 UTC
Bugfixes are:

Approved by: portmgr (blanket: bugfix)

MFH is quarterly is also affected
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2022-04-02 03:28:32 UTC
Comment on attachment 232877 [details]
www/py-bleach: Fix run depends

Approved by: portmgr (blanket: bugfix)

Anyone can take/commit this with confirmed QA
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-04-02 10:27:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1396c410a5468e657cf737ea38e563541bb4e828

commit 1396c410a5468e657cf737ea38e563541bb4e828
Author:     Sascha Biberhofer <ports@skyforge.at>
AuthorDate: 2022-04-02 10:19:20 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-04-02 10:22:49 +0000

    www/py-bleach: Fix typo in RUN_DEPENDS

    PR:             262902
    Reported by:    Dan Kotowski <dan.kotowski@a9development.com>
    Fixes:          aaf59e6e78c21a5c0fb917455c8a4b84a46e4572
    MFH:            2022Q2

 www/py-bleach/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-04-02 10:29:01 UTC
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=606d504c87cc0bc7a1302d6725b3e5b669bdef20

commit 606d504c87cc0bc7a1302d6725b3e5b669bdef20
Author:     Sascha Biberhofer <ports@skyforge.at>
AuthorDate: 2022-04-02 10:19:20 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-04-02 10:27:39 +0000

    www/py-bleach: Fix typo in RUN_DEPENDS

    PR:             262902
    Reported by:    Dan Kotowski <dan.kotowski@a9development.com>
    Fixes:          aaf59e6e78c21a5c0fb917455c8a4b84a46e4572
    MFH:            2022Q2

    (cherry picked from commit 1396c410a5468e657cf737ea38e563541bb4e828)

 www/py-bleach/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)