Bug 262941 - ports-mgmt/portlint: MASTER_SITES parsing bug
Summary: ports-mgmt/portlint: MASTER_SITES parsing bug
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-30 15:37 UTC by Daniel Engberg
Modified: 2022-04-05 20:45 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-03-30 15:37:14 UTC 
Applying the patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262940 makes portlint -C fail with:
make: "/usr/share/mk/sys.mk" line 201: Unclosed variable "DISTVERSION"
make: "/usr/share/mk/sys.mk" line 215: Unclosed variable "DISTVERSION"
make: Fatal errors encountered -- cannot continue

Removing :R in MASTER_SITES url fixes the issue though (verfied by arrowd)

Using a fresh checkout of the ports free
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2022-04-05 20:42:03 UTC 
Fixed in 2.19.11.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-04-05 20:42:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3ac754dbcea5101f4e7c36242c2df36db2a7e5c9

commit 3ac754dbcea5101f4e7c36242c2df36db2a7e5c9
Author:     Joe Marcus Clarke <marcus@FreeBSD.org>
AuthorDate: 2022-04-05 20:40:54 +0000
Commit:     Joe Marcus Clarke <marcus@FreeBSD.org>
CommitDate: 2022-04-05 20:40:54 +0000

    ports-mgmt/portlint: Update to 2.19.11

    * Do not strip modifiers from variables when dereferencing.

    PR:             262941

 ports-mgmt/portlint/Makefile        |  3 +--
 ports-mgmt/portlint/src/portlint.pl | 17 +++++++++--------
 2 files changed, 10 insertions(+), 10 deletions(-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-04-05 20:45:21 UTC 
Thanks for looking into it and you're doing a great work maintaining portlint