Bug 262954 - dns/libpsl: Switch to (lib)icu as default library
Summary: dns/libpsl: Switch to (lib)icu as default library
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-31 08:00 UTC by Daniel Engberg
Modified: 2022-04-24 20:13 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
Patch for libpsl (1.23 KB, patch)
2022-03-31 08:00 UTC, Daniel Engberg
no flags Details | Diff
Patch for libpsl v2 (660 bytes, patch)
2022-04-05 17:02 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-03-31 08:00:46 UTC
Created attachment 232837 [details]
Patch for libpsl

Upstream confusingly refers to (re)generation of man pages as "--enable-man" in configure script. Pages are already pre-generated so no need to regenerate.
While at it, switch to (lib)icu as its a more common dependency in ports tree.

Compile tested on FreeBSD 13.0-STABLE #2 stable/13-n248607-93a95ebbf7c (amd64) (make, make check-plist)
Poudriere testport OK 12.3-RELEASE (amd64)
Poudriere testport OK 13.0-RELEASE (i386)
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-04-05 16:49:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=97e347a3a6aa4792eacaa10e6fbf41d8b8c73526

commit 97e347a3a6aa4792eacaa10e6fbf41d8b8c73526
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-04-05 16:44:47 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-04-05 16:49:05 +0000

    dns/libpsl: Don't rebuild man pages

    Upstream confusingly refers to (re)generation of man pages as
    "--enable-man" in configure script. Pages are already pre-built
    so no need to rebuild

    PR:             262954
    Reported by:    gja822@narod.ru
    Approved by:    portmgr (blanket)

 dns/libpsl/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-04-05 17:02:53 UTC
Created attachment 232975 [details]
Patch for libpsl v2

Refresh patch as one half is committed
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2022-04-24 19:59:42 UTC
Thanks for removing libxslt from BUILD_DEPENDS.

I'd like to keep using libidn2 by default because it's upstream default and it's lighter than icu. One more reason is about wget and wget2 which have IDN and PSL options. They uses libidn2 already and libpsl (PSL option) does not bring extra dependencies.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-04-24 20:13:23 UTC
The idea was to reduce libraries overall as you're more likely to pull in icu (by looking at the amount of ports depending on it) compared to libidn2 but it's up to you.

Best regards,
Daniel