Created attachment 232852 [details] patch for net/remmina update to 1.4.25 net/remmina has a new upstream release avaialble. I've attached a diff that presents an approach for updating the port to this new relese. Description of changes, in the diff: - distinfo updated - adding libappindicator to lib depends - Moving libxkbfile from top-level USES_XORG to lib depends under the RDP build option, per changeset 6dfa1725[1] (XKBfile.h) - corresponding to the deprectation of XEmbed support in GTK - remarked of in Remmina source file plugins/README.md - the NX, XDMCP, and Simple Terminal (ST) plugins are no longer developed in Remmina. This was introduced in the Remmina project changeset 6dfa1725[1]. Makefile and pkg-plist have been updated for this change in upstream - icons renamed under pkg-plist - Uzbek language support is now added for Remmina under the NLS build option This update for net/remmina => 1.4.25 has been tested insofar as for VNC support with OpenSUSE Tumbelweed (UEFI) and NetBSD 9/current (also UEFI for the video console support, here booted from the bootloader in the NetBSD installer ISO to avoid a segfault in NetBSD boot on an empty null.iso, as a workaround) ... under bhyve. This was with a Remmina build using the following build options on a FreeBSD 12.3 amd64 machine AVAHI : off BASH : on CUPS : off EXEC : on GCRYPT : on KWALLET : off NLS : on RDP : on SECRET : on SPICE : off SSH : on TERM : on VNC : on WWW : on ZSH : off This Remmina release might offer some stability improvements after earlier versions [1]: https://gitlab.com/Remmina/Remmina/-/commit/6dfa1725b2c082c14403408c123b8337cd482fa2
In the diff, the BASH and ZSH options and the SHELL options group were also added. These may have been introduced from some early-morning patch in the local ports tree.
After reviewing the Remmina changelogs again, at https://gitlab.com/Remmina/Remmina/-/commit/6dfa1725b2c082c14403408c123b8337cd482fa2 the xdmcp, nx, and st plugins have been moved to another repository: https://gitlab.com/Remmina/remmina-plugins Theoretically, those plugins could still be supported in this port. This could be approached with a distinfo update and Makefile tooling for building and installing from that new project in Remmina's gitlab space. The plugins in that project might not be actively maintained.
To clarify the added BASH and ZSH options in the patch: This would allow for selecting which shell to use, in configuration for /usr/ports/Mk/Uses/shebangfix.mk It allows for using zsh instead of bash, in the remmina-file-wrapper script. The source file for the script is already patched under the shebangfix tooling, atddata/desktop/remmina-file-wrapper.in This addition simply allows for using a different, generally bash-compatible shell (ZSH) instead of Bash for running remmina-file-wrapper
Thanks for the patch. I'll have a look ASAP.
Hi Sean, The port works nice for me. I extensively tested the RDP protocol, windowing, copy-paste, etc. I have a question though. What are BASH_VARS and ZSH_VARS for?
(In reply to Fernando Apesteguía from comment #5) Never mind, it is needed for building and (In reply to Fernando Apesteguía from comment #5) It doesn't matter. You already explained. I'll try and commit this later today.
Committed, Thanks for the update!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1cd78d6606830acb02ca417932132f5a968561bc commit 1cd78d6606830acb02ca417932132f5a968561bc Author: Sean Champ <lab+bsd@thinkum.space> AuthorDate: 2022-04-01 18:09:07 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-04-11 16:53:12 +0000 net/remmina: Updating to 1.4.25 From ChangeLog: https://remmina.org/v1.4.25/ Add BASH and ZSH options * kiosk: Drop GNOME MediaKeys plugin * Honour soft links target in SFTP * Optional close confirmation * Fix some build warnings * Fix manpages * Snap cleanup + kwallet support * Deprecations and amend g_date_time_format_iso8601 * Fixes to snap build * Removing dependencies that are available as extensions * FreeRDP_OffscreenSupportLevel is of type UINT32 * Minor fixes * Get the right value for FreeRDP_AutoReconnectMaxRetries PR: 262968 Reported by: lab+bsd@thinkum.space net/remmina/Makefile | 47 +++++++++++------------- net/remmina/distinfo | 6 +-- net/remmina/pkg-plist | 100 +++++++++++++++++++------------------------------- 3 files changed, 62 insertions(+), 91 deletions(-)