Bug 263003 - print/ghostscript9-agpl-base: fix build on armv6/armv7
Summary: print/ghostscript9-agpl-base: fix build on armv6/armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Mikael Urankar
URL: https://github.com/tesseract-ocr/tess...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-02 13:04 UTC by Robert Clausecker
Modified: 2022-04-03 15:26 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (hrs)
fuz: merge-quarterly?


Attachments
print/ghostscript9-agpl-base: fix build on armv6/armv7 (1.86 KB, patch)
2022-04-02 13:04 UTC, Robert Clausecker
fuz: maintainer-approval? (hrs)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-04-02 13:04:58 UTC
Created attachment 232892 [details]
print/ghostscript9-agpl-base: fix build on armv6/armv7

The bundled version of tesseract requires the <asm/hwcap.h> header
to detect the availability of NEON instructions on armv7.  This
issue has already been reported to up stream.

I am going to file a similar PR with graphics/tesseract shortly.

Please also consider unbundling tesseract or at least to make it optional in accordance with the general ports policies.

Please MFH this change as otherwise no arm packages of this port can be produced for 2022Q2.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-04-02 13:58:47 UTC
See also bug #263004.
Comment 2 Charlie Li freebsd_committer freebsd_triage 2022-04-02 20:13:58 UTC
OCR support is indeed optional, disable using --without-tesseract in CONFIGURE_ARGS
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-04-02 20:17:39 UTC
(In reply to Charlie Li from comment #2)

Yes, making it an option is also important.  But even if OCR support is selected, it should come from graphics/tesseract, not the bundled copy.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-04-03 07:38:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=16f0acba590a9b850c9a23759ed37427507910bd

commit 16f0acba590a9b850c9a23759ed37427507910bd
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-04-02 12:51:22 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2022-04-03 07:37:54 +0000

    print/ghostscript9-agpl-base: Fix build on armv7

    The bundled version of tesseract requires the <asm/hwcap.h> header
    to detect the availability of NEON instructions on armv7.  This
    issue has already been reported to up stream.

    Reported upstream:      https://github.com/tesseract-ocr/tesseract/pull/3782

    PR:             263003
    Approved by:    portmgr (build fix blanket)

 .../patch-tesseract_src_arch_simddetect.cpp (new)  | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-04-03 15:24:41 UTC
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3ab0c8c9a420bc144618ec4e3d97c611f36cacd9

commit 3ab0c8c9a420bc144618ec4e3d97c611f36cacd9
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-04-02 12:51:22 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2022-04-03 15:24:13 +0000

    print/ghostscript9-agpl-base: Fix build on armv7

    The bundled version of tesseract requires the <asm/hwcap.h> header
    to detect the availability of NEON instructions on armv7.  This
    issue has already been reported to up stream.

    Reported upstream:      https://github.com/tesseract-ocr/tesseract/pull/3782

    PR:             263003
    Approved by:    portmgr (build fix blanket)

    (cherry picked from commit 16f0acba590a9b850c9a23759ed37427507910bd)

 .../patch-tesseract_src_arch_simddetect.cpp (new)  | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)