Bug 263050 - sysutils/ipfs-go: fail to build w/ go1.18
Summary: sysutils/ipfs-go: fail to build w/ go1.18
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Guangyuan Yang
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-04-04 23:56 UTC by John-Mark Gurney
Modified: 2022-04-22 07:37 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John-Mark Gurney freebsd_committer freebsd_triage 2022-04-04 23:56:29 UTC 
Back tracking to before the go 1.18 commit allows ipfs-go to build.

BTW, ipfs-go should also be updated to 0.12.1.  I know that 0.12.1 build's w/ 1.17, but I didn't tried it w/ go 1.18.
Comment 1 Guangyuan Yang freebsd_committer freebsd_triage 2022-04-05 00:05:56 UTC 
Assigned to maintainer

Thanks for your report. I will work to bring go1.17 back to the ports tree for compatibility, and we can quickly fix this by patching Makefile to use 1.17 instead of latest for now.
Comment 2 Guangyuan Yang freebsd_committer freebsd_triage 2022-04-05 03:37:54 UTC 
The dependency that does not support Go 1.18 is:

# github.com/lucas-clemente/quic-go/internal/qtls
vendor/github.com/lucas-clemente/quic-go/internal/qtls/go118.go:6:13: cannot use "quic-go doesn't build on Go 1.18 yet." (untyped string constant) as int value in variable declaration
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-04-05 04:24:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=661c4c760599326c8ca273a1cfe945d553d1249a

commit 661c4c760599326c8ca273a1cfe945d553d1249a
Author:     Guangyuan Yang <ygy@FreeBSD.org>
AuthorDate: 2022-04-05 04:23:42 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2022-04-05 04:23:42 +0000

    sysutils/ipfs-go: Fix build

    ipfs-go has a dependency "quic-go" which does not support go 1.18 yet.
    Use go 1.17 for now.

    PR:             263050
    Reported by:    jmg
    Approved by:    portmgr (implicit, build fix)

 sysutils/ipfs-go/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-04-22 07:37:22 UTC 
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4f81540c8f0aff60e83abdb4ed4615f26f72a56f

commit 4f81540c8f0aff60e83abdb4ed4615f26f72a56f
Author:     Guangyuan Yang <ygy@FreeBSD.org>
AuthorDate: 2022-04-05 04:23:42 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2022-04-22 07:37:11 +0000

    sysutils/ipfs-go: Fix build

    ipfs-go has a dependency "quic-go" which does not support go 1.18 yet.
    Use go 1.17 for now.

    PR:             263050
    Reported by:    jmg
    Approved by:    portmgr (implicit, build fix)

    (cherry picked from commit 661c4c760599326c8ca273a1cfe945d553d1249a)

 sysutils/ipfs-go/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)