Bug 263056 - graphics/epsonscan2-non-free-plugin: Move message from .warning in Makefile to pkg-message
Summary: graphics/epsonscan2-non-free-plugin: Move message from .warning in Makefile t...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-05 09:14 UTC by Yasuhiro Kimura
Modified: 2022-04-05 22:41 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (fbsd)


Attachments
Patch file (2.44 KB, patch)
2022-04-05 09:14 UTC, Yasuhiro Kimura
no flags Details | Diff
patch to move warning to pkg-message.in (1.74 KB, patch)
2022-04-05 10:05 UTC, J.R. Oldroyd
fbsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2022-04-05 09:14:29 UTC
Created attachment 232954 [details]
Patch file

There is two problems about using .warning in Makefile.

1. It is evaluated only when make(1) is invoked. So user of binary package never see the message.
2. It is not related to specific target. So the message is displayed with improper case such as `make index`.

So add the message to pkg-message rather than using .warning in Makefile.
Comment 1 Einar Bjarni Halldórsson 2022-04-05 09:50:21 UTC
(In reply to Yasuhiro Kimura from comment #0)

It is also displayed when calling poudriere bulk, even if the package isn't in the buildlist, which is very annoying.

We call poudriere bulk with an hourly cronjob and we're getting hourly emails with this warning.
Comment 2 J.R. Oldroyd 2022-04-05 10:05:17 UTC
Created attachment 232955 [details]
patch to move warning to pkg-message.in

I am okay with this move, but I made a minor change to the wording in the pkg-message file to clarify which scanner models are affected.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-04-05 12:32:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=92e9f56d9a45e11a787effb680160fef3b8e2005

commit 92e9f56d9a45e11a787effb680160fef3b8e2005
Author:     Yasuhiro Kimura <yasu@freebsd.org>
AuthorDate: 2022-04-05 12:24:03 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2022-04-05 12:31:27 +0000

    graphics/epsonscan2-non-free-plugin: Remove warning, extend pkg-message

    There are two problems about using .warning in Makefile.

    1. It is evaluated only when make(1) is invoked.
       So user of binary package never see the message.
    2. It is not related to specific target. So the message
       is displayed with improper case such as `make index`.

    So add a message to pkg-message rather than using .warning in Makefile.

    PR:             263056

    Approved by:    J.R. Oldroyd <fbsd@opal.com> (maintainer)

 graphics/epsonscan2-non-free-plugin/Makefile             | 9 +--------
 graphics/epsonscan2-non-free-plugin/files/pkg-message.in | 4 ++++
 2 files changed, 5 insertions(+), 8 deletions(-)
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2022-04-05 12:33:34 UTC
With a slightly enhanced pkg-message (from J.R.) committed, thanks!
Comment 5 Tatsuki Makino 2022-04-05 22:35:22 UTC
Sorry for commenting after closing. But I have a question.
In such a case, is IGNORE= not added to the following versions?
.if ((${OSVERSION} >= 1400000 && ${OSVERSION} <= 1400053) || \
     (${OSVERSION} >= 1300000 && ${OSVERSION} <= 1300526) || \
      ${OSVERSION} < 1300000)
Comment 6 J.R. Oldroyd 2022-04-05 22:41:46 UTC
(In reply to Tatsuki Makino from comment #5)

This port installs a number of tools and libraries, not just es2intif.

It is only es2intif that requires a recent kernel and only then for a very small set of supported scanner models.

All the other tools work fine, even on earlier kernels, and are needed for other scanner models.  E.g., es2netif, which is needed for network access to scanners.

So an IGNORE would not be a good idea in this case.