Bug 263143 - devel/ros-urdfdom update to 3.0.2
Summary: devel/ros-urdfdom update to 3.0.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guangyuan Yang
URL:
Keywords:
Depends on: 263142
Blocks:
  Show dependency treegraph
 
Reported: 2022-04-08 13:17 UTC by Trenton Schulz
Modified: 2022-04-23 20:20 UTC (History)
2 users (show)

See Also:


Attachments
Patch from 1.0.4 to 3.0.2 (5.62 KB, patch)
2022-04-08 13:17 UTC, Trenton Schulz
trueos: maintainer-approval+
Details | Diff
Updated patch with correct plist (5.76 KB, patch)
2022-04-22 18:11 UTC, Trenton Schulz
trueos: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trenton Schulz 2022-04-08 13:17:55 UTC
Created attachment 233057 [details]
Patch from 1.0.4 to 3.0.2

Update ros-urdfdom from 1.0.4 to 3.0.2
    
    No changelog, unfortunately, but the git commits look to re-arrange
    headers, add support for ROS2 and support later versions of the Google
    Test framework.
Comment 1 Guangyuan Yang freebsd_committer freebsd_triage 2022-04-09 08:28:35 UTC
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: bin/urdf_to_graphviz
Error: Orphaned: lib/urdfdom/cmake/urdfdomExport-%%CMAKE_BUILD_TYPE%%.cmake
Error: Orphaned: lib/urdfdom/cmake/urdfdomExport.cmake
Error: Orphaned: share/urdfdom/package.xml
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/ros-urdfdom
=>> Error: check-plist failures detected
Comment 2 Guangyuan Yang freebsd_committer freebsd_triage 2022-04-21 22:27:37 UTC
Ping
Comment 3 Trenton Schulz 2022-04-22 06:36:50 UTC
Doh! Sorry. I'll take a look this evening and post an updated patch.
Comment 4 Trenton Schulz 2022-04-22 18:11:55 UTC
Created attachment 233400 [details]
Updated patch with correct plist

OK. The patch is updated. Thanks for the ping and the additional test-run.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-04-23 20:09:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=14303d0308170cca59f1a8dc0e9b42e8d1c91b1f

commit 14303d0308170cca59f1a8dc0e9b42e8d1c91b1f
Author:     Trenton Schulz <trueos@norwegianrockcat.com>
AuthorDate: 2022-04-23 20:08:28 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2022-04-23 20:08:28 +0000

    devel/ros-urdfdom: Update to 3.0.2

    PR:             263143

 devel/ros-urdfdom/Makefile                         |  7 +++---
 devel/ros-urdfdom/distinfo                         |  6 ++---
 devel/ros-urdfdom/files/patch-CMakeLists.txt       | 17 +++----------
 .../files/patch-urdf__parser_CMakeLists.txt        | 29 +++++++++++-----------
 devel/ros-urdfdom/pkg-plist                        | 17 ++++++++-----
 5 files changed, 36 insertions(+), 40 deletions(-)