Bug 263185 - graphics/gd: picks up libimagequant, if installed, without recording the dependency
Summary: graphics/gd: picks up libimagequant, if installed, without recording the depe...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-09 17:57 UTC by Martin Birgmeier
Modified: 2022-04-15 06:51 UTC (History)
1 user (show)

See Also:
dinoex: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2022-04-09 17:57:50 UTC
Scenario:
- FreeBSD 12.3 latest patches
- ports latest
- Using a program which uses /usr/local/lib/libgd.so

Result:
- The program fails to start because it cannot dyamically link libimagequant.so
- libimagequant has not been installed because no explicit dependcy is recorded for it in libgd

Expected result:
- The program should start normally.

Fix:
- Either graphics/gd should be patched to never search for libimagequant, or the latter should be made a dependency of the former. Both approaches can be combined using a port option.

-- Martin
Comment 1 Martin Birgmeier 2022-04-09 18:27:26 UTC
To be added to the scenario:
- Ports are upgraded using portmaster (on a separate build machine)
- graphics/libimagequant is installed on the build machine but not on the target machine
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2022-04-15 05:42:41 UTC
Problem confirmed. I will add an option for support of this library.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-04-15 06:27:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e81eb93dd6fe13db218526e8410297dad2a61dfb

commit e81eb93dd6fe13db218526e8410297dad2a61dfb
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2022-04-15 06:25:56 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2022-04-15 06:25:56 +0000

    graphics/gd: new option LIQ

    PR: 263185

 graphics/gd/Makefile | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)
Comment 4 Martin Birgmeier 2022-04-15 06:51:56 UTC
Thank you!

-- Martin