Bug 263377 - [NEW PORT] net/intel-igb-kmod: out-of-tree driver for igb(4) from Intel-provided source
Summary: [NEW PORT] net/intel-igb-kmod: out-of-tree driver for igb(4) from Intel-provi...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Intel FreeBSD
URL:
Keywords: IntelNetworking
Depends on:
Blocks:
 
Reported: 2022-04-17 17:55 UTC by Joshua Kinard
Modified: 2023-06-06 16:29 UTC (History)
3 users (show)

See Also:


Attachments
Patch for new net/intel-igb-kmod port (2.18 KB, application/mbox)
2022-04-17 17:55 UTC, Joshua Kinard
no flags Details
Patch for new net/intel-igb-kmod port v2 (2.14 KB, patch)
2023-05-21 20:30 UTC, Joshua Kinard
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Kinard 2022-04-17 17:55:25 UTC
Created attachment 233282 [details]
Patch for new net/intel-igb-kmod port

For building out-of-tree drivers for Intel network adapters, there are several existing ports for em(4), ix(4), and ixl(4), but not igb(4).  I have a Protectli network appliance, VP2410, that uses this network adapter, so it is useful to have a port to easily rebuild the kernel module from time-to-time.

This is my first stab at a FreeBSD port, but it seems simple enough by basing off of the existing net/intel-em-kmod port makefile.  Unlike the em(4) port, this driver's source is FreeBSD 13.0-RELEASE-ready and did not require similar changes as found in intel-em-kmod's files/patch-base-r353844 (those changes already exist in the upstream source).

I believe it should also compile on FreeBSD 12.x, as I was using the same version under that release, though I do not have a 12.x install to actually test against anymore.  I also did a compile test against FreeBSD 13.1-RC3, which was successful, but haven't updated this particular appliance to that version yet.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-05-04 11:52:23 UTC
Thank you for your submission.  I'm sorry it didn't get looked at for so long.  I've CC'ed wireless@ to have a look at it as they are more qualified to review the port than I am.

For future submissions, please make sure to mark your patches as "patch" and set "maintainer-approval" to ensure they get looked at.
Comment 2 Bjoern A. Zeeb freebsd_committer freebsd_triage 2023-05-14 21:42:45 UTC
(In reply to Robert Clausecker from comment #1)

remove wireless@ from Cc: igb is wired.
Comment 3 Joshua Kinard 2023-05-21 20:30:53 UTC
Created attachment 242312 [details]
Patch for new net/intel-igb-kmod port v2

Updated the port to igb-2.5.24.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-06-06 16:29:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=349b6f14e413540bfaee748cf7dcb547205c91d5

commit 349b6f14e413540bfaee748cf7dcb547205c91d5
Author:     Joshua Kinard <jkinard@kumba.dev>
AuthorDate: 2023-05-21 20:23:40 +0000
Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
CommitDate: 2023-06-06 16:26:33 +0000

    net/intel-igb-kmod: out-of-tree device driver for igb(4) using Intel's updated driver source from downloadcenter.intel.com

    PR:     263377
    Submitted by:   freebsd@kumba.dev

 net/intel-igb-kmod/Makefile (new)  | 19 +++++++++++++++++++
 net/intel-igb-kmod/distinfo (new)  |  3 +++
 net/intel-igb-kmod/pkg-descr (new) |  2 ++
 3 files changed, 24 insertions(+)
Comment 5 Piotr Kubaj freebsd_committer freebsd_triage 2023-06-06 16:29:59 UTC
Committed, thanks!
Note that build on 14.0 it broken due to outdated DRIVER_MODULE().