Bug 263389 - archivers/paq: fix build on armv6/armv7
Summary: archivers/paq: fix build on armv6/armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Mikael Urankar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-18 09:50 UTC by Robert Clausecker
Modified: 2022-04-19 11:01 UTC (History)
1 user (show)

See Also:
fuz: merge-quarterly?

Attachments
archivers/paq: fix build on armv6/armv7 (1.32 KB, patch)
2022-04-18 09:50 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-04-18 09:50:38 UTC 
Created attachment 233298 [details]
archivers/paq: fix build on armv6/armv7

The ARM EABI has an unsigned char type.  Fix the build
by using explicitly signed chars in the relevant place.

Tested with Poudriere on armv7 arm64 FreeBSD 13.
The test suite still passes.
Please MFH this build fix.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-04-19 07:57:29 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6a9ffb1def637dff98c61432f10b610c7aecfedb

commit 6a9ffb1def637dff98c61432f10b610c7aecfedb
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-04-18 09:44:54 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2022-04-19 07:56:35 +0000

    archivers/zpaq: fix build on armv6/armv7

    The ARM EABI has an unsigned char type. Fix the build
    by using explicitly signed chars in the relevant place.

    PR:             263389

 archivers/paq/files/patch-libzpaq.cpp (new) | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2022-04-19 07:58:51 UTC 
Thanks!
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-04-19 09:50:30 UTC 
(In reply to Mikael Urankar from comment #2)

Hi Mikael,
Please don't forget to MFH this change.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-04-19 11:01:11 UTC 
A commit in branch 2022Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6c2554c83e6fe84fce2a725999eab044b8d17774

commit 6c2554c83e6fe84fce2a725999eab044b8d17774
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-04-18 09:44:54 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2022-04-19 11:00:37 +0000

    archivers/zpaq: fix build on armv6/armv7

    The ARM EABI has an unsigned char type. Fix the build
    by using explicitly signed chars in the relevant place.

    PR:             263389
    (cherry picked from commit 6a9ffb1def637dff98c61432f10b610c7aecfedb)

 archivers/paq/files/patch-libzpaq.cpp (new) | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)