Bug 263438 - www/grafana8: update to 8.4.6
Summary: www/grafana8: update to 8.4.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Neel Chauhan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-20 16:20 UTC by Sir l33tname
Modified: 2022-04-24 06:39 UTC (History)
4 users (show)

See Also:
drtr0jan: maintainer-feedback+

Attachments
updated patch (183.30 KB, patch)
2022-04-20 16:20 UTC, Sir l33tname 		no flags Details | Diff
update to grafana 8.4.7 using go 1.18 (185.32 KB, text/plain)
2022-04-21 07:40 UTC, jan 		no flags Details
update to grafana 8.4.7 using go 1.18 (184.21 KB, patch)
2022-04-21 08:31 UTC, jan 		no flags Details | Diff
grafana8.diff (128.93 KB, patch)
2022-04-22 09:13 UTC, Boris Korzun 		drtr0jan: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sir l33tname 2022-04-20 16:20:49 UTC 
Created attachment 233361 [details]
updated patch

Find all the info in #263251
Comment 1 jan 2022-04-21 07:40:48 UTC 
Created attachment 233366 [details]
update to grafana 8.4.7 using go 1.18

update to grafana 8.4.7 - using go 1.18 again

works for me, no crashes anymore
Comment 2 jan 2022-04-21 08:31:03 UTC 
Created attachment 233368 [details]
update to grafana 8.4.7 using go 1.18

had to update the patch (tabs vs. spaces and unnecessary comments in Makefiles.modules)
Comment 3 Sir l33tname 2022-04-22 07:46:22 UTC 
Very cool thanks Jan i just tested your patch on my system (testport output available if required) and it works fine on my installation
Comment 4 Boris Korzun 2022-04-22 09:13:31 UTC 
Created attachment 233391 [details]
grafana8.diff

(In reply to jan from comment #2)

Unfortunately I can't approve your patch by pkg-plist codestyle: you haven't replaced "%%GRAFANA_USER%%" to "grafana".
I've prepared correct patch. Tested by portfmt/testport and deploying.

Update to 8.4.7.
Changelog: https://grafana.com/docs/grafana/latest/whatsnew/whats-new-in-v8-4/
Comment 5 jan 2022-04-22 09:30:05 UTC 
(In reply to Boris Korzun from comment #4)

Thanks for the hint. I thought it's correct but it makes sense it's not.
Comment 6 Boris Korzun 2022-04-22 09:35:26 UTC 
(In reply to jan from comment #5)

It increases a patch size.
Comment 7 Neel Chauhan freebsd_committer freebsd_triage 2022-04-23 19:32:39 UTC 
Committed!
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-04-23 19:32:45 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=78cdab768d1bf5700df0ee2e69fa1f139ebd500d

commit 78cdab768d1bf5700df0ee2e69fa1f139ebd500d
Author:     Sir l33tname <sirl33tname@gmail.com>
AuthorDate: 2022-04-23 19:32:14 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-04-23 19:32:14 +0000

    www/grafana8: update to 8.4.6

    PR:             263438
    Approved by:    maintainer

 www/grafana8/Makefile         |   8 +-
 www/grafana8/Makefile.modules |  54 ++-
 www/grafana8/distinfo         | 110 +++---
 www/grafana8/pkg-plist        | 809 ++++++++++++++++++++++++++++--------------
 4 files changed, 628 insertions(+), 353 deletions(-)
Comment 9 Sir l33tname 2022-04-24 06:39:44 UTC 
Thanks everyone for making this happen!