Bug 263486 - math/cbc: Add option to compile with parallel capability
Summary: math/cbc: Add option to compile with parallel capability
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2022-04-23 07:33 UTC by Wes Dyk
Modified: 2022-04-23 16:45 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Add PARALLEL option to Makefile (633 bytes, patch)
2022-04-23 07:33 UTC, Wes Dyk 		no flags Details | Diff
Updated patch that passes portlint (584 bytes, patch)
2022-04-23 08:28 UTC, Wes Dyk 		aus129: maintainer-approval? (yuri)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wes Dyk 2022-04-23 07:33:32 UTC 
Created attachment 233415 [details]
Add PARALLEL option to Makefile

Cbc has a configure option enable-cbc-parallel. This enables the threads command in the solver. The attached patch provides the capability to enable this
Comment 1 Lorenzo Salvadore freebsd_committer freebsd_triage 2022-04-23 08:10:26 UTC 
^Triage:

- Please confirm this change passes QA (portlint, poudriere at least)

  For details and instructions, see:

  https://docs.freebsd.org/en/books/porters-handbook/#testing

- For ports bug report we usually format the summary as

  $category/$portname: $Summary

- Please set the maintainer-approval attachment flag (to ?) and set the requestee 
  field to the e-mail address of the maintainer to ask for maintainer approval

  Attachment -> Details -> maintainer-approval [?]


Thanks for submitting a patch!
Comment 2 Wes Dyk 2022-04-23 08:28:26 UTC 
Created attachment 233416 [details]
Updated patch that passes portlint

Updated patch to follow whitespace guidelines detected by portlint -C. Thanks for the pointers!
Comment 3 Wes Dyk 2022-04-23 08:42:39 UTC 
I have manually tested the port change. I am in the process of setting up poudriere.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-04-23 16:45:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=398794808864948a1969acce9bf189ea7b88a693

commit 398794808864948a1969acce9bf189ea7b88a693
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-04-23 16:42:22 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-04-23 16:45:05 +0000

    math/cbc: Enable parallel solver; add DEBUG option

    PR:             263486
    Original patch submitted by:    Wes Dyk <aus129@gmail.com>

 math/cbc/Makefile | 10 ++++++++++
 1 file changed, 10 insertions(+)
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2022-04-23 16:45:25 UTC 
Committed with changes.

Thanks for the patch!