Bug 263528 - multimedia/ffmpeg2theora: Mark DEPRECATED and set EXPIRATION_DATE
Summary: multimedia/ffmpeg2theora: Mark DEPRECATED and set EXPIRATION_DATE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-24 18:54 UTC by Daniel Engberg
Modified: 2022-05-10 15:48 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (wg)


Attachments
Patch for ffmpeg2theora (522 bytes, patch)
2022-04-24 18:54 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-04-24 18:54:00 UTC
Created attachment 233453 [details]
Patch for ffmpeg2theora

Theora itself hasn't seen development apart from minor fixes in over 10 years and have been superseded by H.264/H.265 and AV1 (depending on view regarding royalties) and by now this port has outlived its purpose. Users still wanting to encode in this format can still use ffmpeg as-is.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-04-24 18:55:50 UTC
I guess we could also add VP8 (WebM) for the sake of covering all bases. This application has already been removed in most larger package repositories.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-05-10 11:19:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2214ad3c409470eceeec0f507c7bb8c7dbfeab23

commit 2214ad3c409470eceeec0f507c7bb8c7dbfeab23
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-05-10 11:04:05 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-05-10 11:04:08 +0000

    multimedia/ffmpeg2theora: Deprecate and set expiration date to 2022-06-30

    Theora itself hasn't seen development apart from minor fixes in over 10
    years and have been superseded by AV1/H.264/H.265/VP8 and VP9 (depending
    on view regarding royalties) and by now this port has outlived its
    purpose. Users still wanting to encode in this format can still use
    ffmpeg as-is.

    PR:             263528
    Approved by:    wg (maintainer timeout, 2+ weeks)

 multimedia/ffmpeg2theora/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2022-05-10 15:48:01 UTC
Also helps bug 261302 due to http://www.ipv6proxy.net/go.php?u=http://package18.nyi.freebsd.org/data/122amd64-default-foo/2022-01-20_18h39m40s/logs/errors/ffmpeg2theora-0.30_6.log

For example, https://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff/d947464ad41e causes

src/subtitles.c:606:50: error: no member named 'pict' in 'struct AVSubtitleRect'
      const uint32_t *pal = (const uint32_t*)sr->pict.data[1];
                                             ~~  ^
src/subtitles.c:628:38: error: no member named 'pict' in 'struct AVSubtitleRect'
      memcpy(subtitle->kb.pixels,sr->pict.data[0],sr->w*sr->h);
                                 ~~  ^
src/ffmpeg2theora.c:155:12: warning: implicit declaration of function 'avpicture_get_size' is invalid in C99 [-Wimplicit-function-declaration]
    size = avpicture_get_size (pix_fmt, width, height);
           ^
src/ffmpeg2theora.c:161:5: warning: implicit declaration of function 'avpicture_fill' is invalid in C99 [-Wimplicit-function-declaration]
    avpicture_fill((AVPicture *) picture, picture_buf, pix_fmt, width, height);
    ^
src/ffmpeg2theora.c:161:32: error: expected expression
    avpicture_fill((AVPicture *) picture, picture_buf, pix_fmt, width, height);
                               ^
src/ffmpeg2theora.c:161:21: error: use of undeclared identifier 'AVPicture'; did you mean 'picture'?
    avpicture_fill((AVPicture *) picture, picture_buf, pix_fmt, width, height);
                    ^~~~~~~~~
                    picture
src/ffmpeg2theora.c:148:14: note: 'picture' declared here
    AVFrame *picture;
             ^
src/ffmpeg2theora.c:170:9: warning: implicit declaration of function 'avpicture_free' is invalid in C99 [-Wimplicit-function-declaration]
        avpicture_free((AVPicture*)frame);
        ^
src/ffmpeg2theora.c:170:35: error: expected expression
        avpicture_free((AVPicture*)frame);
                                  ^
src/ffmpeg2theora.c:170:25: error: use of undeclared identifier 'AVPicture'
        avpicture_free((AVPicture*)frame);
                        ^