Bug 263629 - net/haproxy: Build with prometheus exporter enabled by default
Summary: net/haproxy: Build with prometheus exporter enabled by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Sivachenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-28 13:02 UTC by Sascha Biberhofer
Modified: 2022-05-16 15:10 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (demon)


Attachments
net/haproxy: add PROMEX to OPTIONS_DEFAULT (502 bytes, patch)
2022-04-28 13:02 UTC, Sascha Biberhofer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Biberhofer 2022-04-28 13:02:41 UTC
Created attachment 233560 [details]
net/haproxy: add PROMEX to OPTIONS_DEFAULT

haproxy has included the option for a builtin prometheus supporter since 2.0. This exporter requires no extra dependencies and would be great to have enabled by default, as metrics collections is becoming more and more commonplace.

While an external haproxy_exporter is available (though not in ports yet), installing an extra package for a functionality that's available builtin seems suboptimal. Including this option by default would make life a bit easier and avoid the need for custom builds at no additional cost in terms of required packages, I think.

I've attached a patch to enable this in the current haproxy package. It might be interesting to also enable this for the other versions we're shipping. 

Feedback is very welcome, as always. :)

Cheers,
Sascha
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-04-30 15:28:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d2b302acd2a4c5902ea42af29e0f6c9959e8b883

commit d2b302acd2a4c5902ea42af29e0f6c9959e8b883
Author:     Dmitry Sivachenko <demon@FreeBSD.org>
AuthorDate: 2022-04-30 15:23:52 +0000
Commit:     Dmitry Sivachenko <demon@FreeBSD.org>
CommitDate: 2022-04-30 15:27:50 +0000

    net/haproxy: Enable prometheus exporter by default.

    PR: 263629
    Submitted by: Sascha Biberhofer <ports@skyforge.at>

 net/haproxy-devel/Makefile | 2 +-
 net/haproxy/Makefile       | 2 +-
 net/haproxy20/Makefile     | 2 +-
 net/haproxy21/Makefile     | 2 +-
 net/haproxy22/Makefile     | 2 +-
 net/haproxy23/Makefile     | 2 +-
 net/haproxy24/Makefile     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)
Comment 2 Dmitry Sivachenko freebsd_committer freebsd_triage 2022-04-30 15:29:41 UTC
Committed, sounds reasonable.