Created attachment 233784 [details] flask-jwt-extended.diff QA: * portlint: OK (looks fine.) * testport: OK (poudriere: 13.0, amd64 tested) * maketest: OK (164 passed)
Created attachment 233808 [details] Update to 4.4.0, using standardized pytest entry point Hi Goran, Thanks for the patch. It builds and installs fine. Since review D34693 is committed in #b731fff69c0f, adding USES=pytest seems sufficient instead of your do-test target. I changed your patch to it ;) As also included in your patch, www/py-flask-jwt-extended now uses www/py-flask v2.x, v1.x is no longer supported. However, this conflicts with sysutils/conan, where www/py-flask v1.x must still be used[1]. How do we want to handle this? [1] https://github.com/conan-io/conan/blob/649f1412eeefe2fe549751cbfaced8dd5a2cd200/conans/requirements.txt
(In reply to Rainer Hurling from comment #1) I have to answer myself to correct myself. Sorry. In fact www/py-flask v2.1.2 is already in the ports. What I meant instead is that there is a conflict between the two versions www/py-pyjwt1 and www/py-pyjwt (aka 2.1.2)[1]. sysutils/conan still needs v1.x here, www/py-flask-jwt-extended needs v2.x. Interestingly, there are no CONFLICTS_INSTALL entries in either port ... [1] pkg-static: py38-pyjwt-2.3.0_1 conflicts with py38-pyjwt1-1.7.1 (installs files into the same place). Problematic file: /usr/local/lib/python3.8/site-packages/jwt/__init__.py
The fix is added to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264146. Thank you for keeping me on my toes!
Created attachment 234506 [details] flask-jwt-extended 4.4.1
Hi Goran, Thanks for the updated patch. I will try to have a look this evening ;)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3192a093df47c443a137a169f43de6b753b0a6a6 commit 3192a093df47c443a137a169f43de6b753b0a6a6 Author: Goran Mekić <meka@tilda.center> AuthorDate: 2022-06-07 19:03:39 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2022-06-07 19:15:12 +0000 www/py-flask-jwt-extended: Update to 4.4.1 - Drop support for Flask 1 - Add verify_type argument to view decorators - Documentation improvements - Relax dependency pinning for cryptography package - Fix PEP 561 compatibility The port uses standardized pytest entry point now. Changelog: https://github.com/vimalloc/flask-jwt-extended/releases/tag/4.4.0 https://github.com/vimalloc/flask-jwt-extended/releases/tag/4.4.1 PR: 263834 www/py-flask-jwt-extended/Makefile | 17 ++++++----------- www/py-flask-jwt-extended/distinfo | 6 +++--- 2 files changed, 9 insertions(+), 14 deletions(-)
Hi Goran, Thanks again for your patch and updates. Committed now, have fun :)