Bug 263899 - graphics/gpu-firmware-kmod leaves work-* dirs after make clean
Summary: graphics/gpu-firmware-kmod leaves work-* dirs after make clean
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-10 16:39 UTC by gja822
Modified: 2022-11-15 20:22 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description gja822 2022-05-10 16:39:36 UTC 
When graphics/gpu-firmware-kmod built on FreeBSD-12 stable from ports' tree, it do not clean subdirs after make clean. It leaves ≈6GiB in work-* subdirectories in /usr/ports/graphics/gpu-firmware-amd-kmod /usr/ports/graphics/gpu-firmware-intel-kmod /usr/ports/graphics/gpu-firmware-radeon-kmod directories.

It was reproduced at least once, see https://forums.freebsd.org/threads/graphics-gpu-firmware-kmod-problem.85101/
Comment 1 Emmanuel Vadot freebsd_committer freebsd_triage 2022-05-11 06:59:00 UTC 
make clean works perfectly fine here, it cleans all the subport flavors. So I don't know what to say ...
Comment 2 gja822 2022-05-11 18:29:17 UTC 
(In reply to Emmanuel Vadot from comment #1)

Also on 12 branch?

After removing all gpu-firmware-\* ports and drm-fbsd12.0-kmod I install drm-fbsd12.0-kmod, the scrips says that after installation the port ans its dependencies it cleans gpu-firmware-amd gpu-firmware-intel gpu-firmware-radeon, but all work-\* subdirs in them remain. Could be deleted only manually.
Comment 3 Emmanuel Vadot freebsd_committer freebsd_triage 2022-05-11 20:22:05 UTC 
(In reply to gja822 from comment #2)

I don't have a 12.X branch (and don't care about 12.X TBH).
What "scripts" are you talking about ?
Comment 4 gja822 2022-05-12 04:13:18 UTC 
(In reply to Emmanuel Vadot from comment #3)
12.3 is a production release, I use 12-STABLE, so it should be supported.

I mean "scripts" of a Makefile (and its includes). When I issue command "make ; make install clean" from /usr/ports/graphics/drm-fbsd12.0-kmod directory
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-05-16 12:09:41 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2701f8e3a2cee6c986c9399702673fa81d2f903e

commit 2701f8e3a2cee6c986c9399702673fa81d2f903e
Author:     Emmanuel Vadot <manu@FreeBSD.org>
AuthorDate: 2022-05-16 12:06:25 +0000
Commit:     Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2022-05-16 12:08:27 +0000

    graphics/gpu-firmware-*-kmod: Remove defualt FLAVOR

    The default flavor is always the first of the list.
    Setting one make the port framework always use this one and so
    things like make clean will never clean all the flavors.
    This will lead to leave all the work-${FLAVOR} directories except
    for the default one if one is building graphics/gpu-firmware-kmod.

    PR:             263899
    Sponsored by:   Beckhoff Automation GmbH & Co. KG

 graphics/gpu-firmware-amd-kmod/Makefile    | 1 -
 graphics/gpu-firmware-intel-kmod/Makefile  | 1 -
 graphics/gpu-firmware-radeon-kmod/Makefile | 1 -
 3 files changed, 3 deletions(-)
Comment 6 Emmanuel Vadot freebsd_committer freebsd_triage 2022-05-16 12:10:43 UTC 
I believe that the issue you're seeing should be fixed now.
Comment 7 gja822 2022-05-21 19:16:10 UTC 
(In reply to Emmanuel Vadot from comment #6)

Yes, now I see it fixed, thank you.
Comment 8 Dmitry Marakasov freebsd_committer freebsd_triage 2022-11-15 20:22:14 UTC 
Confirmed fixed