Bug 263960 - x11-toolkits/wxgtk31: Use upstream release archive
Summary: x11-toolkits/wxgtk31: Use upstream release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-13 20:44 UTC by Daniel Engberg
Modified: 2022-07-12 06:48 UTC (History)
1 user (show)

See Also:
koobs: merge-quarterly?

Attachments
Patch for wxgtk31 (1.60 KB, patch)
2022-05-13 20:44 UTC, Daniel Engberg 		koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-05-13 20:44:09 UTC 
Created attachment 233900 [details]
Patch for wxgtk31

Use upstream release archive as recommended by Porters Handbook (USE_GITHUB section)

Tested with default port settings using Poudriere (12.3, amd64)
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-05-13 23:57:41 UTC 
^Triage: Reporter is committer, assign accordingly.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2022-05-13 23:58:13 UTC 
Comment on attachment 233900 [details]
Patch for wxgtk31

Approved by: portmgr (blanket: ports compliance)
Approved by: portmgr (unmaintained port)
MFH: 2022Q2
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-07-10 06:08:52 UTC 
lbartoletti, any comments? Patch might need a slight refresh
Comment 4 Loïc Bartoletti freebsd_committer freebsd_triage 2022-07-11 06:25:12 UTC 
(In reply to Daniel Engberg from comment #3)
Sorry, I haven't seen this issue. LGTM, go!
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-07-12 06:44:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7c05d3788b4ea2f8f37a5118842a2001424dd0e6

commit 7c05d3788b4ea2f8f37a5118842a2001424dd0e6
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-07-12 06:36:33 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-07-12 06:43:19 +0000

    x11-toolkits/wxgtk31: Use upstream release archive

    Use upstream release archive as recommended by Porters Handbook
    (USE_GITHUB section)

    PR:             263960
    Reviewed by:    koobs, lbartoletti
    Approved by:    portmgr (blanket)

 x11-toolkits/wxgtk31/Makefile | 8 +++-----
 x11-toolkits/wxgtk31/distinfo | 8 +++-----
 2 files changed, 6 insertions(+), 10 deletions(-)