Bug 264175 - sysutils/lscpu: unbreak on aarch64
Summary: sysutils/lscpu: unbreak on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks: 264144
  Show dependency tree / graph
 
Reported: 2022-05-23 14:26 UTC by Mikael Urankar
Modified: 2022-06-24 17:29 UTC (History)
1 user (show)

See Also:
zi: maintainer-feedback+
koobs: merge-quarterly?

Attachments
v0 (740 bytes, patch)
2022-05-23 14:26 UTC, Mikael Urankar 		koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2022-05-23 14:26:29 UTC 
Created attachment 234150 [details]
v0

It builds fine and reports correct cpu info on aarch64
/usr/ports/sysutils/lscpu/work/stage/usr/local/bin/lscpu 
Architecture:            arm64
Byte Order:              Little Endian
Total CPU(s):            4
Model name:              ARM Cortex-A57 r1p1
Comment 1 Ryan Steinmetz freebsd_committer freebsd_triage 2022-05-23 14:27:48 UTC 
Approved.
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2022-05-23 16:04:58 UTC 
I've just tried on an armv7 board and it also reports correct info:
/usr/ports/sysutils/lscpu/work/stage/usr/local/bin/lscpu 
Architecture:            arm
Byte Order:              Little Endian
Total CPU(s):            4
Model name:              ARM Cortex-A15 r3p3 (ECO: 0x00000000)

I propose to remove ONLY_FOR_ARCH if that's ok for you.
Comment 3 Ryan Steinmetz freebsd_committer freebsd_triage 2022-05-23 16:09:10 UTC 
Approved.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2022-05-24 00:59:57 UTC 
Comment on attachment 234150 [details]
v0

Approved by: zi (maintainer)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-05-24 09:12:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5bc90fd03f49fc9528524d3a7a6779584e8373c4

commit 5bc90fd03f49fc9528524d3a7a6779584e8373c4
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2022-05-23 16:56:16 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2022-05-24 08:59:46 +0000

    sysutils/lscpu: Remove ONLY_FOR_ARCHS

    It works on all supported architectures.

    PR:             264144 264175
    Reported by:    Graham Perrin
    Approved by:    zi

 sysutils/lscpu/Makefile | 2 --
 1 file changed, 2 deletions(-)