Bug 264215 - emulators/libretro-mame: fix fetch of distfiles, fix 32-bit / i386 build
Summary: emulators/libretro-mame: fix fetch of distfiles, fix 32-bit / i386 build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-25 04:29 UTC by Timothy Beyer
Modified: 2022-06-27 07:11 UTC (History)
3 users (show)

See Also:

Attachments
[PATCH 1/5] fix fetch of distfiles, fix 32-bit / i386 build of emulators/libretro-mame (3.08 KB, patch)
2022-05-25 04:29 UTC, Timothy Beyer 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Beyer 2022-05-25 04:29:20 UTC 
Created attachment 234182 [details]
[PATCH 1/5] fix fetch of distfiles, fix 32-bit / i386 build of emulators/libretro-mame

Fixes fetch of distfiles and fixes 32-bit / i386 build for emulators/libretro-mame.

Tested in poudriere with successful build of packages for FreeBSD 13.0-RELEASE (amd64 and i386) and FreeBSD 12.3-RELEASE (amd64 and i386)

patch generated by git format-patch

Regarding the fix for distinfo / distfiles, apparently every revision of libretro/mame on github changes once with the (HEAD -> master) eventually changing to a specific revision once it is no longer the newest revision, as made evident by this diff between an older extracted tarball:

diff -urN mame-ec47e94/3rdparty/lua-zlib/lua_zlib.c mame-ec47e94-new/3rdparty/lua-zlib/lua_zlib.c
--- mame-ec47e94/3rdparty/lua-zlib/lua_zlib.c   2022-01-24 13:33:37.000000000 -0800
+++ mame-ec47e94-new/3rdparty/lua-zlib/lua_zlib.c       2022-01-24 13:33:37.000000000 -0800
@@ -392,7 +392,7 @@

     SETLITERAL("_COPYRIGHT", "Copyright (c) 2009-2010 Brian Maher");
     SETLITERAL("_DESCRIPTION", "Yet another binding to the zlib library");
-    SETLITERAL("_VERSION", "lua-zlib $Id: b619258c75f480717fad20c113c3b1a35f888ce0 $  (HEAD -> master)");
+    SETLITERAL("_VERSION", "lua-zlib $Id: b619258c75f480717fad20c113c3b1a35f888ce0 $ ");

     /* Expose this to lua so we can do a test: */
     SETINT("_TEST_BUFSIZ", LUAL_BUFFERSIZE);
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-05-26 16:19:07 UTC 
^Triage: [tags] in issue Titles are deprecated.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-06-27 07:11:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a0109b55f2f188328d77c6a375a77c26ee0aa4d2

commit a0109b55f2f188328d77c6a375a77c26ee0aa4d2
Author:     Timothy Beyer <beyert@cs.ucr.edu>
AuthorDate: 2022-06-27 07:06:56 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-06-27 07:06:56 +0000

    emulators/libretro-mame: Fix fetch of distfiles, fix 32-bit / i386 build

    PR:             264215

 emulators/libretro-mame/Makefile                          | 15 +++++++++------
 emulators/libretro-mame/distinfo                          |  6 +++---
 .../libretro-mame/files/patch-Makefile.libretro (new)     | 11 +++++++++++
 3 files changed, 23 insertions(+), 9 deletions(-)