Created attachment 234197 [details] patch v1 Hi, I upgraded to latest head and keepassxc now fails to build. Attached patch addresses the issue. I did not make it conditional on the OS version because it seems to make no difference. The problem is lld refusing an option which it was accepting but I could not find any documentation for, so I guess it was a compatibility nop before. on 13.1: > ld --no-add-needed ld: error: no input files on head after 1400059: > ld --no-add-needed ld: error: unknown argument '--no-add-needed' so my patch simply removes that option from the command line. If required I can make it depend on __FreeBSD_version, by moving from a patch to a reinplace command in the Makefile, but as I said it looks like this linker option is actually a nop.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=19ceed92123e6e2612056b42566974421b6834de commit 19ceed92123e6e2612056b42566974421b6834de Author: Guido Falsi <madpilot@FreeBSD.org> AuthorDate: 2022-05-29 16:23:58 +0000 Commit: Li-Wen Hsu <lwhsu@FreeBSD.org> CommitDate: 2022-05-29 16:23:58 +0000 security/keepassxc: Fix build on recent head (after lld 14 import) PR: 264225 security/keepassxc/files/patch-CMakeLists.txt (new) | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
(In reply to Guido Falsi from comment #0) Thanks for the patch, after reading some more documents and testing, I think it might be able to be replaced by `--no-copy-dt-needed-entries` to keep the compatibility with GNU ld and easier to be accepted by upstream. I'll work on this more.
A commit in branch 2022Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b6b7a839ea2af3df87446a9acd42d78b8a016757 commit b6b7a839ea2af3df87446a9acd42d78b8a016757 Author: Guido Falsi <madpilot@FreeBSD.org> AuthorDate: 2022-05-29 16:23:58 +0000 Commit: Li-Wen Hsu <lwhsu@FreeBSD.org> CommitDate: 2022-05-29 16:31:29 +0000 security/keepassxc: Fix build on recent head (after lld 14 import) PR: 264225 (cherry picked from commit 19ceed92123e6e2612056b42566974421b6834de) security/keepassxc/files/patch-CMakeLists.txt (new) | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
Thanks!