Bug 264241 - emulators/open-vm-tools open-vm-tools 12.0.5 has been released
Summary: emulators/open-vm-tools open-vm-tools 12.0.5 has been released
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-25 16:16 UTC by John Wolfe
Modified: 2022-09-29 10:05 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (garga)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Wolfe 2022-05-25 16:16:37 UTC
Open-vm-tools 12.0.5 was released on May 24, 2022.

There are no new features or significant changes in the open-vm-tools 12.0.5 release. This is primarily a maintenance release that contains fixes for two potential FTBFS issues.

It contains a known problem - a potential FTBFS for 32-bit architectures.   A pointer to an available fix in the "devel" branch is provided in the Known Problems" section of the Release Notes.

For complete details, see: https://github.com/vmware/open-vm-tools/releases/tag/stable-12.0.5

Release Notes are available at: https://github.com/vmware/open-vm-tools/blob/stable-12.0.5/ReleaseNotes.md

The granular changes that have gone into the 12.0.5 release are in the ChangeLog at https://github.com/vmware/open-vm-tools/blob/stable-12.0.5/open-vm-tools/ChangeLog.

Please rebase open-vm-tools to release 12.0.5 on supported FreeBSD releases
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-08-12 13:29:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eb65cf5cbe543a6372834bee33243344bc40f737

commit eb65cf5cbe543a6372834bee33243344bc40f737
Author:     Renato Botelho <garga@FreeBSD.org>
AuthorDate: 2022-08-12 13:25:27 +0000
Commit:     Renato Botelho <garga@FreeBSD.org>
CommitDate: 2022-08-12 13:28:46 +0000

    emulators/open-vm-tools: Update to 12.0.5

    - Update to 12.0.5 [1]
    - Silence checkvm_cmd [2]

    PR:             264241 [1], 264564 [2]
    Reported by:    John Wolfe <jwolfe@vmware.com> [1], oz42@oz42.eu [2]
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

 emulators/open-vm-tools/Makefile               | 3 +--
 emulators/open-vm-tools/distinfo               | 6 +++---
 emulators/open-vm-tools/files/vmware-guestd.in | 4 ++--
 3 files changed, 6 insertions(+), 7 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-08-24 12:44:42 UTC
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8e55375b87609fef117ddd0f3e430ba512962e6c

commit 8e55375b87609fef117ddd0f3e430ba512962e6c
Author:     Renato Botelho <garga@FreeBSD.org>
AuthorDate: 2022-08-12 13:25:27 +0000
Commit:     Renato Botelho <garga@FreeBSD.org>
CommitDate: 2022-08-24 12:43:10 +0000

    emulators/open-vm-tools: Update to 12.0.5

    - Update to 12.0.5 [1]
    - Silence checkvm_cmd [2]

    PR:             264241 [1], 264564 [2]
    Reported by:    John Wolfe <jwolfe@vmware.com> [1], oz42@oz42.eu [2]
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

    (cherry picked from commit eb65cf5cbe543a6372834bee33243344bc40f737)

 emulators/open-vm-tools/Makefile               | 2 +-
 emulators/open-vm-tools/distinfo               | 6 +++---
 emulators/open-vm-tools/files/vmware-guestd.in | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)
Comment 3 Ray Bellis 2022-09-27 08:58:30 UTC
The patch in commit eb65cf5cbe543a6372834bee33243344bc40f737 to "silence checkvm_cmd" is incorrect.

This line:

checkvm_cmd="%%PREFIX%%/bin/vmware-checkvm > /dev/null 2>&1"

does not cause stdout and stderr redirection, it simply passes the three extra tokens to the vmware-checkvm command in argv.

The correct solution is to define checkvm_cmd as a function:

checkvm_cmd()
{
  %%PREFIX%%/bin/vmware-checkvm > /dev/null 2>&1
}

This error causes our puppet manifests to break because the extraneous output from `service vmware-guestd rcvar` causes puppet's FreeBSD "service" resource provider to barf.
Comment 4 Ray Bellis 2022-09-27 17:35:01 UTC
NB: changing this to a function does of course require changing
later uses of ${checkvm_cmd} to the bare word checkvm_cmd instead.
Comment 5 Ray Bellis 2022-09-28 22:23:41 UTC
I've submitted this as a new bug ID #264241
Comment 6 Ray Bellis 2022-09-29 10:05:21 UTC
I did of course mean #266694