Bug 264392 - x11-fm/Arqiver: Use upstream release archive
Summary: x11-fm/Arqiver: Use upstream release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexandre C. Guimarães
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-01 11:53 UTC by Daniel Engberg
Modified: 2022-06-01 19:21 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rigoletto)


Attachments
Patch for Arqiver (1.23 KB, patch)
2022-06-01 11:53 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-06-01 11:53:01 UTC
Created attachment 234373 [details]
Patch for Arqiver

Use upstream release archive as recommended by Porters Handbook (USE_GITHUB section)

Poudriere testport OK, FreeBSD 12.3 (amd64)
Comment 1 Alexandre C. Guimarães freebsd_committer freebsd_triage 2022-06-01 17:11:16 UTC
Hello,

There is some work going on of this port already, switching PORTNAME to full lower case but it brought some unexpected errors.

I will add your patch later.

Thank you.
Comment 2 Alexandre C. Guimarães freebsd_committer freebsd_triage 2022-06-01 17:34:27 UTC
Btw, the link you used doesn't work because there is no "V" before the version in the url. :-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-06-01 17:45:56 UTC
Works fine?

root@freebsd-dev:/usr/ports/x11-fm/Arqiver # make fetch
===>  License GPLv3 accepted by the user
===>   Arqiver-0.9.0 depends on file: /usr/local/sbin/pkg - found
=> Arqiver-0.9.0.tar.xz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch https://github.com/tsujan/Arqiver/releases/download/V0.9.0/Arqiver-0.9.0.tar.xz
Arqiver-0.9.0.tar.xz                                   118 kB 9643 kBps    00s
===> Fetching all distfiles required by Arqiver-0.9.0 for building

Do note the V before ${DISTVERSION} in the URL
MASTER_SITES=   https://github.com/tsujan/${PORTNAME}/releases/download/V${DISTVERSION}/
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-06-01 19:20:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e458adc8feb04597a0187acb269446e0253f99d0

commit e458adc8feb04597a0187acb269446e0253f99d0
Author:     Alexandre C. Guimarães <rigoletto@FreeBSD.org>
AuthorDate: 2022-06-01 19:14:41 +0000
Commit:     Alexandre C. Guimarães <rigoletto@FreeBSD.org>
CommitDate: 2022-06-01 19:14:41 +0000

    x11-fm/arqiver: convert PORTNAME to lowercase

    - use MASTER_SITES instead of USE_GITHUB
    - fix COMMENT in Makefile
    - add missing Oxford comma in pkg-descr
    PR:             264392
    Submitted by:   danfe, diizzy

 MOVED                                 |  1 +
 x11-fm/Arqiver/distinfo (gone)        |  3 ---
 x11-fm/Arqiver/pkg-plist (gone)       | 12 ------------
 x11-fm/Makefile                       |  2 +-
 x11-fm/{Arqiver => arqiver}/Makefile  | 12 +++++-------
 x11-fm/arqiver/distinfo (new)         |  3 +++
 x11-fm/{Arqiver => arqiver}/pkg-descr |  2 +-
 x11-fm/arqiver/pkg-plist (new)        | 12 ++++++++++++
 8 files changed, 23 insertions(+), 24 deletions(-)
Comment 5 Alexandre C. Guimarães freebsd_committer freebsd_triage 2022-06-01 19:21:05 UTC
Thank you.