Bug 264566 - audio/gtk-mixer: Update to 1.0.3
Summary: audio/gtk-mixer: Update to 1.0.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL: https://github.com/rozhuk-im/gtk-mixe...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-09 09:21 UTC by Ivan Rozhuk
Modified: 2022-06-11 10:58 UTC (History)
2 users (show)

See Also:
rozhuk.im: maintainer-feedback+

Attachments
update (1.16 KB, patch)
2022-06-09 09:21 UTC, Ivan Rozhuk 		rozhuk.im: maintainer-approval+
Details | Diff
update (1.70 KB, patch)
2022-06-11 03:55 UTC, Ivan Rozhuk 		rozhuk.im: maintainer-approval+
Details | Diff
update (1.71 KB, patch)
2022-06-11 03:56 UTC, Ivan Rozhuk 		rozhuk.im: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2022-06-09 09:21:20 UTC 
Created attachment 234574 [details]
update

- Faster GUI response on scroll
- Add flag -fno-delete-null-pointer-checks
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2022-06-10 21:45:02 UTC 
Hello,

This is a small port that can receive some block fixes and nice cosmetics:

1. portclippy Makefile

---
# USES block
USES
-USE_GNOME
USE_GITHUB
GH_ACCOUNT
+USE_GNOME

# Standard bsd.port.mk variables
+DESKTOP_ENTRIES

# Packaging list block
PLIST_FILES

-DESKTOP_ENTRIES
---

2. portfmt -D Makefile:

---
+DESKTOP_ENTRIES=       "GTK-Mixer" \
+                       "${COMMENT}" \
+                       "multimedia-volume-control" \
+                       "${PORTNAME}" \
+                       "GTK;AudioVideo;Audio;Mixer;" \
+                       true
-DESKTOP_ENTRIES="GTK-Mixer" "${COMMENT}" "multimedia-volume-control" \
-               "${PORTNAME}" "GTK;AudioVideo;Audio;Mixer;" true
---

Cheers
Comment 2 Ivan Rozhuk 2022-06-11 03:55:20 UTC 
Created attachment 234609 [details]
update

done
Comment 3 Ivan Rozhuk 2022-06-11 03:56:13 UTC 
Created attachment 234610 [details]
update
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-06-11 10:47:13 UTC 

---
====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/gtk-mixer is linked to /usr/local/lib/libharfbuzz.so.0 from print/harfbuzz but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libharfbuzz.so:print/harfbuzz
---
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-06-11 10:54:29 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=820efeac93bd6bf6c7f9965155c8264d4fee4a3f

commit 820efeac93bd6bf6c7f9965155c8264d4fee4a3f
Author:     Ivan Rozhuk <rozhuk.im@gmail.com>
AuthorDate: 2022-06-11 10:46:54 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-06-11 10:53:15 +0000

    audio/gtk-mixer: Update to 1.0.3

     - add LIB_DEPENDS=libharfbuzz.so:print/harfbuzz as needed
     - pet portclippy
     - reformat Makefile with portfmt

    ChangeLog: https://github.com/rozhuk-im/gtk-mixer/releases/tag/1.0.3

    PR:             264566

 audio/gtk-mixer/Makefile | 16 +++++++++++-----
 audio/gtk-mixer/distinfo |  6 +++---
 2 files changed, 14 insertions(+), 8 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2022-06-11 10:58:22 UTC 
Hello!

I fixed dependency error by adding LIB_DEPENDS+=libharfbuzz.so:print/harfbuzz to port. It builds ok now.

Committed, thanks you!