Bug 264611 - multimedia/gstreamer1-editing-services: update to 1.16.3 and use meson to fix Python issues
Summary: multimedia/gstreamer1-editing-services: update to 1.16.3 and use meson to fix...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords: patch
Depends on:
Blocks: 227897
  Show dependency treegraph
 
Reported: 2022-06-11 14:05 UTC by Matthias Andree
Modified: 2022-07-01 19:36 UTC (History)
4 users (show)

See Also:
mandree: maintainer-feedback-


Attachments
multimedia/gstreamer1-editing-services: update to 1.16.3 and use meson to fix Python issues (4.26 KB, patch)
2022-06-11 14:05 UTC, Matthias Andree
no flags Details | Diff
patch v2 to properly clean out PERL5, adding PR: no. (4.27 KB, patch)
2022-06-11 14:14 UTC, Matthias Andree
no flags Details | Diff
patch v3 to really clear PERL5 traces from the switch-to-meson and update (4.27 KB, patch)
2022-06-11 14:17 UTC, Matthias Andree
mandree: maintainer-approval? (multimedia)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2022-06-11 14:05:49 UTC
Created attachment 234614 [details]
multimedia/gstreamer1-editing-services: update to 1.16.3 and use meson to fix Python issues

gstreamer1-editing-services does not support Python 3.10 (reported by VVD) and also misdetects it if multiple versions installed, would give preference to 2.7 if installed.

vishwin and diizzy pointed out that gstreamer supports meson build, so let's go for it. vishwin has done some testing; versus his suggestion, my port drops the Perl5 dep and keeps the bash completion, and also adds gst-validator support.
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2022-06-11 14:14:38 UTC
Created attachment 234615 [details]
patch v2 to properly clean out PERL5, adding PR: no.

let's properly clear the port from all traces of Perl.
Comment 2 Matthias Andree freebsd_committer freebsd_triage 2022-06-11 14:17:22 UTC
Created attachment 234616 [details]
patch v3 to really clear PERL5 traces from the switch-to-meson and update

I should "git add" before "git commit --amend"... sorry for the noise.
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2022-06-11 14:18:41 UTC
Comment on attachment 234616 [details]
patch v3 to really clear PERL5 traces from the switch-to-meson and update

suggested commit log (missing approval yet):

* Switch to meson for the build, re-enabling Python 3.10+ compat.
* Add gstreamer1-validate support and LIB_DEPENDS.
* Drop __pycache__ from install and Perl5 and autotools from requisites.

Reported by:	VVD@unislabs.com (IRC)
Discussed with: vishwin@, diizzy@
PR:		264611
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-13 17:00:54 UTC
This patch must fix this pr: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227897
Comment 5 Matthias Andree freebsd_committer freebsd_triage 2022-06-13 19:08:59 UTC
(In reply to VVD from comment #4)
That is what it does.
Comment 6 Matthias Andree freebsd_committer freebsd_triage 2022-06-13 19:15:21 UTC
...or more precisely, it will pick up the python3 that meson was configured with.
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2022-06-14 14:54:52 UTC
Build fine for me. And dependent port too.
Comment 8 Matthias Andree freebsd_committer freebsd_triage 2022-06-30 20:58:14 UTC
maintainer timeout (19 d)
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-07-01 19:35:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e67fd2055284ecb769e1ea1b892c11ade54be1b0

commit e67fd2055284ecb769e1ea1b892c11ade54be1b0
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2022-06-11 13:44:28 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2022-07-01 19:35:09 +0000

    multimedia/gstreamer1-editing-services: update to 1.16.3 and use meson

    * Switch to meson for the build, re-enabling Python 3.10+ compat.
    * Add gstreamer1-validate support and LIB_DEPENDS.
    * Drop __pycache__ from install and Perl5 and autotools from requisites.

    Reported by:    VVD@unislabs.com (IRC)
    Discussed with: vishwin@, diizzy@
    PR:             264611
    Approved by:    maintainer timeout (multimedia@, 19 d)

 multimedia/gstreamer1-editing-services/Makefile  | 23 +++++++++++++----------
 multimedia/gstreamer1-editing-services/distinfo  |  6 +++---
 multimedia/gstreamer1-editing-services/pkg-plist |  4 ++--
 3 files changed, 18 insertions(+), 15 deletions(-)
Comment 10 Matthias Andree freebsd_committer freebsd_triage 2022-07-01 19:36:18 UTC
Took a bit longer than expected due to the Python default version bump which caused me to burn some CPU hours in poudriere.