Bug 264671 - lang/expect: Installed binaries should not be stripped WITH_DEBUG=yes
Summary: lang/expect: Installed binaries should not be stripped WITH_DEBUG=yes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-tcltk (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-14 20:06 UTC by Marcin Cieślak
Modified: 2022-06-15 19:25 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (tcltk)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Cieślak 2022-06-14 20:06:37 UTC 
Today I had to single step through expect and I found out that binaries get stripped on install despite WITH_DEBUG=yes.

Here's how I solved it:

# diff -u Makefile /tmp/Makefile.new
--- Makefile    2022-02-09 17:21:32.000000000 +0000
+++ /tmp/Makefile.new   2022-06-14 20:00:30.450493000 +0000
@@ -22,6 +22,7 @@
 SUB_FILES+=    pkg-message
 SUB_LIST+=     MANPREFIX=${MANPREFIX}
 TEST_TARGET=   test
+MAKE_ENV+=     STRIPPROG=${STRIP_CMD}

 post-install:
        ${LN} -sf ${DISTNAME}/lib${DISTNAME}.so \
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-06-15 07:03:51 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=20ba20cb4241e21fa9ef0bb9f18b65d15eb867d4

commit 20ba20cb4241e21fa9ef0bb9f18b65d15eb867d4
Author:     Pietro Cerutti <gahr@FreeBSD.org>
AuthorDate: 2022-06-15 07:02:05 +0000
Commit:     Pietro Cerutti <gahr@FreeBSD.org>
CommitDate: 2022-06-15 07:02:05 +0000

    lang/expect: don't strip binaries when WITH_DEBUG=yes

    PR:             264671
    Reported by:    Marcin Cieślak <saper@saper.info>

 lang/expect/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 2 Pietro Cerutti freebsd_committer freebsd_triage 2022-06-15 07:04:30 UTC 
Thanks!
Comment 3 Marcin Cieślak 2022-06-15 19:25:35 UTC 
If this is needed for some other ports (tcl or otherwise), maybe it should be added to bsd.port.mk (after line 1762) or Uses/tcl.mk?