Bug 264744 - security/headscale: Integrate with rc(8) and include a minimal working config
Summary: security/headscale: Integrate with rc(8) and include a minimal working config
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ben Woods
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2022-06-17 20:58 UTC by R. Christian McDonald
Modified: 2022-07-18 14:47 UTC (History)
3 users (show)

See Also:
m.muenz: maintainer-feedback+


Attachments
improvements to security/headscale (3.31 KB, patch)
2022-06-17 20:58 UTC, R. Christian McDonald
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description R. Christian McDonald 2022-06-17 20:58:28 UTC
Created attachment 234759 [details]
improvements to security/headscale

This patch introduces some improvements to security/headscale that others may find quite useful:
1. Patched the golang source to use `%%PREFIX%%/etc/headscale` instead of `/etc/headscale` for the configuration path.
2. Patched the included `config-example.yaml` to more closely align with FreeBSD hier(7).
3. Install this patched config to the path described in number 1 to provide a basic minimal configuration out of the box.
4. Integrate with rc(8) to support basic service enable/disable.
Comment 1 Michael Muenz 2022-07-04 06:41:44 UTC
Comment on attachment 234759 [details]
improvements to security/headscale

Applied your patch

portlint -A runs fine
poudriere testport without errors
poudriere bulk builds fine pkg, alls things in place.

Thx!
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-07-18 14:46:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=46a10c9786832983ef9b6afeebc030f8f4879bf2

commit 46a10c9786832983ef9b6afeebc030f8f4879bf2
Author:     Christian McDonald <cmcdonald@netgate.com>
AuthorDate: 2022-06-17 20:41:33 +0000
Commit:     Ben Woods <woodsb02@FreeBSD.org>
CommitDate: 2022-07-18 14:43:39 +0000

    security/headscale: add rc script and minimal working config

    - Include rc script to enable/disable headscale service
    - Follow heir(7) with regards to headscale db, cache, config locations
    - Include a minimal configuration out of the box

    PR:             264744
    Approved by:    Michael Muenz <m.muenz@gmail.com>

 security/headscale/Makefile                 | 24 +++++++++++++++--
 security/headscale/files/headscale.in (new) | 41 +++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+), 2 deletions(-)
Comment 3 Ben Woods freebsd_committer freebsd_triage 2022-07-18 14:47:29 UTC
Committed - thanks Christian and Michael!