Bug 264792 - java/openjdk8: Add CUPS option
Summary: java/openjdk8: Add CUPS option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-java (Nobody)
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2022-06-20 17:57 UTC by Eugene Grosbein
Modified: 2023-04-15 05:31 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (java)


Attachments
new CUPS port option (2.69 KB, patch)
2022-06-20 17:57 UTC, Eugene Grosbein
no flags Details | Diff
new CUPS port option (2.63 KB, patch)
2022-06-21 13:40 UTC, Eugene Grosbein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Grosbein freebsd_committer freebsd_triage 2022-06-20 17:57:55 UTC
Created attachment 234819 [details]
new CUPS port option

I need to build net-mgmt/unifi7 that is headless Java application that requires java/openjdk8 that depends on full CUPS port. In fact, it originally required cups-client port only that was later removed and merged to full cups port, so openjdk8 now requires full CUPS.

However, OpenJDK8 really needs only some header files out of CUPS distribution and officially supports building --with-cups-include instead of --with-cups.

Proposed patch introduces new CUPS port option to java/openjdk8 that defaults to ON to preserve current behaviour. With CUPS option turned OFF it skips build dependency on full cups: instead, it downloads and extracts its distfile and builds --with-cups-include pointing to extracted cups distfile.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-06-20 23:35:39 UTC
Could/should this apply to other Java ports?
Comment 2 Eugene Grosbein freebsd_committer freebsd_triage 2022-06-21 04:41:39 UTC
(In reply to Kubilay Kocak from comment #1)

I hope so, but I did not check it.
Comment 3 Eugene Grosbein freebsd_committer freebsd_triage 2022-06-21 13:40:02 UTC
Created attachment 234838 [details]
new CUPS port option

Fix some glitches in the patch
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-04-15 04:45:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3f3975ef8c2692cc0aedf26becd3ee6d2754fb81

commit 3f3975ef8c2692cc0aedf26becd3ee6d2754fb81
Author:     Eugene Grosbein <eugen@FreeBSD.org>
AuthorDate: 2023-04-15 04:27:37 +0000
Commit:     Eugene Grosbein <eugen@FreeBSD.org>
CommitDate: 2023-04-15 04:27:37 +0000

    java/openjdk11: add new CUPS port option

    UniFi controller is headless Java application that requires
    OpenJDK that depends on full CUPS port. In fact, the latter originally
    required cups-client port only that was later removed and merged
    to full cups port, so openjdk11 now requires full CUPS.

    However, OpenJDK really needs only some header files out of CUPS distribution
    and officially supports building --with-cups-include instead of --with-cups.

    This change introduces new CUPS port option to java/openjdk11
    that defaults to ON to preserve current behaviour.
    With CUPS option turned OFF it skips build dependency on full cups:
    instead, it downloads and extracts its distfile and
    builds --with-cups-include pointing to extracted cups distfile.

    Default build not affected, so PORTREVISION not changed.

    PR:             264792
    Approved by:    java (maintainer timeout, over 7 months)

 java/openjdk11/Makefile | 15 +++++++++++++--
 java/openjdk11/distinfo |  2 ++
 2 files changed, 15 insertions(+), 2 deletions(-)