Bug 264806 - net/sakisafecli: Update Makefile
Summary: net/sakisafecli: Update Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-21 13:03 UTC by qorg11
Modified: 2022-06-23 05:29 UTC (History)
1 user (show)

See Also:

Attachments
Patch for net/sakisafecli (1.10 KB, patch)
2022-06-21 13:03 UTC, qorg11 		no flags Details | Diff
Makefile patch that uses LOCALBASE (792 bytes, patch)
2022-06-22 11:50 UTC, qorg11 		no flags Details | Diff
Patch for net/sakisafecli (770 bytes, patch)
2022-06-22 16:18 UTC, qorg11 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description qorg11 2022-06-21 13:03:59 UTC 
Created attachment 234836 [details]
Patch for net/sakisafecli

Updated the MAINTAINER variable in the Makefile. Also repleaced -I/usr/local/include with -I${PREFIX}/include. Along other modifications to make it portlint compliant.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2022-06-21 13:03:59 UTC 
Maintainer informed via mail
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-06-22 05:53:39 UTC 
Are you sure the CFLAGS change is right? If ${PREFIX} becomes /opt/mydir/, do you want to include the headers that you find in /opt/mydir/include instead of those of the base system?

Don't you want USES=localbase instead?
Comment 3 qorg11 2022-06-22 11:50:57 UTC 
Created attachment 234854 [details]
Makefile patch that uses LOCALBASE
Comment 4 qorg11 2022-06-22 11:51:24 UTC 
(In reply to Fernando Apesteguía from comment #2)
I created a new attachment that uses localbase.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2022-06-22 15:06:11 UTC 
(In reply to qorg11 from comment #4)
Sorry I did not explain better. I meant using USES=localbase instead of
CFLAGS+= -I${LOCALBASE}/include
Comment 6 qorg11 2022-06-22 16:18:59 UTC 
Created attachment 234868 [details]
Patch for net/sakisafecli
Comment 7 qorg11 2022-06-22 16:19:11 UTC 
New attachment. Is this what you meant?
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2022-06-22 16:24:22 UTC 
(In reply to qorg11 from comment #7)
Yes, that's it.

Also we would need to bump PORTREVISION. I'll do it at commit time, no need to update a new patch.

Thanks!
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2022-06-23 05:29:04 UTC 
Committed,

Thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2022-06-23 05:29:41 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=801c2b13a723a443b043faaaec60bafe295cbcdb

commit 801c2b13a723a443b043faaaec60bafe295cbcdb
Author:     qorg11 <teru-sama@riseup.net>
AuthorDate: 2022-06-22 16:22:20 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-06-23 05:25:48 +0000

    net/sakisafecli: various Makefile updates

     * Update maintainer email address
     * Use localbase
     * Add dependency
     * Pet linters

    PR:     264806
    Reported by:    teru-sama@riseup.net (maintainer)

 net/sakisafecli/Makefile | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)