Bug 264844 - graphics/libdrm 2.4.111,1 fails to build in check-plist phase with TESTS=ON
Summary: graphics/libdrm 2.4.111,1 fails to build in check-plist phase with TESTS=ON
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-06-23 11:11 UTC by Ross McKelvie
Modified: 2022-07-21 13:13 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)


Attachments
poudriere testport log for graphics/libdrm (72.09 KB, text/plain)
2022-06-23 11:11 UTC, Ross McKelvie
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ross McKelvie 2022-06-23 11:11:25 UTC
Created attachment 234883 [details]
poudriere testport log for graphics/libdrm

graphics/libdrm (libdrm-2.4.111,1) fails to build with TESTS=on.

I have attached the poudriere testport log, from which the relevant lines are:

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: bin/amdgpu_stress
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: bin/kms-steal-crtc
Error: Missing: bin/kms-universal-planes
Error: Missing: bin/kmstest
===> Error: Plist issues found.

The port's description for TESTS=ON is "Install test programs (which are always built)". Is it possible that the test programs have changed upstream without plist being updated?

Workaround: The port builds successfully with TESTS=OFF.
Comment 1 Kevin Reinholz 2022-07-20 14:53:38 UTC
I experience the same issue with libdrm-2.4.112,1

The workaround TESTS=off still works. 

Alternatively, editing pkg-plist and removing the following 3 lines allows graphics/libdrm to be build with TESTS=on set:

%%TESTS%%bin/kms-steal-crtc
%%TESTS%%bin/kms-universal-planes
%%TESTS%%bin/kmstest
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-07-21 13:08:10 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0b2e583d850c4da4b6f28e05d180f196881ce82e

commit 0b2e583d850c4da4b6f28e05d180f196881ce82e
Author:     Emmanuel Vadot <manu@FreeBSD.org>
AuthorDate: 2022-07-21 12:54:03 +0000
Commit:     Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2022-07-21 13:01:04 +0000

    graphics/libdrm: Fix plist when TESTS options is selected

    PR:     264844
    Sponsored by:   Beckhoff Automation GmbH & Co. KG

 graphics/libdrm/Makefile  | 3 ++-
 graphics/libdrm/pkg-plist | 4 +---
 2 files changed, 3 insertions(+), 4 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-07-21 13:09:11 UTC
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=51a77db8fecc1722d25b8275a17863f52b1ffd97

commit 51a77db8fecc1722d25b8275a17863f52b1ffd97
Author:     Emmanuel Vadot <manu@FreeBSD.org>
AuthorDate: 2022-07-21 12:54:03 +0000
Commit:     Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2022-07-21 13:08:40 +0000

    graphics/libdrm: Fix plist when TESTS options is selected

    PR:     264844
    Sponsored by:   Beckhoff Automation GmbH & Co. KG

    (cherry picked from commit 0b2e583d850c4da4b6f28e05d180f196881ce82e)

 graphics/libdrm/Makefile  | 3 ++-
 graphics/libdrm/pkg-plist | 4 +---
 2 files changed, 3 insertions(+), 4 deletions(-)