Bug 265040 - devel/schilybase: 2022 schilytools touchup
Summary: devel/schilybase: 2022 schilytools touchup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://codeberg.org/schilytools/schi...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-05 04:00 UTC by Robert Clausecker
Modified: 2022-07-08 15:53 UTC (History)
1 user (show)

See Also:


Attachments
devel/schilybase: 2022 schilytools touchup (9.69 KB, patch)
2022-07-05 04:00 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff
devel/schilybase: avoid building profiled libs with -PROFILE (1.31 KB, patch)
2022-07-08 13:41 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-07-05 04:00:02 UTC
Created attachment 235076 [details]
devel/schilybase: 2022 schilytools touchup

Following Jörg Schilling's death in 2021, this is a light touch up of
the port in preparation of future updates at the project's new home.

 - Jörg's domains have started to run out.  Change the WWW to our new
   project lest they point to some unrelated site.
 - Instead of building profiled libraries and then throwing them out,
   have -PROFILE not build these in the first place.
 - Enable symbol versioning for hardening against mismatched library
   versions.  While tested well on Linux, this option was never enabled
   on FreeBSD due to Jörg's lack of experience with the system.  Given
   that the toolchain is pretty much the same, little to now issues are
   to be expected.
 - Relax schilybase dependency to just LIB_DEPENDS to simplify partial
   upgrades.  This is reasonably safe now that symbol versioning has
   been enabled.

WWW:		https://codeberg.org/schilytools/schilytools

Tested with Poudriere on i386 amd64 armv7 arm64 FreeBSD 13.1.
Do not MFH as the introduction of symbol versioning constitutes a breaking change to the libraries.
Please note that this patch touches a number of related ports.  It may be required to copy edit the commit message to pass the internal rules check.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-07-05 14:20:32 UTC
Please hold this patch for a second, the maintainer of textproc/htmldoc has received to an email I sent him and I want to update the patch to account for that if possible.  Will send an updated patch soon.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-05 16:26:34 UTC
(In reply to Robert Clausecker from comment #1)
Understood. Thanks for the heads up
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-07-06 17:06:21 UTC
You can proceed with the patch.  The issue raised will be resolved in a different manner.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-07 05:40:23 UTC
Committed,

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-07-07 05:40:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8ce2900d5aaffab13b961003114a97a48d00e59d

commit 8ce2900d5aaffab13b961003114a97a48d00e59d
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-07-05 05:07:47 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-07-07 05:35:24 +0000

    devel/schilybase: 2022 schilytools touchup

    Following Jörg Schilling's death in 2021, this is a light touch up of
    the port in preparation of future updates at the project's new home.

     - Jörg's domains have started to run out.  Change the WWW to our new
       project lest they point to some unrelated site.
     - Instead of building profiled libraries and then throwing them out,
       have -PROFILE not build these in the first place.
     - Enable symbol versioning for hardening against mismatched library
       versions.  While tested well on Linux, this option was never enabled
       on FreeBSD due to Jörg's lack of experience with the system.  Given
       that the toolchain is pretty much the same, little to now issues are
       to be expected.
     - Relax schilybase dependency to just LIB_DEPENDS to simplify partial
       upgrades.  This is reasonably safe now that symbol versioning has
       been enabled.

    WWW:            https://codeberg.org/schilytools/schilytools

    ChangeLog: https://codeberg.org/schilytools/schilytools

    PR:     265040
    Reported by:    fuz@fuz.su (maintainer)

 archivers/star/pkg-descr                           |  2 +-
 devel/sccs/pkg-descr                               |  2 +-
 devel/schilybase/Makefile.master                   |  8 ++++----
 .../files/patch-RULES_i386-freebsd-clang.rul (new) | 24 ++++++++++++++++++++++
 .../files/patch-RULES_i386-freebsd-gcc.rul (new)   | 24 ++++++++++++++++++++++
 devel/schilybase/pkg-descr                         |  2 +-
 devel/smake/pkg-descr                              |  2 +-
 devel/sunpromake/pkg-descr                         |  2 +-
 editors/ved/pkg-descr                              |  2 +-
 misc/schilytools/pkg-descr                         |  2 +-
 net/rscsi/pkg-descr                                |  2 +-
 sysutils/cdrtools/pkg-descr                        |  2 +-
 sysutils/schilyutils/pkg-descr                     |  2 +-
 13 files changed, 62 insertions(+), 14 deletions(-)
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2022-07-08 13:41:05 UTC
Created attachment 235125 [details]
devel/schilybase: avoid building profiled libs with -PROFILE

This patch was meant to be included into 8ce2900, but I had
performed the squash incorrectly.  It implements not building
profiled libraries in case of -PROFILE.

PR:             265040
See also:       8ce2900d5aaffab13b961003114a97a48d00e59d
Reported by:    fuz@fuz.su (maintainer)

I'm sorry for the inconvenience.
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2022-07-08 13:56:47 UTC
Reopened due to missing patch.
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-08 14:54:15 UTC
(In reply to Robert Clausecker from comment #7)
I'll take care of this.

Wouldn't this need a bump of PORTREVISION? If so, there is no need of a new patch.
Comment 9 Robert Clausecker freebsd_committer freebsd_triage 2022-07-08 15:35:30 UTC
(In reply to Fernando Apesteguía from comment #8)

I don't think a PORTREVISION bump is needed.  The patch merely avoids building a part that is discarded anyway, so the installed files will not change as a result of applying it (build times will be reduced though).

Thank you for working on this.
Comment 10 commit-hook freebsd_committer freebsd_triage 2022-07-08 15:52:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a1da7dade1dca186fbbbed3723dc7b8b0ad43e69

commit a1da7dade1dca186fbbbed3723dc7b8b0ad43e69
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-07-08 14:54:06 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-07-08 14:54:06 +0000

    devel/schilybase: avoid building profiled libs with -PROFILE

    This patch was meant to be included into 8ce2900. It implements not building
    profiled libraries in case of -PROFILE.

    PR:             265040
    Fixes:          8ce2900d5aaffab13b961003114a97a48d00e59d
    Reported by:    fuz@fuz.su (maintainer)

 devel/schilybase/Makefile | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 11 Fernando Apesteguía freebsd_committer freebsd_triage 2022-07-08 15:53:49 UTC
Committed,

Thanks!