Bug 265067 - [NEW PORT] deskutils/walld: Wallpaper daemon
Summary: [NEW PORT] deskutils/walld: Wallpaper daemon
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dries Michiels
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2022-07-06 20:49 UTC by Dotz0cat
Modified: 2022-07-10 08:17 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback? (Dotz0cat)


Attachments
diff for walld (2.03 KB, patch)
2022-07-06 20:49 UTC, Dotz0cat
no flags Details | Diff
moves the package to deskutils and removes unessacary variables (1.58 KB, patch)
2022-07-08 21:42 UTC, Dotz0cat
no flags Details | Diff
full patch for walld (2.07 KB, patch)
2022-07-10 05:26 UTC, Dotz0cat
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dotz0cat 2022-07-06 20:49:21 UTC
Created attachment 235100 [details]
diff for walld

A Wallpaper daemon. By default it changes wallpapers every 30 minutes.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2022-07-07 00:37:06 UTC
Minor review items:

- The following aren't necessary (their values inherit from / default to PORTNAME and PORTVERSION):

  GH_PROJECT=	walld
  GH_TAGNAME=	1.4.1

- Suggest primary category 'deskutils'

Could you also confirm the port passes QA (portlint, poudriere)
Comment 2 Dotz0cat 2022-07-08 21:42:59 UTC
Created attachment 235136 [details]
moves the package to deskutils and removes unessacary variables
Comment 3 Dotz0cat 2022-07-08 21:44:23 UTC
I can confirm that this passes portlint. I can also confirm that it builds on poudriere 13.1-RELEASE on amd64.
Comment 4 Dries Michiels freebsd_committer freebsd_triage 2022-07-09 18:42:23 UTC
Looks close to finished! Good work. Last nit; ideally we use the ports framework for as many things as we can as its more flexible when bumping default versions, etc. In this case, I see there is a "USES" for ImageMagick dependencies.

So preferred to use;

USES= magick:7,lib 
(in this case version 7 is the default https://cgit.freebsd.org/ports/tree/Mk/bsd.default-versions.mk
under the hood you can see here what it does: https://cgit.freebsd.org/ports/tree/Mk/Uses/magick.mk)

So we can concatenate to:
USES= magick,lib

over
LIB_DEPENDS= libMagickCore-7.so:graphics/ImageMagick7

Could you include all changes in one patch file?
Comment 5 Dotz0cat 2022-07-10 05:26:46 UTC
Created attachment 235163 [details]
full patch for walld
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-07-10 08:15:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7c4dd5a4b829a33391871ddf8107892217e611f9

commit 7c4dd5a4b829a33391871ddf8107892217e611f9
Author:     Dotz0cat <Dotz0cat@gmail.com>
AuthorDate: 2022-07-10 07:37:03 +0000
Commit:     Dries Michiels <driesm@FreeBSD.org>
CommitDate: 2022-07-10 08:13:38 +0000

    deskutils/walld: add new port

    Walld automatically changes the wallpaper. It sets the wallpaper
    through feh. It changes the wallpaper by default every 30 minutes.

    PR:     265067

 deskutils/Makefile              |  1 +
 deskutils/walld/Makefile (new)  | 20 ++++++++++++++++++++
 deskutils/walld/distinfo (new)  |  3 +++
 deskutils/walld/pkg-descr (new) |  4 ++++
 deskutils/walld/pkg-plist (new) |  3 +++
 5 files changed, 31 insertions(+)
Comment 7 Dries Michiels freebsd_committer freebsd_triage 2022-07-10 08:17:15 UTC
Committed, thanks!